$ date
--- stdout ---
Wed Nov 20 05:05:56 UTC 2024
--- end ---
$ git clone file:///srv/git/mediawiki-extensions-SVGEdit.git repo --depth=1 -b master
--- stderr ---
Cloning into 'repo'...
--- stdout ---
--- end ---
$ git config user.name libraryupgrader
--- stdout ---
--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---
--- end ---
$ git submodule update --init
--- stdout ---
--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.
--- end ---
$ git show-ref refs/heads/master
--- stdout ---
baff155e7fc9b44c9d110a5f228e44350bd80e20 refs/heads/master
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {
"cross-spawn": {
"name": "cross-spawn",
"severity": "high",
"isDirect": false,
"via": [
{
"source": 1100556,
"name": "cross-spawn",
"dependency": "cross-spawn",
"title": "Regular Expression Denial of Service (ReDoS) in cross-spawn",
"url": "https://github.com/advisories/GHSA-3xgq-45jj-v275",
"severity": "high",
"cwe": [
"CWE-1333"
],
"cvss": {
"score": 7.5,
"vectorString": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H"
},
"range": ">=7.0.0 <7.0.5"
}
],
"effects": [],
"range": "7.0.0 - 7.0.4",
"nodes": [
"node_modules/cross-spawn"
],
"fixAvailable": true
}
},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 1,
"critical": 0,
"total": 1
},
"dependencies": {
"prod": 1,
"dev": 416,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 416
}
}
}
--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 21 installs, 0 updates, 0 removals
- Locking composer/semver (3.4.3)
- Locking composer/spdx-licenses (1.5.8)
- Locking dealerdirect/phpcodesniffer-composer-installer (v1.0.0)
- Locking mediawiki/mediawiki-codesniffer (v45.0.0)
- Locking mediawiki/minus-x (1.1.3)
- Locking php-parallel-lint/php-console-color (v1.0.1)
- Locking php-parallel-lint/php-console-highlighter (v1.0.0)
- Locking php-parallel-lint/php-parallel-lint (v1.4.0)
- Locking phpcsstandards/phpcsextra (1.2.1)
- Locking phpcsstandards/phpcsutils (1.0.12)
- Locking psr/container (2.0.2)
- Locking squizlabs/php_codesniffer (3.10.3)
- Locking symfony/console (v7.1.8)
- Locking symfony/deprecation-contracts (v3.5.0)
- Locking symfony/polyfill-ctype (v1.31.0)
- Locking symfony/polyfill-intl-grapheme (v1.31.0)
- Locking symfony/polyfill-intl-normalizer (v1.31.0)
- Locking symfony/polyfill-mbstring (v1.31.0)
- Locking symfony/polyfill-php80 (v1.31.0)
- Locking symfony/service-contracts (v3.5.0)
- Locking symfony/string (v7.1.8)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 21 installs, 0 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Installing squizlabs/php_codesniffer (3.10.3): Extracting archive
- Installing dealerdirect/phpcodesniffer-composer-installer (v1.0.0): Extracting archive
- Installing symfony/polyfill-php80 (v1.31.0): Extracting archive
- Installing phpcsstandards/phpcsutils (1.0.12): Extracting archive
- Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive
- Installing symfony/polyfill-mbstring (v1.31.0): Extracting archive
- Installing composer/spdx-licenses (1.5.8): Extracting archive
- Installing composer/semver (3.4.3): Extracting archive
- Installing mediawiki/mediawiki-codesniffer (v45.0.0): Extracting archive
- Installing symfony/polyfill-intl-normalizer (v1.31.0): Extracting archive
- Installing symfony/polyfill-intl-grapheme (v1.31.0): Extracting archive
- Installing symfony/polyfill-ctype (v1.31.0): Extracting archive
- Installing symfony/string (v7.1.8): Extracting archive
- Installing symfony/deprecation-contracts (v3.5.0): Extracting archive
- Installing psr/container (2.0.2): Extracting archive
- Installing symfony/service-contracts (v3.5.0): Extracting archive
- Installing symfony/console (v7.1.8): Extracting archive
- Installing mediawiki/minus-x (1.1.3): Extracting archive
- Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
- Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
- Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive
0/19 [>---------------------------] 0%
19/19 [============================] 100%
Generating autoload files
14 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {
"cross-spawn": {
"name": "cross-spawn",
"severity": "high",
"isDirect": false,
"via": [
{
"source": 1100556,
"name": "cross-spawn",
"dependency": "cross-spawn",
"title": "Regular Expression Denial of Service (ReDoS) in cross-spawn",
"url": "https://github.com/advisories/GHSA-3xgq-45jj-v275",
"severity": "high",
"cwe": [
"CWE-1333"
],
"cvss": {
"score": 7.5,
"vectorString": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H"
},
"range": ">=7.0.0 <7.0.5"
}
],
"effects": [],
"range": "7.0.0 - 7.0.4",
"nodes": [
"node_modules/cross-spawn"
],
"fixAvailable": true
}
},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 1,
"critical": 0,
"total": 1
},
"dependencies": {
"prod": 1,
"dev": 416,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 416
}
}
}
--- end ---
Attempting to npm audit fix
$ /usr/bin/npm audit fix --dry-run --only=dev --json
--- stderr ---
npm WARN invalid config only="dev" set in command line options
npm WARN invalid config Must be one of: null, prod, production
--- stdout ---
{
"added": 416,
"removed": 0,
"changed": 0,
"audited": 417,
"funding": 90,
"audit": {
"auditReportVersion": 2,
"vulnerabilities": {
"cross-spawn": {
"name": "cross-spawn",
"severity": "high",
"isDirect": false,
"via": [
{
"source": 1100556,
"name": "cross-spawn",
"dependency": "cross-spawn",
"title": "Regular Expression Denial of Service (ReDoS) in cross-spawn",
"url": "https://github.com/advisories/GHSA-3xgq-45jj-v275",
"severity": "high",
"cwe": [
"CWE-1333"
],
"cvss": {
"score": 7.5,
"vectorString": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H"
},
"range": ">=7.0.0 <7.0.5"
}
],
"effects": [],
"range": "7.0.0 - 7.0.4",
"nodes": [
""
],
"fixAvailable": true
}
},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 1,
"critical": 0,
"total": 1
},
"dependencies": {
"prod": 1,
"dev": 416,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 416
}
}
}
}
--- end ---
{"added": 416, "removed": 0, "changed": 0, "audited": 417, "funding": 90, "audit": {"auditReportVersion": 2, "vulnerabilities": {"cross-spawn": {"name": "cross-spawn", "severity": "high", "isDirect": false, "via": [{"source": 1100556, "name": "cross-spawn", "dependency": "cross-spawn", "title": "Regular Expression Denial of Service (ReDoS) in cross-spawn", "url": "https://github.com/advisories/GHSA-3xgq-45jj-v275", "severity": "high", "cwe": ["CWE-1333"], "cvss": {"score": 7.5, "vectorString": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H"}, "range": ">=7.0.0 <7.0.5"}], "effects": [], "range": "7.0.0 - 7.0.4", "nodes": [""], "fixAvailable": true}}, "metadata": {"vulnerabilities": {"info": 0, "low": 0, "moderate": 0, "high": 1, "critical": 0, "total": 1}, "dependencies": {"prod": 1, "dev": 416, "optional": 0, "peer": 1, "peerOptional": 0, "total": 416}}}}
$ /usr/bin/npm audit fix --only=dev
--- stderr ---
npm WARN invalid config only="dev" set in command line options
npm WARN invalid config Must be one of: null, prod, production
--- stdout ---
added 416 packages, and audited 417 packages in 4s
90 packages are looking for funding
run `npm fund` for details
found 0 vulnerabilities
--- end ---
Verifying that tests still pass
$ /usr/bin/npm ci
--- stdout ---
added 416 packages, and audited 417 packages in 5s
90 packages are looking for funding
run `npm fund` for details
found 0 vulnerabilities
--- end ---
$ /usr/bin/npm test
--- stdout ---
> test
> grunt test
Running "eslint:all" (eslint) task
/src/repo/modules/ext.svgedit.editButton.js
4:1 warning Missing JSDoc @param "$" type jsdoc/require-param-type
5:1 warning Missing JSDoc @param "mw" type jsdoc/require-param-type
52:8 warning jQuery collection names must match the variablePattern no-jquery/variable-pattern
57:4 warning Avoid queries which search the entire DOM. Keep DOM nodes in memory where possible no-jquery/no-global-selector
/src/repo/modules/ext.svgedit.editor.js
4:1 warning Missing JSDoc @param "$" type jsdoc/require-param-type
5:1 warning Missing JSDoc @param "mw" type jsdoc/require-param-type
17:3 warning Missing JSDoc @return declaration jsdoc/require-returns
21:1 warning Syntax error in namepath: options: jsdoc/valid-types
21:1 warning Expected @param names to be "options". Got "options:, options" jsdoc/check-param-names
21:1 warning Missing JSDoc @param "options:" type jsdoc/require-param-type
24:1 warning This line has a length of 107. Maximum allowed is 100 max-len
25:1 warning This line has a length of 143. Maximum allowed is 100 max-len
26:1 warning Missing JSDoc @param "options" type jsdoc/require-param-type
45:1 warning Missing JSDoc @param "options" type jsdoc/require-param-type
46:1 warning Missing JSDoc @param "imageinfo" type jsdoc/require-param-type
66:1 warning This line has a length of 104. Maximum allowed is 100 max-len
67:1 warning This line has a length of 107. Maximum allowed is 100 max-len
71:5 warning jQuery collection names must match the variablePattern no-jquery/variable-pattern
86:8 warning jQuery collection names must match the variablePattern no-jquery/variable-pattern
86:16 warning Avoid queries which search the entire DOM. Keep DOM nodes in memory where possible no-jquery/no-global-selector
87:4 warning ES2024 Resizable ArrayBuffer is forbidden es-x/no-resizable-and-growable-arraybuffers
87:4 warning Avoid queries which search the entire DOM. Keep DOM nodes in memory where possible no-jquery/no-global-selector
93:4 warning Avoid queries which search the entire DOM. Keep DOM nodes in memory where possible no-jquery/no-global-selector
93:4 warning Prefer DOM building to parsing HTML literals no-jquery/no-parse-html-literal
94:8 warning jQuery collection names must match the variablePattern no-jquery/variable-pattern
94:18 warning Avoid queries which search the entire DOM. Keep DOM nodes in memory where possible no-jquery/no-global-selector
102:6 warning Avoid queries which search the entire DOM. Keep DOM nodes in memory where possible no-jquery/no-global-selector
106:7 warning Avoid queries which search the entire DOM. Keep DOM nodes in memory where possible no-jquery/no-global-selector
116:6 warning Avoid queries which search the entire DOM. Keep DOM nodes in memory where possible no-jquery/no-global-selector
117:6 warning Avoid queries which search the entire DOM. Keep DOM nodes in memory where possible no-jquery/no-global-selector
127:6 warning Avoid queries which search the entire DOM. Keep DOM nodes in memory where possible no-jquery/no-global-selector
128:6 warning Avoid queries which search the entire DOM. Keep DOM nodes in memory where possible no-jquery/no-global-selector
132:4 warning Avoid queries which search the entire DOM. Keep DOM nodes in memory where possible no-jquery/no-global-selector
135:4 warning Avoid queries which search the entire DOM. Keep DOM nodes in memory where possible no-jquery/no-global-selector
138:4 warning Avoid queries which search the entire DOM. Keep DOM nodes in memory where possible no-jquery/no-global-selector
143:21 warning Avoid queries which search the entire DOM. Keep DOM nodes in memory where possible no-jquery/no-global-selector
150:9 warning Unexpected alert no-alert
153:9 warning Unexpected alert no-alert
159:4 warning Avoid queries which search the entire DOM. Keep DOM nodes in memory where possible no-jquery/no-global-selector
167:4 warning Avoid queries which search the entire DOM. Keep DOM nodes in memory where possible no-jquery/no-global-selector
169:20 warning A constructor name should not start with a lowercase letter new-cap
169:20 warning 'embedded_svg_edit' is not defined no-undef
182:10 warning Unexpected alert no-alert
203:8 warning jQuery collection names must match the variablePattern no-jquery/variable-pattern
206:11 warning Avoid queries which search the entire DOM. Keep DOM nodes in memory where possible no-jquery/no-global-selector
207:20 warning Avoid queries which search the entire DOM. Keep DOM nodes in memory where possible no-jquery/no-global-selector
/src/repo/modules/ext.svgedit.embedapi.js
55:1 warning This line has a length of 130. Maximum allowed is 100 max-len
58:1 warning Unexpected function declaration in the global scope, wrap in an IIFE for a local variable, assign as global property for a global variable no-implicit-globals
58:10 warning Identifier 'embedded_svg_edit' is not in camel case camelcase
63:16 warning Identifier 'embedded_svg_edit' is not in camel case camelcase
67:1 warning This line has a length of 119. Maximum allowed is 100 max-len
68:1 warning This line has a length of 397. Maximum allowed is 100 max-len
70:1 warning This line has a length of 156. Maximum allowed is 100 max-len
79:9 warning 't' is already declared in the upper scope on line 92 column 6 no-shadow
83:1 warning This line has a length of 124. Maximum allowed is 100 max-len
83:27 warning 'args' declared on line 80 column 22 is used outside of binding context block-scoped-var
91:1 warning This line has a length of 110. Maximum allowed is 100 max-len
99:27 warning eval with argument of type BinaryExpression security/detect-eval-with-expression
99:27 warning eval can be harmful no-eval
105:1 warning This line has a length of 104. Maximum allowed is 100 max-len
109:1 warning Identifier 'embedded_svg_edit' is not in camel case camelcase
114:12 warning Avoid arguments.callee no-caller
122:5 warning Unexpected control character(s) in regular expression: \x00, \x1f no-control-regex
122:5 warning Unexpected combined character in character class no-misleading-character-class
122:9 warning Unnecessary escape character: \" no-useless-escape
142:1 warning Identifier 'embedded_svg_edit' is not in camel case camelcase
151:79 warning 'argstr' declared on line 146 column 12 is used outside of binding context block-scoped-var
/src/repo/modules/ext.svgedit.formmultipart.js
10:1 warning Missing JSDoc @param "fields" type jsdoc/require-param-type
13:1 warning Unexpected function declaration in the global scope, wrap in an IIFE for a local variable, assign as global property for a global variable no-implicit-globals
26:16 warning Do not access Object.prototype method 'hasOwnProperty' from target object no-prototype-builtins
/src/repo/modules/ext.svgedit.inline.js
4:1 warning Missing JSDoc @param "$" type jsdoc/require-param-type
5:1 warning Missing JSDoc @param "mw" type jsdoc/require-param-type
23:30 warning Unnecessary escape character: \/ no-useless-escape
23:40 warning Unnecessary escape character: \/ no-useless-escape
39:8 warning jQuery collection names must match the variablePattern no-jquery/variable-pattern
47:3 warning Avoid queries which search the entire DOM. Keep DOM nodes in memory where possible no-jquery/no-global-selector
/src/repo/modules/ext.svgedit.io.js
10:5 warning Unexpected 'var' declaration in the global scope, wrap in an IIFE for a local variable, assign as global property for a global variable no-implicit-globals
14:1 warning Missing JSDoc @return type jsdoc/require-returns-type
24:1 warning The type 'imageinfo' is undefined jsdoc/no-undefined-types
36:4 warning Prefer Array#forEach to $.each no-jquery/no-each-util
51:1 warning The type 'xmlSource' is undefined jsdoc/no-undefined-types
51:1 warning The type 'textStatus' is undefined jsdoc/no-undefined-types
51:1 warning The type 'xhr' is undefined jsdoc/no-undefined-types
52:1 warning The type 'xhr' is undefined jsdoc/no-undefined-types
52:1 warning The type 'textStatus' is undefined jsdoc/no-undefined-types
52:1 warning The type 'errorThrown' is undefined jsdoc/no-undefined-types
70:1 warning The type 'xmlSource' is undefined jsdoc/no-undefined-types
70:1 warning The type 'textStatus' is undefined jsdoc/no-undefined-types
70:1 warning The type 'xhr' is undefined jsdoc/no-undefined-types
84:1 warning Syntax error in namepath: target: jsdoc/valid-types
84:1 warning Expected @param names to be "target, callback". Got "target:, target, callback" jsdoc/check-param-names
85:1 warning Missing JSDoc @param "target" type jsdoc/require-param-type
86:1 warning The type 'token' is undefined jsdoc/no-undefined-types
98:4 warning Prefer Array#forEach to $.each no-jquery/no-each-util
108:1 warning Syntax error in namepath: target: jsdoc/valid-types
108:1 warning Expected @param names to be "target, data, comment, callback". Got "target:, data:, comment:, callback:, target, data, comment, callback" jsdoc/check-param-names
109:1 warning Syntax error in namepath: data: jsdoc/valid-types
110:1 warning Syntax error in namepath: comment: jsdoc/valid-types
111:1 warning The type 'textStatus' is undefined jsdoc/no-undefined-types
111:1 warning The type 'xhr' is undefined jsdoc/no-undefined-types
111:1 warning Syntax error in namepath: callback: jsdoc/valid-types
112:1 warning Missing JSDoc @param "target" type jsdoc/require-param-type
113:1 warning Missing JSDoc @param "data" type jsdoc/require-param-type
114:1 warning Missing JSDoc @param "comment" type jsdoc/require-param-type
115:1 warning Missing JSDoc @param "callback" type jsdoc/require-param-type
119:24 warning 'FormMultipart' is not defined no-undef
137:6 warning Unexpected alert no-alert
/src/repo/modules/ext.svgedit.toolbar.js
35:5 warning jQuery collection names must match the variablePattern no-jquery/variable-pattern
39:25 warning 'filename' is already declared in the upper scope on line 34 column 8 no-shadow
52:2 warning Avoid queries which search the entire DOM. Keep DOM nodes in memory where possible no-jquery/no-global-selector
✖ 110 problems (0 errors, 110 warnings)
Running "banana:SVGEdit" (banana) task
>> 1 message directory checked.
Running "stylelint:all" (stylelint) task
>> Linted 1 files without errors
Done.
--- end ---
{"1100556": {"source": 1100556, "name": "cross-spawn", "dependency": "cross-spawn", "title": "Regular Expression Denial of Service (ReDoS) in cross-spawn", "url": "https://github.com/advisories/GHSA-3xgq-45jj-v275", "severity": "high", "cwe": ["CWE-1333"], "cvss": {"score": 7.5, "vectorString": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H"}, "range": ">=7.0.0 <7.0.5"}}
Upgrading n:cross-spawn from 7.0.3 -> 7.0.6
$ package-lock-lint package-lock.json
--- stdout ---
Checking package-lock.json
--- end ---
build: Updating cross-spawn to 7.0.6
* https://github.com/advisories/GHSA-3xgq-45jj-v275
$ git add .
--- stdout ---
--- end ---
$ git commit -F /tmp/tmphvazdgjn
--- stdout ---
[master 2eca3b4] build: Updating cross-spawn to 7.0.6
1 file changed, 6 insertions(+), 6 deletions(-)
--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From 2eca3b4813720140944f52349d5f7e7e50ab69e8 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Wed, 20 Nov 2024 05:06:21 +0000
Subject: [PATCH] build: Updating cross-spawn to 7.0.6
* https://github.com/advisories/GHSA-3xgq-45jj-v275
Change-Id: I6b00529959536e4c2c9507f41584d4975df67e2a
---
package-lock.json | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/package-lock.json b/package-lock.json
index 0119f6f..0ca6d7e 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1005,9 +1005,9 @@
}
},
"node_modules/cross-spawn": {
- "version": "7.0.3",
- "resolved": "https://registry.npmjs.org/cross-spawn/-/cross-spawn-7.0.3.tgz",
- "integrity": "sha512-iRDPJKUPVEND7dHPO8rkbOnPpyDygcDFtWjpeWNCgy8WP2rXcxXL8TskReQl6OrB2G7+UJrags1q15Fudc7G6w==",
+ "version": "7.0.6",
+ "resolved": "https://registry.npmjs.org/cross-spawn/-/cross-spawn-7.0.6.tgz",
+ "integrity": "sha512-uV2QOWP2nWzsy2aMp8aRibhi9dlzF5Hgh5SHaB9OiTGEyDTiJJyx0uy51QXdyWbtAHNua4XJzUKca3OzKUd3vA==",
"dev": true,
"dependencies": {
"path-key": "^3.1.0",
@@ -5698,9 +5698,9 @@
}
},
"cross-spawn": {
- "version": "7.0.3",
- "resolved": "https://registry.npmjs.org/cross-spawn/-/cross-spawn-7.0.3.tgz",
- "integrity": "sha512-iRDPJKUPVEND7dHPO8rkbOnPpyDygcDFtWjpeWNCgy8WP2rXcxXL8TskReQl6OrB2G7+UJrags1q15Fudc7G6w==",
+ "version": "7.0.6",
+ "resolved": "https://registry.npmjs.org/cross-spawn/-/cross-spawn-7.0.6.tgz",
+ "integrity": "sha512-uV2QOWP2nWzsy2aMp8aRibhi9dlzF5Hgh5SHaB9OiTGEyDTiJJyx0uy51QXdyWbtAHNua4XJzUKca3OzKUd3vA==",
"dev": true,
"requires": {
"path-key": "^3.1.0",
--
2.39.2
--- end ---