$ date
--- stdout ---
Thu Nov 14 03:02:35 UTC 2024
--- end ---
$ git clone file:///srv/git/mediawiki-extensions-ConfigManager.git repo --depth=1 -b master
--- stderr ---
Cloning into 'repo'...
--- stdout ---
--- end ---
$ git config user.name libraryupgrader
--- stdout ---
--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---
--- end ---
$ git submodule update --init
--- stdout ---
--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.
--- end ---
$ git show-ref refs/heads/master
--- stdout ---
a35ddf1587c0fdc24d3f2e1717ec3977447303fa refs/heads/master
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 426,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 426
}
}
}
--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 22 installs, 0 updates, 0 removals
- Locking composer/installers (v1.12.0)
- Locking composer/semver (3.4.2)
- Locking composer/spdx-licenses (1.5.8)
- Locking dealerdirect/phpcodesniffer-composer-installer (v1.0.0)
- Locking mediawiki/mediawiki-codesniffer (v44.0.0)
- Locking mediawiki/minus-x (1.1.3)
- Locking php-parallel-lint/php-console-color (v1.0.1)
- Locking php-parallel-lint/php-console-highlighter (v1.0.0)
- Locking php-parallel-lint/php-parallel-lint (v1.4.0)
- Locking phpcsstandards/phpcsextra (1.2.1)
- Locking phpcsstandards/phpcsutils (1.0.11)
- Locking psr/container (2.0.2)
- Locking squizlabs/php_codesniffer (3.9.0)
- Locking symfony/console (v7.1.8)
- Locking symfony/deprecation-contracts (v3.5.0)
- Locking symfony/polyfill-ctype (v1.31.0)
- Locking symfony/polyfill-intl-grapheme (v1.31.0)
- Locking symfony/polyfill-intl-normalizer (v1.31.0)
- Locking symfony/polyfill-mbstring (v1.31.0)
- Locking symfony/polyfill-php80 (v1.31.0)
- Locking symfony/service-contracts (v3.5.0)
- Locking symfony/string (v7.1.8)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 22 installs, 0 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Installing composer/installers (v1.12.0): Extracting archive
- Installing squizlabs/php_codesniffer (3.9.0): Extracting archive
- Installing dealerdirect/phpcodesniffer-composer-installer (v1.0.0): Extracting archive
- Installing symfony/polyfill-php80 (v1.31.0): Extracting archive
- Installing phpcsstandards/phpcsutils (1.0.11): Extracting archive
- Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive
- Installing symfony/polyfill-mbstring (v1.31.0): Extracting archive
- Installing composer/spdx-licenses (1.5.8): Extracting archive
- Installing composer/semver (3.4.2): Extracting archive
- Installing mediawiki/mediawiki-codesniffer (v44.0.0): Extracting archive
- Installing symfony/polyfill-intl-normalizer (v1.31.0): Extracting archive
- Installing symfony/polyfill-intl-grapheme (v1.31.0): Extracting archive
- Installing symfony/polyfill-ctype (v1.31.0): Extracting archive
- Installing symfony/string (v7.1.8): Extracting archive
- Installing symfony/deprecation-contracts (v3.5.0): Extracting archive
- Installing psr/container (2.0.2): Extracting archive
- Installing symfony/service-contracts (v3.5.0): Extracting archive
- Installing symfony/console (v7.1.8): Extracting archive
- Installing mediawiki/minus-x (1.1.3): Extracting archive
- Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
- Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
- Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive
0/19 [>---------------------------] 0%
19/19 [============================] 100%
Generating autoload files
15 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Upgrading c:mediawiki/mediawiki-codesniffer from 44.0.0 -> 45.0.0
$ /usr/bin/composer update
--- stderr ---
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 4 updates, 0 removals
- Upgrading composer/semver (3.4.2 => 3.4.3)
- Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0)
- Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12)
- Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 4 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3): Extracting archive
- Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12): Extracting archive
- Upgrading composer/semver (3.4.2 => 3.4.3): Extracting archive
- Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0): Extracting archive
0/4 [>---------------------------] 0%
3/4 [=====================>------] 75%
4/4 [============================] 100%
Generating autoload files
15 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Previously failing phpcs rules: set()
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":2,"warnings":0,"fixable":2},"files":{"\/src\/repo\/src\/Data\/ConfigManager\/Record.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Api\/Store\/ConfigManager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AdminTool.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/languages\/ConfigManager.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Data\/ConfigManager\/Schema.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Data\/ConfigManager\/SecondaryDataProvider.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Data\/ConfigManager\/PrimaryDataProvider.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Data\/ConfigManager\/Writer.php":{"errors":1,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?\\IContextSource $context = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":22,"column":24}]},"\/src\/repo\/src\/ResourceLoader\/Messages.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Data\/ConfigManager\/Reader.php":{"errors":1,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?\\IContextSource $context = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":24,"column":9}]},"\/src\/repo\/src\/Data\/ConfigManager\/Store.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Special\/ConfigManager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Api\/Task\/ConfigManager.php":{"errors":0,"warnings":0,"messages":[]}}}
--- end ---
PHPCS run failed
$ vendor/bin/phpcbf
--- stdout ---
PHPCBF RESULT SUMMARY
----------------------------------------------------------------------
FILE FIXED REMAINING
----------------------------------------------------------------------
/src/repo/src/Data/ConfigManager/Writer.php 1 0
/src/repo/src/Data/ConfigManager/Reader.php 1 0
----------------------------------------------------------------------
A TOTAL OF 2 ERRORS WERE FIXED IN 2 FILES
----------------------------------------------------------------------
Time: 198ms; Memory: 6MB
--- end ---
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":0,"warnings":0,"fixable":0},"files":{"\/src\/repo\/languages\/ConfigManager.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AdminTool.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Api\/Store\/ConfigManager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Data\/ConfigManager\/Record.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ResourceLoader\/Messages.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Data\/ConfigManager\/PrimaryDataProvider.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Data\/ConfigManager\/Reader.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Special\/ConfigManager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Data\/ConfigManager\/Schema.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Data\/ConfigManager\/Writer.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Data\/ConfigManager\/SecondaryDataProvider.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Data\/ConfigManager\/Store.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Api\/Task\/ConfigManager.php":{"errors":0,"warnings":0,"messages":[]}}}
--- end ---
$ git checkout .phpcs.xml
--- stderr ---
Updated 1 path from the index
--- stdout ---
--- end ---
$ /usr/bin/composer install
--- stderr ---
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating autoload files
15 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
--- end ---
$ /usr/bin/composer test
--- stderr ---
> parallel-lint . --exclude vendor --exclude node_modules
> minus-x check .
> phpcs -sp --cache
--- stdout ---
PHP 8.2.20 | 10 parallel jobs
............. 13/13 (100%)
Checked 13 files in 0.1 seconds
No syntax error found
MinusX
======
Processing /src/repo...
.............................................................
.........................
All good!
............. 13 / 13 (100%)
Time: 129ms; Memory: 8MB
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 426,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 426
}
}
}
--- end ---
$ package-lock-lint package-lock.json
--- stdout ---
Checking package-lock.json
--- end ---
build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
$ git add .
--- stdout ---
--- end ---
$ git commit -F /tmp/tmpzw6dt0ai
--- stdout ---
[master 8886f6e] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
3 files changed, 3 insertions(+), 3 deletions(-)
--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From 8886f6ea6e98db1d6d384ad2373469420ab0bde8 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Thu, 14 Nov 2024 03:02:48 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
Change-Id: I2c5dee98658319d6be3ee7eda0156514e331b4a7
---
composer.json | 2 +-
src/Data/ConfigManager/Reader.php | 2 +-
src/Data/ConfigManager/Writer.php | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/composer.json b/composer.json
index 581dc33..a22f98e 100644
--- a/composer.json
+++ b/composer.json
@@ -7,7 +7,7 @@
"composer/installers": "~1.0"
},
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "44.0.0",
+ "mediawiki/mediawiki-codesniffer": "45.0.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
"php-parallel-lint/php-parallel-lint": "1.4.0"
diff --git a/src/Data/ConfigManager/Reader.php b/src/Data/ConfigManager/Reader.php
index 9a8bccb..b60391a 100644
--- a/src/Data/ConfigManager/Reader.php
+++ b/src/Data/ConfigManager/Reader.php
@@ -21,7 +21,7 @@ class Reader extends \BlueSpice\Data\Settings\Reader {
* @param \IContextSource|null $context
*/
public function __construct( ConfigDefinitionFactory $factory, $loadBalancer,
- \IContextSource $context = null ) {
+ ?\IContextSource $context = null ) {
parent::__construct( $loadBalancer, $context );
$this->factory = $factory;
}
diff --git a/src/Data/ConfigManager/Writer.php b/src/Data/ConfigManager/Writer.php
index 902a428..fdfde42 100644
--- a/src/Data/ConfigManager/Writer.php
+++ b/src/Data/ConfigManager/Writer.php
@@ -19,7 +19,7 @@ class Writer extends \BlueSpice\Data\Settings\Writer {
* @param \IContextSource|null $context
*/
public function __construct( ConfigDefinitionFactory $factory, \BlueSpice\Data\IReader $reader,
- $loadBalancer, \IContextSource $context = null ) {
+ $loadBalancer, ?\IContextSource $context = null ) {
parent::__construct( $reader, $loadBalancer, $context, $context->getConfig() );
$this->factory = $factory;
}
--
2.39.2
--- end ---