This run took 14 seconds.
From 204dea3b7f8a83c397f791fc71a60cbfd7111b51 Mon Sep 17 00:00:00 2001 From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org> Date: Sat, 1 Feb 2025 04:51:10 +0000 Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 46.0.0 Change-Id: If01403229fb76cc9572ce8a8fc671ffeeed59ce2 --- composer.json | 2 +- src/Hooks/Handlers/EventRegistrationFormHandler.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/composer.json b/composer.json index 8096a69..72d0aa9 100644 --- a/composer.json +++ b/composer.json @@ -1,6 +1,6 @@ { "require-dev": { - "mediawiki/mediawiki-codesniffer": "45.0.0", + "mediawiki/mediawiki-codesniffer": "46.0.0", "mediawiki/mediawiki-phan-config": "0.15.1", "mediawiki/minus-x": "1.1.3", "php-parallel-lint/php-console-highlighter": "1.0.0", diff --git a/src/Hooks/Handlers/EventRegistrationFormHandler.php b/src/Hooks/Handlers/EventRegistrationFormHandler.php index 955ba67..cf78b22 100644 --- a/src/Hooks/Handlers/EventRegistrationFormHandler.php +++ b/src/Hooks/Handlers/EventRegistrationFormHandler.php @@ -41,7 +41,7 @@ class EventRegistrationFormHandler implements 'placeholder-message' => 'wikimediacampaignevents-grant-id-input-placeholder', 'help-message' => 'wikimediacampaignevents-grant-id-input-help-message', 'section' => AbstractEventRegistrationSpecialPage::DETAILS_SECTION, - 'filter-callback' => fn ( $grantID ) => trim( (string)$grantID ), + 'filter-callback' => static fn ( $grantID ) => trim( (string)$grantID ), 'validation-callback' => function ( $grantID, $alldata ) use ( $currentGrantID ) { if ( $grantID === '' || $grantID === $currentGrantID ) { // Note that if a grant ID was once valid, we don't need to validate it again: it can only -- 2.39.2
$ date --- stdout --- Sat Feb 1 04:50:59 UTC 2025 --- end --- $ git clone file:///srv/git/mediawiki-extensions-WikimediaCampaignEvents.git repo --depth=1 -b master --- stderr --- Cloning into 'repo'... --- stdout --- --- end --- $ git config user.name libraryupgrader --- stdout --- --- end --- $ git config user.email tools.libraryupgrader@tools.wmflabs.org --- stdout --- --- end --- $ git submodule update --init --- stdout --- --- end --- $ grr init --- stdout --- Installed commit-msg hook. --- end --- $ git show-ref refs/heads/master --- stdout --- 9fd6fea9a550add6bbe8d20c064dec986925e796 refs/heads/master --- end --- $ /usr/bin/npm audit --json --- stdout --- { "auditReportVersion": 2, "vulnerabilities": {}, "metadata": { "vulnerabilities": { "info": 0, "low": 0, "moderate": 0, "high": 0, "critical": 0, "total": 0 }, "dependencies": { "prod": 1, "dev": 403, "optional": 0, "peer": 1, "peerOptional": 0, "total": 403 } } } --- end --- $ /usr/bin/composer install --- stderr --- No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information. Loading composer repositories with package information Updating dependencies Lock file operations: 38 installs, 0 updates, 0 removals - Locking composer/pcre (3.3.2) - Locking composer/semver (3.4.3) - Locking composer/spdx-licenses (1.5.8) - Locking composer/xdebug-handler (3.0.5) - Locking dealerdirect/phpcodesniffer-composer-installer (v1.0.0) - Locking doctrine/deprecations (1.1.4) - Locking felixfbecker/advanced-json-rpc (v3.2.1) - Locking mediawiki/mediawiki-codesniffer (v45.0.0) - Locking mediawiki/mediawiki-phan-config (0.15.1) - Locking mediawiki/minus-x (1.1.3) - Locking mediawiki/phan-taint-check-plugin (6.1.0) - Locking microsoft/tolerant-php-parser (v0.1.2) - Locking netresearch/jsonmapper (v4.5.0) - Locking phan/phan (5.4.5) - Locking php-parallel-lint/php-console-color (v1.0.1) - Locking php-parallel-lint/php-console-highlighter (v1.0.0) - Locking php-parallel-lint/php-parallel-lint (v1.4.0) - Locking phpcsstandards/phpcsextra (1.2.1) - Locking phpcsstandards/phpcsutils (1.0.12) - Locking phpdocumentor/reflection-common (2.2.0) - Locking phpdocumentor/reflection-docblock (5.6.1) - Locking phpdocumentor/type-resolver (1.10.0) - Locking phpstan/phpdoc-parser (2.0.0) - Locking psr/container (2.0.2) - Locking psr/log (3.0.2) - Locking sabre/event (5.1.7) - Locking squizlabs/php_codesniffer (3.10.3) - Locking symfony/console (v7.2.1) - Locking symfony/deprecation-contracts (v3.5.1) - Locking symfony/polyfill-ctype (v1.31.0) - Locking symfony/polyfill-intl-grapheme (v1.31.0) - Locking symfony/polyfill-intl-normalizer (v1.31.0) - Locking symfony/polyfill-mbstring (v1.31.0) - Locking symfony/polyfill-php80 (v1.31.0) - Locking symfony/service-contracts (v3.5.1) - Locking symfony/string (v7.2.0) - Locking tysonandre/var_representation_polyfill (0.1.3) - Locking webmozart/assert (1.11.0) Writing lock file Installing dependencies from lock file (including require-dev) Package operations: 38 installs, 0 updates, 0 removals 0 [>---------------------------] 0 [->--------------------------] - Installing squizlabs/php_codesniffer (3.10.3): Extracting archive - Installing dealerdirect/phpcodesniffer-composer-installer (v1.0.0): Extracting archive - Installing composer/pcre (3.3.2): Extracting archive - Installing symfony/polyfill-php80 (v1.31.0): Extracting archive - Installing phpcsstandards/phpcsutils (1.0.12): Extracting archive - Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive - Installing symfony/polyfill-mbstring (v1.31.0): Extracting archive - Installing composer/spdx-licenses (1.5.8): Extracting archive - Installing composer/semver (3.4.3): Extracting archive - Installing mediawiki/mediawiki-codesniffer (v45.0.0): Extracting archive - Installing tysonandre/var_representation_polyfill (0.1.3): Extracting archive - Installing symfony/polyfill-intl-normalizer (v1.31.0): Extracting archive - Installing symfony/polyfill-intl-grapheme (v1.31.0): Extracting archive - Installing symfony/polyfill-ctype (v1.31.0): Extracting archive - Installing symfony/string (v7.2.0): Extracting archive - Installing symfony/deprecation-contracts (v3.5.1): Extracting archive - Installing psr/container (2.0.2): Extracting archive - Installing symfony/service-contracts (v3.5.1): Extracting archive - Installing symfony/console (v7.2.1): Extracting archive - Installing sabre/event (5.1.7): Extracting archive - Installing netresearch/jsonmapper (v4.5.0): Extracting archive - Installing microsoft/tolerant-php-parser (v0.1.2): Extracting archive - Installing webmozart/assert (1.11.0): Extracting archive - Installing phpstan/phpdoc-parser (2.0.0): Extracting archive - Installing phpdocumentor/reflection-common (2.2.0): Extracting archive - Installing doctrine/deprecations (1.1.4): Extracting archive - Installing phpdocumentor/type-resolver (1.10.0): Extracting archive - Installing phpdocumentor/reflection-docblock (5.6.1): Extracting archive - Installing felixfbecker/advanced-json-rpc (v3.2.1): Extracting archive - Installing psr/log (3.0.2): Extracting archive - Installing composer/xdebug-handler (3.0.5): Extracting archive - Installing phan/phan (5.4.5): Extracting archive - Installing mediawiki/phan-taint-check-plugin (6.1.0): Extracting archive - Installing mediawiki/mediawiki-phan-config (0.15.1): Extracting archive - Installing mediawiki/minus-x (1.1.3): Extracting archive - Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive - Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive - Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive 0/36 [>---------------------------] 0% 20/36 [===============>------------] 55% 35/36 [===========================>] 97% 36/36 [============================] 100% 1 package suggestions were added by new dependencies, use `composer suggest` to see details. Generating autoload files 16 packages you are using are looking for funding. Use the `composer fund` command to find out more! --- stdout --- PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils --- end --- Upgrading c:mediawiki/mediawiki-codesniffer from 45.0.0 -> 46.0.0 $ /usr/bin/composer update --- stderr --- Loading composer repositories with package information Updating dependencies Lock file operations: 0 installs, 2 updates, 0 removals - Upgrading mediawiki/mediawiki-codesniffer (v45.0.0 => v46.0.0) - Upgrading squizlabs/php_codesniffer (3.10.3 => 3.11.3) Writing lock file Installing dependencies from lock file (including require-dev) Package operations: 0 installs, 2 updates, 0 removals 0 [>---------------------------] 0 [->--------------------------] - Upgrading squizlabs/php_codesniffer (3.10.3 => 3.11.3): Extracting archive - Upgrading mediawiki/mediawiki-codesniffer (v45.0.0 => v46.0.0): Extracting archive 0/2 [>---------------------------] 0% 1/2 [==============>-------------] 50% 2/2 [============================] 100% Generating autoload files 16 packages you are using are looking for funding. Use the `composer fund` command to find out more! No security vulnerability advisories found --- stdout --- PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils --- end --- $ vendor/bin/phpcs --report=json --- stdout --- {"totals":{"errors":0,"warnings":1,"fixable":1},"files":{"\/src\/repo\/src\/WikiProject\/CannotQueryWikibaseException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/WikiProject\/CannotQueryWDQSException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Grants\/Exception\/AuthenticationException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/WikiProject\/CannotQueryWikiProjectsException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Grants\/Exception\/InvalidGrantIDException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ServiceWiring.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hooks\/Handlers\/SchemaChangesHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hooks\/Handlers\/PageCollectionHookHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Grants\/Exception\/FluxxRequestException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/GetGrantIdHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hooks\/Handlers\/EventDetailsHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/WikimediaCampaignEventsServices.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/WikimediaCampaignEventsExtensionJsonTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hooks\/Handlers\/EventRegistrationFormHandler.php":{"errors":0,"warnings":1,"messages":[{"message":"Use static closure","source":"MediaWiki.Usage.StaticClosure.StaticClosure","severity":5,"fixable":true,"type":"WARNING","line":44,"column":34}]},"\/src\/repo\/src\/Grants\/GrantsStore.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/Grants\/Rest\/UpdateGrantIdHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/DeleteGrantIdHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Grants\/GrantIDLookup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/WikiProject\/WikiProjectIDLookup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/Grants\/Rest\/DeleteGrantIdHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/UpdateGrantIdHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/WikimediaCampaignEventsServicesTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ActionApi\/ApiQueryPageCollectionsMetadata.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/WikiProject\/WikiProjectFullLookup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Grants\/GrantsStoreTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/Grants\/Rest\/GetGrantIdHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/Grants\/FluxxClientTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/WikiProject\/WikiProjectFullLookupTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Grants\/FluxxClient.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/Grants\/GrantIDLookupTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hooks\/Handlers\/CollaborationListHandler.php":{"errors":0,"warnings":0,"messages":[]}}} --- end --- PHPCS run failed $ vendor/bin/phpcbf --- stdout --- PHPCBF RESULT SUMMARY -------------------------------------------------------------------------------- FILE FIXED REMAINING -------------------------------------------------------------------------------- /src/repo/src/Hooks/Handlers/EventRegistrationFormHandler.php 1 0 -------------------------------------------------------------------------------- A TOTAL OF 1 ERROR WERE FIXED IN 1 FILE -------------------------------------------------------------------------------- Time: 510ms; Memory: 6MB --- end --- $ vendor/bin/phpcs --report=json --- stdout --- {"totals":{"errors":0,"warnings":0,"fixable":0},"files":{"\/src\/repo\/src\/WikiProject\/CannotQueryWikibaseException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/WikiProject\/CannotQueryWikiProjectsException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/WikiProject\/CannotQueryWDQSException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Grants\/Exception\/InvalidGrantIDException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Grants\/Exception\/FluxxRequestException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Grants\/Exception\/AuthenticationException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hooks\/Handlers\/SchemaChangesHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hooks\/Handlers\/EventDetailsHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Grants\/GrantsStore.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hooks\/Handlers\/PageCollectionHookHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/WikimediaCampaignEventsServices.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Grants\/GrantIDLookup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hooks\/Handlers\/EventRegistrationFormHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ServiceWiring.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ActionApi\/ApiQueryPageCollectionsMetadata.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/GetGrantIdHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/WikiProject\/WikiProjectIDLookup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/WikimediaCampaignEventsExtensionJsonTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/DeleteGrantIdHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/WikimediaCampaignEventsServicesTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/Grants\/FluxxClientTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/UpdateGrantIdHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/Grants\/Rest\/UpdateGrantIdHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/Grants\/Rest\/DeleteGrantIdHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/Grants\/GrantIDLookupTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/Grants\/Rest\/GetGrantIdHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Grants\/GrantsStoreTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/WikiProject\/WikiProjectFullLookupTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/WikiProject\/WikiProjectFullLookup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Grants\/FluxxClient.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hooks\/Handlers\/CollaborationListHandler.php":{"errors":0,"warnings":0,"messages":[]}}} --- end --- $ git checkout .phpcs.xml --- stderr --- Updated 0 paths from the index --- stdout --- --- end --- $ /usr/bin/composer install --- stderr --- Installing dependencies from lock file (including require-dev) Verifying lock file contents can be installed on current platform. Nothing to install, update or remove Generating autoload files 16 packages you are using are looking for funding. Use the `composer fund` command to find out more! --- stdout --- --- end --- $ /usr/bin/composer test --- stderr --- > parallel-lint . --exclude node_modules --exclude vendor > phpcs -sp --cache > minus-x check . --- stdout --- PHP 8.2.20 | 10 parallel jobs ................................ 32/32 (100%) Checked 32 files in 0.2 seconds No syntax error found ................................ 32 / 32 (100%) Time: 272ms; Memory: 18MB MinusX ====== Processing /src/repo... ............................................................. .................................................. All good! --- end --- $ /usr/bin/npm audit --json --- stdout --- { "auditReportVersion": 2, "vulnerabilities": {}, "metadata": { "vulnerabilities": { "info": 0, "low": 0, "moderate": 0, "high": 0, "critical": 0, "total": 0 }, "dependencies": { "prod": 1, "dev": 403, "optional": 0, "peer": 1, "peerOptional": 0, "total": 403 } } } --- end --- $ package-lock-lint package-lock.json --- stdout --- Checking package-lock.json --- end --- build: Updating mediawiki/mediawiki-codesniffer to 46.0.0 $ git add . --- stdout --- --- end --- $ git commit -F /tmp/tmpvmdsf1e9 --- stdout --- [master 204dea3] build: Updating mediawiki/mediawiki-codesniffer to 46.0.0 2 files changed, 2 insertions(+), 2 deletions(-) --- end --- $ git format-patch HEAD~1 --stdout --- stdout --- From 204dea3b7f8a83c397f791fc71a60cbfd7111b51 Mon Sep 17 00:00:00 2001 From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org> Date: Sat, 1 Feb 2025 04:51:10 +0000 Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 46.0.0 Change-Id: If01403229fb76cc9572ce8a8fc671ffeeed59ce2 --- composer.json | 2 +- src/Hooks/Handlers/EventRegistrationFormHandler.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/composer.json b/composer.json index 8096a69..72d0aa9 100644 --- a/composer.json +++ b/composer.json @@ -1,6 +1,6 @@ { "require-dev": { - "mediawiki/mediawiki-codesniffer": "45.0.0", + "mediawiki/mediawiki-codesniffer": "46.0.0", "mediawiki/mediawiki-phan-config": "0.15.1", "mediawiki/minus-x": "1.1.3", "php-parallel-lint/php-console-highlighter": "1.0.0", diff --git a/src/Hooks/Handlers/EventRegistrationFormHandler.php b/src/Hooks/Handlers/EventRegistrationFormHandler.php index 955ba67..cf78b22 100644 --- a/src/Hooks/Handlers/EventRegistrationFormHandler.php +++ b/src/Hooks/Handlers/EventRegistrationFormHandler.php @@ -41,7 +41,7 @@ class EventRegistrationFormHandler implements 'placeholder-message' => 'wikimediacampaignevents-grant-id-input-placeholder', 'help-message' => 'wikimediacampaignevents-grant-id-input-help-message', 'section' => AbstractEventRegistrationSpecialPage::DETAILS_SECTION, - 'filter-callback' => fn ( $grantID ) => trim( (string)$grantID ), + 'filter-callback' => static fn ( $grantID ) => trim( (string)$grantID ), 'validation-callback' => function ( $grantID, $alldata ) use ( $currentGrantID ) { if ( $grantID === '' || $grantID === $currentGrantID ) { // Note that if a grant ID was once valid, we don't need to validate it again: it can only -- 2.39.2 --- end ---