This run took 19 seconds.
From 0836218537fd0384e61f2a7c58d6553e6abda322 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Sat, 1 Feb 2025 01:31:30 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 46.0.0
Change-Id: Iea139101c2756b1a456aa3e865076426a06f25e2
---
composer.json | 2 +-
tests/phpunit/Integration/CentralAuthHooksTest.php | 4 ++--
.../Services/GlobalBlockLocalStatusManagerTest.php | 4 ++--
.../Services/GlobalBlockingLinkBuilderTest.php | 8 ++++----
4 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/composer.json b/composer.json
index 568d02c..3f34c26 100644
--- a/composer.json
+++ b/composer.json
@@ -1,6 +1,6 @@
{
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "45.0.0",
+ "mediawiki/mediawiki-codesniffer": "46.0.0",
"mediawiki/mediawiki-phan-config": "0.15.1",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
diff --git a/tests/phpunit/Integration/CentralAuthHooksTest.php b/tests/phpunit/Integration/CentralAuthHooksTest.php
index 98c42ac..d008e43 100644
--- a/tests/phpunit/Integration/CentralAuthHooksTest.php
+++ b/tests/phpunit/Integration/CentralAuthHooksTest.php
@@ -81,8 +81,8 @@ class CentralAuthHooksTest extends MediaWikiIntegrationTestCase {
public static function provideOnCentralAuthInfoFields() {
return [
- 'Special:CentralAuth for unblocked user' => [ fn () => self::$testUnblockedUser, false ],
- 'Special:CentralAuth for globally blocked user' => [ fn () => self::$testGloballyBlockedUser, true ],
+ 'Special:CentralAuth for unblocked user' => [ static fn () => self::$testUnblockedUser, false ],
+ 'Special:CentralAuth for globally blocked user' => [ static fn () => self::$testGloballyBlockedUser, true ],
];
}
diff --git a/tests/phpunit/Integration/Services/GlobalBlockLocalStatusManagerTest.php b/tests/phpunit/Integration/Services/GlobalBlockLocalStatusManagerTest.php
index 90d5246..4c71aad 100644
--- a/tests/phpunit/Integration/Services/GlobalBlockLocalStatusManagerTest.php
+++ b/tests/phpunit/Integration/Services/GlobalBlockLocalStatusManagerTest.php
@@ -29,10 +29,10 @@ class GlobalBlockLocalStatusManagerTest extends MediaWikiIntegrationTestCase {
public static function provideValidTargets() {
return [
'Target specified via IP address' => [
- fn () => '127.0.0.1', fn () => static::$globalBlockId,
+ static fn () => '127.0.0.1', static fn () => static::$globalBlockId,
],
'Target specified via global block ID' => [
- fn () => '#' . static::$globalBlockId, fn () => static::$globalBlockId,
+ static fn () => '#' . static::$globalBlockId, static fn () => static::$globalBlockId,
],
];
}
diff --git a/tests/phpunit/Integration/Services/GlobalBlockingLinkBuilderTest.php b/tests/phpunit/Integration/Services/GlobalBlockingLinkBuilderTest.php
index 031447c..46e13cc 100644
--- a/tests/phpunit/Integration/Services/GlobalBlockingLinkBuilderTest.php
+++ b/tests/phpunit/Integration/Services/GlobalBlockingLinkBuilderTest.php
@@ -249,13 +249,13 @@ class GlobalBlockingLinkBuilderTest extends MediaWikiIntegrationTestCase {
public static function provideGetActionLinks() {
return [
- 'User is not blocked' => [ fn () => self::$testUnblockedUser->getName(), true, false ],
+ 'User is not blocked' => [ static fn () => self::$testUnblockedUser->getName(), true, false ],
'User is not blocked, but set to not check block status' => [
- fn () => self::$testUnblockedUser->getName(), false, true,
+ static fn () => self::$testUnblockedUser->getName(), false, true,
],
- 'User is blocked' => [ fn () => self::$testGloballyBlockedUser->getName(), true, true ],
+ 'User is blocked' => [ static fn () => self::$testGloballyBlockedUser->getName(), true, true ],
'User is blocked, target is global block ID' => [
- fn () => '#' . self::$testGloballyBlockedUserGlobalBlockId, true, true,
+ static fn () => '#' . self::$testGloballyBlockedUserGlobalBlockId, true, true,
]
];
}
--
2.39.2
$ date
--- stdout ---
Sat Feb 1 01:31:16 UTC 2025
--- end ---
$ git clone file:///srv/git/mediawiki-extensions-GlobalBlocking.git repo --depth=1 -b master
--- stderr ---
Cloning into 'repo'...
--- stdout ---
--- end ---
$ git config user.name libraryupgrader
--- stdout ---
--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---
--- end ---
$ git submodule update --init
--- stdout ---
--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.
--- end ---
$ git show-ref refs/heads/master
--- stdout ---
ed2e77ef9b11c828b902d322a3515034014be2e9 refs/heads/master
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 418,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 418
}
}
}
--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 38 installs, 0 updates, 0 removals
- Locking composer/pcre (3.3.2)
- Locking composer/semver (3.4.3)
- Locking composer/spdx-licenses (1.5.8)
- Locking composer/xdebug-handler (3.0.5)
- Locking dealerdirect/phpcodesniffer-composer-installer (v1.0.0)
- Locking doctrine/deprecations (1.1.4)
- Locking felixfbecker/advanced-json-rpc (v3.2.1)
- Locking mediawiki/mediawiki-codesniffer (v45.0.0)
- Locking mediawiki/mediawiki-phan-config (0.15.1)
- Locking mediawiki/minus-x (1.1.3)
- Locking mediawiki/phan-taint-check-plugin (6.1.0)
- Locking microsoft/tolerant-php-parser (v0.1.2)
- Locking netresearch/jsonmapper (v4.5.0)
- Locking phan/phan (5.4.5)
- Locking php-parallel-lint/php-console-color (v1.0.1)
- Locking php-parallel-lint/php-console-highlighter (v1.0.0)
- Locking php-parallel-lint/php-parallel-lint (v1.4.0)
- Locking phpcsstandards/phpcsextra (1.2.1)
- Locking phpcsstandards/phpcsutils (1.0.12)
- Locking phpdocumentor/reflection-common (2.2.0)
- Locking phpdocumentor/reflection-docblock (5.6.1)
- Locking phpdocumentor/type-resolver (1.10.0)
- Locking phpstan/phpdoc-parser (2.0.0)
- Locking psr/container (2.0.2)
- Locking psr/log (3.0.2)
- Locking sabre/event (5.1.7)
- Locking squizlabs/php_codesniffer (3.10.3)
- Locking symfony/console (v7.2.1)
- Locking symfony/deprecation-contracts (v3.5.1)
- Locking symfony/polyfill-ctype (v1.31.0)
- Locking symfony/polyfill-intl-grapheme (v1.31.0)
- Locking symfony/polyfill-intl-normalizer (v1.31.0)
- Locking symfony/polyfill-mbstring (v1.31.0)
- Locking symfony/polyfill-php80 (v1.31.0)
- Locking symfony/service-contracts (v3.5.1)
- Locking symfony/string (v7.2.0)
- Locking tysonandre/var_representation_polyfill (0.1.3)
- Locking webmozart/assert (1.11.0)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 38 installs, 0 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Installing squizlabs/php_codesniffer (3.10.3): Extracting archive
- Installing dealerdirect/phpcodesniffer-composer-installer (v1.0.0): Extracting archive
- Installing composer/pcre (3.3.2): Extracting archive
- Installing symfony/polyfill-php80 (v1.31.0): Extracting archive
- Installing phpcsstandards/phpcsutils (1.0.12): Extracting archive
- Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive
- Installing symfony/polyfill-mbstring (v1.31.0): Extracting archive
- Installing composer/spdx-licenses (1.5.8): Extracting archive
- Installing composer/semver (3.4.3): Extracting archive
- Installing mediawiki/mediawiki-codesniffer (v45.0.0): Extracting archive
- Installing tysonandre/var_representation_polyfill (0.1.3): Extracting archive
- Installing symfony/polyfill-intl-normalizer (v1.31.0): Extracting archive
- Installing symfony/polyfill-intl-grapheme (v1.31.0): Extracting archive
- Installing symfony/polyfill-ctype (v1.31.0): Extracting archive
- Installing symfony/string (v7.2.0): Extracting archive
- Installing symfony/deprecation-contracts (v3.5.1): Extracting archive
- Installing psr/container (2.0.2): Extracting archive
- Installing symfony/service-contracts (v3.5.1): Extracting archive
- Installing symfony/console (v7.2.1): Extracting archive
- Installing sabre/event (5.1.7): Extracting archive
- Installing netresearch/jsonmapper (v4.5.0): Extracting archive
- Installing microsoft/tolerant-php-parser (v0.1.2): Extracting archive
- Installing webmozart/assert (1.11.0): Extracting archive
- Installing phpstan/phpdoc-parser (2.0.0): Extracting archive
- Installing phpdocumentor/reflection-common (2.2.0): Extracting archive
- Installing doctrine/deprecations (1.1.4): Extracting archive
- Installing phpdocumentor/type-resolver (1.10.0): Extracting archive
- Installing phpdocumentor/reflection-docblock (5.6.1): Extracting archive
- Installing felixfbecker/advanced-json-rpc (v3.2.1): Extracting archive
- Installing psr/log (3.0.2): Extracting archive
- Installing composer/xdebug-handler (3.0.5): Extracting archive
- Installing phan/phan (5.4.5): Extracting archive
- Installing mediawiki/phan-taint-check-plugin (6.1.0): Extracting archive
- Installing mediawiki/mediawiki-phan-config (0.15.1): Extracting archive
- Installing mediawiki/minus-x (1.1.3): Extracting archive
- Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
- Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
- Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive
0/36 [>---------------------------] 0%
20/36 [===============>------------] 55%
34/36 [==========================>-] 94%
36/36 [============================] 100%
1 package suggestions were added by new dependencies, use `composer suggest` to see details.
Generating autoload files
16 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Upgrading c:mediawiki/mediawiki-codesniffer from 45.0.0 -> 46.0.0
$ /usr/bin/composer update
--- stderr ---
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 2 updates, 0 removals
- Upgrading mediawiki/mediawiki-codesniffer (v45.0.0 => v46.0.0)
- Upgrading squizlabs/php_codesniffer (3.10.3 => 3.11.3)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 2 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Upgrading squizlabs/php_codesniffer (3.10.3 => 3.11.3): Extracting archive
- Upgrading mediawiki/mediawiki-codesniffer (v45.0.0 => v46.0.0): Extracting archive
0/2 [>---------------------------] 0%
1/2 [==============>-------------] 50%
2/2 [============================] 100%
Generating autoload files
16 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":0,"warnings":10,"fixable":10},"files":{"\/src\/repo\/tests\/phpunit\/unit\/Hooks\/HookRunnerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Services\/GlobalBlockingConnectionProvider.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Widget\/HTMLUserTextFieldAllowingGlobalBlockIds.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/UserMergeHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/Widget\/HTMLUserTextFieldAllowingGlobalBlockIdsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/HookRunner.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/GlobalBlockingGetRetroactiveAutoblockIPsHook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/Services\/GlobalBlockingGlobalBlockDetailsRendererTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Services\/GlobalBlockingUserVisibilityLookup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/Services\/GlobalBlockingConnectionProviderTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/UpdateAutoBlockParentIdColumn.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/GlobalBlockingSchemaHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/Services\/GlobalBlockingGlobalAutoblockExemptionListProviderTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Widget\/HTMLUserTextFieldAllowingGlobalBlockIdsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/Special\/SpecialGlobalBlockStatusTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Services\/GlobalBlockingGlobalBlockDetailsRendererTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Services\/GlobalBlockingBlockPurger.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Services\/GlobalBlockLocalStatusLookup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/GlobalBlock.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/maintenance\/FixGlobalBlockWhitelistTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Services\/GlobalBlockingGlobalBlockDetailsRenderer.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/fixGlobalBlockWhitelist.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/GlobalBlockingHooksModifiesDatabaseTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/GlobalBlockingServiceWiringTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Services\/GlobalBlockingGlobalAutoblockExemptionListProvider.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Special\/SpecialGlobalBlockStatus.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Services\/GlobalBlockingUserVisibilityLookupTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/GlobalBlockingServicesTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/GlobalBlockingServices.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Api\/ApiGlobalBlock.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/GlobalBlockingGlobalBlockAuditHook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Services\/GlobalBlockingLinkBuilder.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Services\/GlobalBlockReasonFormatter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Services\/GlobalBlockingExpirySelectorBuilder.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/GlobalBlockingHooksTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/CentralAuthHooksTest.php":{"errors":0,"warnings":2,"messages":[{"message":"Use static closure","source":"MediaWiki.Usage.StaticClosure.StaticClosure","severity":5,"fixable":true,"type":"WARNING","line":84,"column":59},{"message":"Use static closure","source":"MediaWiki.Usage.StaticClosure.StaticClosure","severity":5,"fixable":true,"type":"WARNING","line":85,"column":66}]},"\/src\/repo\/tests\/phpunit\/Integration\/Special\/SpecialRemoveGlobalBlockTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Services\/GlobalBlockLocalStatusManager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Special\/SpecialGlobalBlockList.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Services\/GlobalBlockLocalStatusLookupTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Special\/SpecialRemoveGlobalBlock.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Services\/GlobalBlockingGlobalAutoblockExemptionListProviderTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Api\/ApiQueryGlobalBlocks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Services\/GlobalBlockingExpirySelectorBuilderTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/GlobalBlocking.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/GlobalBlockingHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Special\/SpecialGlobalBlock.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/GlobalBlockLogFormatter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Services\/GlobalBlockReasonFormatterTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/GlobalBlockTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Special\/GlobalBlockListPager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/CentralAuthHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/GlobalBlockLogFormatterTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Special\/SpecialGlobalBlockListTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Special\/GlobalBlockListPagerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ServiceWiring.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Services\/GlobalBlockingLinkBuilderTest.php":{"errors":0,"warnings":4,"messages":[{"message":"Use static closure","source":"MediaWiki.Usage.StaticClosure.StaticClosure","severity":5,"fixable":true,"type":"WARNING","line":252,"column":40},{"message":"Use static closure","source":"MediaWiki.Usage.StaticClosure.StaticClosure","severity":5,"fixable":true,"type":"WARNING","line":254,"column":17},{"message":"Use static closure","source":"MediaWiki.Usage.StaticClosure.StaticClosure","severity":5,"fixable":true,"type":"WARNING","line":256,"column":36},{"message":"Use static closure","source":"MediaWiki.Usage.StaticClosure.StaticClosure","severity":5,"fixable":true,"type":"WARNING","line":258,"column":17}]},"\/src\/repo\/tests\/phpunit\/Integration\/Api\/ApiQueryGlobalBlocksTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/maintenance\/UpdateAutoBlockParentIdColumnTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Services\/GlobalBlockManager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Services\/GlobalBlockLookup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Services\/GlobalBlockingBlockPurgerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Special\/SpecialGlobalBlockStatusTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Special\/SpecialMassGlobalBlockTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Services\/GlobalBlockLookupTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/GlobalBlockingHooksTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Special\/SpecialMassGlobalBlock.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Api\/ApiGlobalBlockTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Special\/SpecialGlobalBlockTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Services\/GlobalBlockLocalStatusManagerTest.php":{"errors":0,"warnings":4,"messages":[{"message":"Use static closure","source":"MediaWiki.Usage.StaticClosure.StaticClosure","severity":5,"fixable":true,"type":"WARNING","line":32,"column":17},{"message":"Use static closure","source":"MediaWiki.Usage.StaticClosure.StaticClosure","severity":5,"fixable":true,"type":"WARNING","line":32,"column":39},{"message":"Use static closure","source":"MediaWiki.Usage.StaticClosure.StaticClosure","severity":5,"fixable":true,"type":"WARNING","line":35,"column":17},{"message":"Use static closure","source":"MediaWiki.Usage.StaticClosure.StaticClosure","severity":5,"fixable":true,"type":"WARNING","line":35,"column":56}]},"\/src\/repo\/tests\/phpunit\/Integration\/Services\/GlobalBlockManagerTest.php":{"errors":0,"warnings":0,"messages":[]}}}
--- end ---
PHPCS run failed
$ vendor/bin/phpcbf
--- stdout ---
PHPCBF RESULT SUMMARY
--------------------------------------------------------------------------------
FILE FIXED REMAINING
--------------------------------------------------------------------------------
/src/repo/tests/phpunit/Integration/CentralAuthHooksTest.php 2 0
...unit/Integration/Services/GlobalBlockingLinkBuilderTest.php 4 0
.../Integration/Services/GlobalBlockLocalStatusManagerTest.php 4 0
--------------------------------------------------------------------------------
A TOTAL OF 10 ERRORS WERE FIXED IN 3 FILES
--------------------------------------------------------------------------------
Time: 1.62 secs; Memory: 8MB
--- end ---
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":0,"warnings":0,"fixable":0},"files":{"\/src\/repo\/includes\/UserMergeHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/Hooks\/HookRunnerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Widget\/HTMLUserTextFieldAllowingGlobalBlockIds.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/HookRunner.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Services\/GlobalBlockingConnectionProvider.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/GlobalBlockingGetRetroactiveAutoblockIPsHook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/Widget\/HTMLUserTextFieldAllowingGlobalBlockIdsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/Services\/GlobalBlockingGlobalBlockDetailsRendererTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Services\/GlobalBlockingUserVisibilityLookup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/Services\/GlobalBlockingConnectionProviderTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/GlobalBlockingSchemaHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/Services\/GlobalBlockingGlobalAutoblockExemptionListProviderTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/UpdateAutoBlockParentIdColumn.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/Special\/SpecialGlobalBlockStatusTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Widget\/HTMLUserTextFieldAllowingGlobalBlockIdsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Services\/GlobalBlockingGlobalBlockDetailsRendererTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Services\/GlobalBlockLocalStatusLookup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/GlobalBlock.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Services\/GlobalBlockingBlockPurger.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/maintenance\/FixGlobalBlockWhitelistTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Services\/GlobalBlockingUserVisibilityLookupTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/GlobalBlockingServiceWiringTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Services\/GlobalBlockingGlobalBlockDetailsRenderer.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/fixGlobalBlockWhitelist.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Services\/GlobalBlockingGlobalAutoblockExemptionListProvider.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/GlobalBlockingServicesTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Api\/ApiGlobalBlock.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/GlobalBlockingGlobalBlockAuditHook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/GlobalBlockingHooksModifiesDatabaseTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Special\/SpecialGlobalBlockStatus.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Special\/SpecialGlobalBlockList.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/GlobalBlockingServices.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Special\/SpecialRemoveGlobalBlockTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/GlobalBlockingHooksTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Services\/GlobalBlockReasonFormatter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Services\/GlobalBlockLocalStatusLookupTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Services\/GlobalBlockingLinkBuilder.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Services\/GlobalBlockingExpirySelectorBuilder.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Api\/ApiQueryGlobalBlocks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Services\/GlobalBlockingGlobalAutoblockExemptionListProviderTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Services\/GlobalBlockingExpirySelectorBuilderTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Services\/GlobalBlockReasonFormatterTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/CentralAuthHooksTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/GlobalBlockLogFormatter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Special\/SpecialRemoveGlobalBlock.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Services\/GlobalBlockLocalStatusManager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Special\/GlobalBlockListPager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/GlobalBlocking.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/GlobalBlockTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Special\/SpecialGlobalBlock.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/CentralAuthHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Special\/GlobalBlockListPagerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Special\/SpecialGlobalBlockListTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/GlobalBlockingHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Api\/ApiQueryGlobalBlocksTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/GlobalBlockLogFormatterTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Services\/GlobalBlockManager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Services\/GlobalBlockingLinkBuilderTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Services\/GlobalBlockingBlockPurgerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Special\/SpecialGlobalBlockStatusTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ServiceWiring.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/maintenance\/UpdateAutoBlockParentIdColumnTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Services\/GlobalBlockLookup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Special\/SpecialMassGlobalBlockTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Api\/ApiGlobalBlockTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/GlobalBlockingHooksTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Services\/GlobalBlockLookupTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Special\/SpecialMassGlobalBlock.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Services\/GlobalBlockLocalStatusManagerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Special\/SpecialGlobalBlockTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Integration\/Services\/GlobalBlockManagerTest.php":{"errors":0,"warnings":0,"messages":[]}}}
--- end ---
$ git checkout .phpcs.xml
--- stderr ---
Updated 0 paths from the index
--- stdout ---
--- end ---
$ /usr/bin/composer install
--- stderr ---
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating autoload files
16 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
--- end ---
$ /usr/bin/composer test
--- stderr ---
> parallel-lint . --exclude vendor --exclude node_modules
> phpcs -sp --cache
> minus-x check .
--- stdout ---
PHP 8.2.20 | 10 parallel jobs
............................................................ 60/72 ( 83%)
............ 72/72 (100%)
Checked 72 files in 0.4 seconds
No syntax error found
.................................... 36 / 36 (100%)
Time: 275ms; Memory: 10MB
MinusX
======
Processing /src/repo...
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
....................................................
All good!
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 418,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 418
}
}
}
--- end ---
$ package-lock-lint package-lock.json
--- stdout ---
Checking package-lock.json
--- end ---
build: Updating mediawiki/mediawiki-codesniffer to 46.0.0
$ git add .
--- stdout ---
--- end ---
$ git commit -F /tmp/tmpz97a8z0u
--- stdout ---
[master 0836218] build: Updating mediawiki/mediawiki-codesniffer to 46.0.0
4 files changed, 9 insertions(+), 9 deletions(-)
--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From 0836218537fd0384e61f2a7c58d6553e6abda322 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Sat, 1 Feb 2025 01:31:30 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 46.0.0
Change-Id: Iea139101c2756b1a456aa3e865076426a06f25e2
---
composer.json | 2 +-
tests/phpunit/Integration/CentralAuthHooksTest.php | 4 ++--
.../Services/GlobalBlockLocalStatusManagerTest.php | 4 ++--
.../Services/GlobalBlockingLinkBuilderTest.php | 8 ++++----
4 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/composer.json b/composer.json
index 568d02c..3f34c26 100644
--- a/composer.json
+++ b/composer.json
@@ -1,6 +1,6 @@
{
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "45.0.0",
+ "mediawiki/mediawiki-codesniffer": "46.0.0",
"mediawiki/mediawiki-phan-config": "0.15.1",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
diff --git a/tests/phpunit/Integration/CentralAuthHooksTest.php b/tests/phpunit/Integration/CentralAuthHooksTest.php
index 98c42ac..d008e43 100644
--- a/tests/phpunit/Integration/CentralAuthHooksTest.php
+++ b/tests/phpunit/Integration/CentralAuthHooksTest.php
@@ -81,8 +81,8 @@ class CentralAuthHooksTest extends MediaWikiIntegrationTestCase {
public static function provideOnCentralAuthInfoFields() {
return [
- 'Special:CentralAuth for unblocked user' => [ fn () => self::$testUnblockedUser, false ],
- 'Special:CentralAuth for globally blocked user' => [ fn () => self::$testGloballyBlockedUser, true ],
+ 'Special:CentralAuth for unblocked user' => [ static fn () => self::$testUnblockedUser, false ],
+ 'Special:CentralAuth for globally blocked user' => [ static fn () => self::$testGloballyBlockedUser, true ],
];
}
diff --git a/tests/phpunit/Integration/Services/GlobalBlockLocalStatusManagerTest.php b/tests/phpunit/Integration/Services/GlobalBlockLocalStatusManagerTest.php
index 90d5246..4c71aad 100644
--- a/tests/phpunit/Integration/Services/GlobalBlockLocalStatusManagerTest.php
+++ b/tests/phpunit/Integration/Services/GlobalBlockLocalStatusManagerTest.php
@@ -29,10 +29,10 @@ class GlobalBlockLocalStatusManagerTest extends MediaWikiIntegrationTestCase {
public static function provideValidTargets() {
return [
'Target specified via IP address' => [
- fn () => '127.0.0.1', fn () => static::$globalBlockId,
+ static fn () => '127.0.0.1', static fn () => static::$globalBlockId,
],
'Target specified via global block ID' => [
- fn () => '#' . static::$globalBlockId, fn () => static::$globalBlockId,
+ static fn () => '#' . static::$globalBlockId, static fn () => static::$globalBlockId,
],
];
}
diff --git a/tests/phpunit/Integration/Services/GlobalBlockingLinkBuilderTest.php b/tests/phpunit/Integration/Services/GlobalBlockingLinkBuilderTest.php
index 031447c..46e13cc 100644
--- a/tests/phpunit/Integration/Services/GlobalBlockingLinkBuilderTest.php
+++ b/tests/phpunit/Integration/Services/GlobalBlockingLinkBuilderTest.php
@@ -249,13 +249,13 @@ class GlobalBlockingLinkBuilderTest extends MediaWikiIntegrationTestCase {
public static function provideGetActionLinks() {
return [
- 'User is not blocked' => [ fn () => self::$testUnblockedUser->getName(), true, false ],
+ 'User is not blocked' => [ static fn () => self::$testUnblockedUser->getName(), true, false ],
'User is not blocked, but set to not check block status' => [
- fn () => self::$testUnblockedUser->getName(), false, true,
+ static fn () => self::$testUnblockedUser->getName(), false, true,
],
- 'User is blocked' => [ fn () => self::$testGloballyBlockedUser->getName(), true, true ],
+ 'User is blocked' => [ static fn () => self::$testGloballyBlockedUser->getName(), true, true ],
'User is blocked, target is global block ID' => [
- fn () => '#' . self::$testGloballyBlockedUserGlobalBlockId, true, true,
+ static fn () => '#' . self::$testGloballyBlockedUserGlobalBlockId, true, true,
]
];
}
--
2.39.2
--- end ---