This run took 20 seconds.
From e39aa98c5db3c43448bf6e754f82c4a412c00594 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Sat, 1 Feb 2025 01:27:08 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 46.0.0
Change-Id: I91716d9547307aa9c261807c2f49b5ec3780e34b
---
composer.json | 2 +-
.../integration/ApiQueryOldreviewedpagesTest.php | 12 ++++++------
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/composer.json b/composer.json
index 2c5b395..643c4b8 100644
--- a/composer.json
+++ b/composer.json
@@ -1,6 +1,6 @@
{
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "45.0.0",
+ "mediawiki/mediawiki-codesniffer": "46.0.0",
"mediawiki/mediawiki-phan-config": "0.15.1",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
diff --git a/tests/phpunit/integration/ApiQueryOldreviewedpagesTest.php b/tests/phpunit/integration/ApiQueryOldreviewedpagesTest.php
index 0e38f17..bbf0baf 100644
--- a/tests/phpunit/integration/ApiQueryOldreviewedpagesTest.php
+++ b/tests/phpunit/integration/ApiQueryOldreviewedpagesTest.php
@@ -155,7 +155,7 @@ class ApiQueryOldreviewedpagesTest extends ApiTestCase {
'orfilterwatched' => 'watched'
], null, false, $userProvider->call( $this ) );
- $pageIds = array_map( fn ( array $page ) => $page['pageid'], $res['query']['oldreviewedpages'] );
+ $pageIds = array_map( static fn ( array $page ) => $page['pageid'], $res['query']['oldreviewedpages'] );
sort( $pageIds );
$this->assertSame(
@@ -167,11 +167,11 @@ class ApiQueryOldreviewedpagesTest extends ApiTestCase {
public static function provideUsersWithWatchlistAccess(): iterable {
// phpcs:disable Squiz.Scope.StaticThisUsage.Found
yield 'named user' => [
- fn () => self::$user,
+ static fn () => self::$user,
];
yield 'temporary account' => [
- fn () => self::$tempUser,
+ static fn () => self::$tempUser,
];
// phpcs:enable
}
@@ -185,7 +185,7 @@ class ApiQueryOldreviewedpagesTest extends ApiTestCase {
'list' => 'oldreviewedpages',
], null, false, $userProvider->call( $this ) );
- $pageIds = array_map( fn ( array $page ) => $page['pageid'], $res['query']['oldreviewedpages'] );
+ $pageIds = array_map( static fn ( array $page ) => $page['pageid'], $res['query']['oldreviewedpages'] );
sort( $pageIds );
$this->assertSame(
@@ -197,7 +197,7 @@ class ApiQueryOldreviewedpagesTest extends ApiTestCase {
public static function provideUsers(): iterable {
// phpcs:disable Squiz.Scope.StaticThisUsage.Found
yield 'named user' => [
- fn () => self::$user,
+ static fn () => self::$user,
];
yield 'IP user' => [
@@ -205,7 +205,7 @@ class ApiQueryOldreviewedpagesTest extends ApiTestCase {
];
yield 'temporary account' => [
- fn () => self::$tempUser,
+ static fn () => self::$tempUser,
];
// phpcs:enable
}
--
2.39.2
$ date
--- stdout ---
Sat Feb 1 01:26:51 UTC 2025
--- end ---
$ git clone file:///srv/git/mediawiki-extensions-FlaggedRevs.git repo --depth=1 -b master
--- stderr ---
Cloning into 'repo'...
--- stdout ---
--- end ---
$ git config user.name libraryupgrader
--- stdout ---
--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---
--- end ---
$ git submodule update --init
--- stdout ---
--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.
--- end ---
$ git show-ref refs/heads/master
--- stdout ---
5ca426323f60644784a4c996e499c05e53f3f625 refs/heads/master
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 440,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 440
}
}
}
--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 38 installs, 0 updates, 0 removals
- Locking composer/pcre (3.3.2)
- Locking composer/semver (3.4.3)
- Locking composer/spdx-licenses (1.5.8)
- Locking composer/xdebug-handler (3.0.5)
- Locking dealerdirect/phpcodesniffer-composer-installer (v1.0.0)
- Locking doctrine/deprecations (1.1.4)
- Locking felixfbecker/advanced-json-rpc (v3.2.1)
- Locking mediawiki/mediawiki-codesniffer (v45.0.0)
- Locking mediawiki/mediawiki-phan-config (0.15.1)
- Locking mediawiki/minus-x (1.1.3)
- Locking mediawiki/phan-taint-check-plugin (6.1.0)
- Locking microsoft/tolerant-php-parser (v0.1.2)
- Locking netresearch/jsonmapper (v4.5.0)
- Locking phan/phan (5.4.5)
- Locking php-parallel-lint/php-console-color (v1.0.1)
- Locking php-parallel-lint/php-console-highlighter (v1.0.0)
- Locking php-parallel-lint/php-parallel-lint (v1.4.0)
- Locking phpcsstandards/phpcsextra (1.2.1)
- Locking phpcsstandards/phpcsutils (1.0.12)
- Locking phpdocumentor/reflection-common (2.2.0)
- Locking phpdocumentor/reflection-docblock (5.6.1)
- Locking phpdocumentor/type-resolver (1.10.0)
- Locking phpstan/phpdoc-parser (2.0.0)
- Locking psr/container (2.0.2)
- Locking psr/log (3.0.2)
- Locking sabre/event (5.1.7)
- Locking squizlabs/php_codesniffer (3.10.3)
- Locking symfony/console (v7.2.1)
- Locking symfony/deprecation-contracts (v3.5.1)
- Locking symfony/polyfill-ctype (v1.31.0)
- Locking symfony/polyfill-intl-grapheme (v1.31.0)
- Locking symfony/polyfill-intl-normalizer (v1.31.0)
- Locking symfony/polyfill-mbstring (v1.31.0)
- Locking symfony/polyfill-php80 (v1.31.0)
- Locking symfony/service-contracts (v3.5.1)
- Locking symfony/string (v7.2.0)
- Locking tysonandre/var_representation_polyfill (0.1.3)
- Locking webmozart/assert (1.11.0)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 38 installs, 0 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Installing squizlabs/php_codesniffer (3.10.3): Extracting archive
- Installing dealerdirect/phpcodesniffer-composer-installer (v1.0.0): Extracting archive
- Installing composer/pcre (3.3.2): Extracting archive
- Installing symfony/polyfill-php80 (v1.31.0): Extracting archive
- Installing phpcsstandards/phpcsutils (1.0.12): Extracting archive
- Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive
- Installing symfony/polyfill-mbstring (v1.31.0): Extracting archive
- Installing composer/spdx-licenses (1.5.8): Extracting archive
- Installing composer/semver (3.4.3): Extracting archive
- Installing mediawiki/mediawiki-codesniffer (v45.0.0): Extracting archive
- Installing tysonandre/var_representation_polyfill (0.1.3): Extracting archive
- Installing symfony/polyfill-intl-normalizer (v1.31.0): Extracting archive
- Installing symfony/polyfill-intl-grapheme (v1.31.0): Extracting archive
- Installing symfony/polyfill-ctype (v1.31.0): Extracting archive
- Installing symfony/string (v7.2.0): Extracting archive
- Installing symfony/deprecation-contracts (v3.5.1): Extracting archive
- Installing psr/container (2.0.2): Extracting archive
- Installing symfony/service-contracts (v3.5.1): Extracting archive
- Installing symfony/console (v7.2.1): Extracting archive
- Installing sabre/event (5.1.7): Extracting archive
- Installing netresearch/jsonmapper (v4.5.0): Extracting archive
- Installing microsoft/tolerant-php-parser (v0.1.2): Extracting archive
- Installing webmozart/assert (1.11.0): Extracting archive
- Installing phpstan/phpdoc-parser (2.0.0): Extracting archive
- Installing phpdocumentor/reflection-common (2.2.0): Extracting archive
- Installing doctrine/deprecations (1.1.4): Extracting archive
- Installing phpdocumentor/type-resolver (1.10.0): Extracting archive
- Installing phpdocumentor/reflection-docblock (5.6.1): Extracting archive
- Installing felixfbecker/advanced-json-rpc (v3.2.1): Extracting archive
- Installing psr/log (3.0.2): Extracting archive
- Installing composer/xdebug-handler (3.0.5): Extracting archive
- Installing phan/phan (5.4.5): Extracting archive
- Installing mediawiki/phan-taint-check-plugin (6.1.0): Extracting archive
- Installing mediawiki/mediawiki-phan-config (0.15.1): Extracting archive
- Installing mediawiki/minus-x (1.1.3): Extracting archive
- Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
- Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
- Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive
0/36 [>---------------------------] 0%
20/36 [===============>------------] 55%
35/36 [===========================>] 97%
36/36 [============================] 100%
1 package suggestions were added by new dependencies, use `composer suggest` to see details.
Generating autoload files
16 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Upgrading c:mediawiki/mediawiki-codesniffer from 45.0.0 -> 46.0.0
$ /usr/bin/composer update
--- stderr ---
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 2 updates, 0 removals
- Upgrading mediawiki/mediawiki-codesniffer (v45.0.0 => v46.0.0)
- Upgrading squizlabs/php_codesniffer (3.10.3 => 3.11.3)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 2 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Upgrading squizlabs/php_codesniffer (3.10.3 => 3.11.3): Extracting archive
- Upgrading mediawiki/mediawiki-codesniffer (v45.0.0 => v46.0.0): Extracting archive
0/2 [>---------------------------] 0%
1/2 [==============>-------------] 50%
2/2 [============================] 100%
Generating autoload files
16 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":0,"warnings":6,"fixable":6},"files":{"\/src\/repo\/includes\/frontend\/language\/FlaggedRevs.i18n.magic.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/updateStats.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/updateQueryCache.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/api\/reports\/ApiFlagConfig.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/FlaggedRevsReviewLogFormatter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/api\/actions\/ApiStabilize.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/scribunto\/FlaggedRevsScribuntoLuaLibrary.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/hook\/FlaggedRevsRevisionReviewFormAfterDoSubmitHook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/hook\/FlaggedRevsStabilitySettingsChangedHook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/api\/FlaggedRevsApiHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/specialpages\/reports\/ConfiguredPagesPager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/FlaggedRevsStableLogFormatter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/purgeReviewablePages.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/updateAutoPromote.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/rest\/ReviewHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/api\/actions\/ApiStabilizeGeneral.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/rest\/DiffHeaderHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/specialpages\/reports\/StablePagesPager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FlaggedRevsParserCache.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/api\/actions\/ApiReview.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/flagToSemiProtect.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/ScribuntoHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FlaggedRevsMediaWikiServicesHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/FlaggedRevsSetup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/business\/FRGenericSubmitForm.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/specialpages\/reports\/StablePages.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/api\/reports\/ApiQueryConfiguredpages.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/api\/reports\/ApiQueryUnreviewedpages.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/FlaggedRevsHookRunnerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/structure\/FlaggedRevsSchemaTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/business\/PageStabilityProtectForm.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/structure\/BundleSizeTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/populateRevTimestamp.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/FlaggablePageTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/api\/actions\/ApiStabilizeProtect.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FRInclusionManager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FRExtraCacheUpdate.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/reviewAllPages.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/api\/reports\/ApiQueryFlagged.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/FlaggedRevsUIHooksTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/FlaggedRevsLibraryTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/api\/reports\/ApiQueryOldreviewedpages.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/updateTracking.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/schema\/FlaggedRevsUpdaterHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FRStableVersionUpdate.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/FRUserCountersTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/FlaggedRevsBackendTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/FlaggedRevsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/FlaggedRevisionTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/FRInclusionManagerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/specialpages\/reports\/PendingChangesPager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FRUserCounters.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/specialpages\/reports\/UnreviewedPagesPager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FRPageConfig.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FlaggedRevsLog.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/FlaggedRevsHTML.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/FlaggablePageViewTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FRDependencyUpdate.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/RevisionReviewFormUI.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FlaggedRevsContributionsHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/ServiceWiring.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/DiffHeaderHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/RevisionReviewFormTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/business\/PageStabilityForm.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/specialpages\/reports\/ConfiguredPages.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/PageStabilityFormTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/specialpages\/actions\/RevisionReview.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FRExtraCacheUpdateJob.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/business\/PageStabilityGeneralForm.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/FlaggedRevsStatsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/ApiQueryOldreviewedpagesTest.php":{"errors":0,"warnings":6,"messages":[{"message":"Use static closure","source":"MediaWiki.Usage.StaticClosure.StaticClosure","severity":5,"fixable":true,"type":"WARNING","line":158,"column":31},{"message":"Use static closure","source":"MediaWiki.Usage.StaticClosure.StaticClosure","severity":5,"fixable":true,"type":"WARNING","line":170,"column":13},{"message":"Use static closure","source":"MediaWiki.Usage.StaticClosure.StaticClosure","severity":5,"fixable":true,"type":"WARNING","line":174,"column":13},{"message":"Use static closure","source":"MediaWiki.Usage.StaticClosure.StaticClosure","severity":5,"fixable":true,"type":"WARNING","line":188,"column":31},{"message":"Use static closure","source":"MediaWiki.Usage.StaticClosure.StaticClosure","severity":5,"fixable":true,"type":"WARNING","line":200,"column":13},{"message":"Use static closure","source":"MediaWiki.Usage.StaticClosure.StaticClosure","severity":5,"fixable":true,"type":"WARNING","line":208,"column":13}]},"\/src\/repo\/includes\/frontend\/specialpages\/reports\/UnreviewedPages.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/FlaggedRevsHooksTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/specialpages\/reports\/ValidationStatistics.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/ReviewHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/language\/FlaggedRevs.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/business\/RevisionReviewForm.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/ApiFlagConfigTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/RejectConfirmationFormUI.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FlaggableWikiPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FRUserActivity.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FlaggedRevision.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FlaggedRevsStats.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/specialpages\/actions\/Stabilization.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/specialpages\/reports\/PendingChanges.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FlaggedRevs.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/FlaggedRevsUIHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/hook\/FlaggedRevsHookRunner.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FlaggedRevsHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/FlaggablePageView.php":{"errors":0,"warnings":0,"messages":[]}}}
--- end ---
PHPCS run failed
$ vendor/bin/phpcbf
--- stdout ---
PHPCBF RESULT SUMMARY
--------------------------------------------------------------------------------
FILE FIXED REMAINING
--------------------------------------------------------------------------------
.../tests/phpunit/integration/ApiQueryOldreviewedpagesTest.php 6 0
--------------------------------------------------------------------------------
A TOTAL OF 6 ERRORS WERE FIXED IN 1 FILE
--------------------------------------------------------------------------------
Time: 2.05 secs; Memory: 8MB
--- end ---
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":0,"warnings":0,"fixable":0},"files":{"\/src\/repo\/maintenance\/updateStats.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/updateQueryCache.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/api\/reports\/ApiFlagConfig.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/language\/FlaggedRevs.i18n.magic.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/api\/actions\/ApiStabilize.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/scribunto\/FlaggedRevsScribuntoLuaLibrary.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/api\/FlaggedRevsApiHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/updateAutoPromote.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/FlaggedRevsReviewLogFormatter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/hook\/FlaggedRevsRevisionReviewFormAfterDoSubmitHook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/specialpages\/reports\/ConfiguredPagesPager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/purgeReviewablePages.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/hook\/FlaggedRevsStabilitySettingsChangedHook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/flagToSemiProtect.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/api\/actions\/ApiStabilizeGeneral.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/rest\/ReviewHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FlaggedRevsParserCache.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/specialpages\/reports\/StablePagesPager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/api\/actions\/ApiReview.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/api\/reports\/ApiQueryConfiguredpages.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/business\/FRGenericSubmitForm.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/ScribuntoHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FlaggedRevsMediaWikiServicesHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/FlaggedRevsStableLogFormatter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/api\/reports\/ApiQueryUnreviewedpages.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/FlaggedRevsSetup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/rest\/DiffHeaderHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/business\/PageStabilityProtectForm.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/FlaggedRevsHookRunnerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/populateRevTimestamp.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/structure\/FlaggedRevsSchemaTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FRExtraCacheUpdate.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/structure\/BundleSizeTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/specialpages\/reports\/StablePages.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/api\/actions\/ApiStabilizeProtect.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/api\/reports\/ApiQueryFlagged.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FRInclusionManager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/updateTracking.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/FlaggablePageTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/reviewAllPages.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/FlaggedRevsUIHooksTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/api\/reports\/ApiQueryOldreviewedpages.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/FRUserCountersTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/FlaggedRevsLibraryTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/schema\/FlaggedRevsUpdaterHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/FlaggedRevsBackendTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FRStableVersionUpdate.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/FlaggedRevisionTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FRDependencyUpdate.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/ServiceWiring.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/specialpages\/reports\/UnreviewedPagesPager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FRPageConfig.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/FRInclusionManagerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/business\/PageStabilityForm.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/FlaggedRevsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FlaggedRevsLog.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/DiffHeaderHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/FlaggablePageViewTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FRUserCounters.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FlaggedRevsContributionsHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/FlaggedRevsHTML.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/business\/PageStabilityGeneralForm.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/RevisionReviewFormTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/specialpages\/actions\/RevisionReview.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/RevisionReviewFormUI.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/PageStabilityFormTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/ApiQueryOldreviewedpagesTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/specialpages\/reports\/PendingChangesPager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FRExtraCacheUpdateJob.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/FlaggedRevsStatsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/specialpages\/reports\/UnreviewedPages.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/ReviewHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FlaggedRevision.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/FlaggedRevsHooksTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FlaggableWikiPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/ApiFlagConfigTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/specialpages\/reports\/ConfiguredPages.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/specialpages\/reports\/ValidationStatistics.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FRUserActivity.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/RejectConfirmationFormUI.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FlaggedRevsStats.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/language\/FlaggedRevs.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/business\/RevisionReviewForm.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/specialpages\/reports\/PendingChanges.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/specialpages\/actions\/Stabilization.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FlaggedRevs.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/FlaggedRevsUIHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/hook\/FlaggedRevsHookRunner.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/backend\/FlaggedRevsHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/frontend\/FlaggablePageView.php":{"errors":0,"warnings":0,"messages":[]}}}
--- end ---
$ git checkout .phpcs.xml
--- stderr ---
Updated 0 paths from the index
--- stdout ---
--- end ---
$ /usr/bin/composer install
--- stderr ---
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating autoload files
16 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
--- end ---
$ /usr/bin/composer test
--- stderr ---
> parallel-lint . --exclude vendor --exclude node_modules
> phpcs -sp --cache
> minus-x check .
--- stdout ---
PHP 8.2.20 | 10 parallel jobs
............................................................ 60/91 ( 65%)
............................... 91/91 (100%)
Checked 91 files in 0.5 seconds
No syntax error found
.............................................. 46 / 46 (100%)
Time: 360ms; Memory: 12MB
MinusX
======
Processing /src/repo...
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.....................
All good!
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 440,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 440
}
}
}
--- end ---
$ package-lock-lint package-lock.json
--- stdout ---
Checking package-lock.json
--- end ---
build: Updating mediawiki/mediawiki-codesniffer to 46.0.0
$ git add .
--- stdout ---
--- end ---
$ git commit -F /tmp/tmpkvudlmes
--- stdout ---
[master e39aa98] build: Updating mediawiki/mediawiki-codesniffer to 46.0.0
2 files changed, 7 insertions(+), 7 deletions(-)
--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From e39aa98c5db3c43448bf6e754f82c4a412c00594 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Sat, 1 Feb 2025 01:27:08 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 46.0.0
Change-Id: I91716d9547307aa9c261807c2f49b5ec3780e34b
---
composer.json | 2 +-
.../integration/ApiQueryOldreviewedpagesTest.php | 12 ++++++------
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/composer.json b/composer.json
index 2c5b395..643c4b8 100644
--- a/composer.json
+++ b/composer.json
@@ -1,6 +1,6 @@
{
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "45.0.0",
+ "mediawiki/mediawiki-codesniffer": "46.0.0",
"mediawiki/mediawiki-phan-config": "0.15.1",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
diff --git a/tests/phpunit/integration/ApiQueryOldreviewedpagesTest.php b/tests/phpunit/integration/ApiQueryOldreviewedpagesTest.php
index 0e38f17..bbf0baf 100644
--- a/tests/phpunit/integration/ApiQueryOldreviewedpagesTest.php
+++ b/tests/phpunit/integration/ApiQueryOldreviewedpagesTest.php
@@ -155,7 +155,7 @@ class ApiQueryOldreviewedpagesTest extends ApiTestCase {
'orfilterwatched' => 'watched'
], null, false, $userProvider->call( $this ) );
- $pageIds = array_map( fn ( array $page ) => $page['pageid'], $res['query']['oldreviewedpages'] );
+ $pageIds = array_map( static fn ( array $page ) => $page['pageid'], $res['query']['oldreviewedpages'] );
sort( $pageIds );
$this->assertSame(
@@ -167,11 +167,11 @@ class ApiQueryOldreviewedpagesTest extends ApiTestCase {
public static function provideUsersWithWatchlistAccess(): iterable {
// phpcs:disable Squiz.Scope.StaticThisUsage.Found
yield 'named user' => [
- fn () => self::$user,
+ static fn () => self::$user,
];
yield 'temporary account' => [
- fn () => self::$tempUser,
+ static fn () => self::$tempUser,
];
// phpcs:enable
}
@@ -185,7 +185,7 @@ class ApiQueryOldreviewedpagesTest extends ApiTestCase {
'list' => 'oldreviewedpages',
], null, false, $userProvider->call( $this ) );
- $pageIds = array_map( fn ( array $page ) => $page['pageid'], $res['query']['oldreviewedpages'] );
+ $pageIds = array_map( static fn ( array $page ) => $page['pageid'], $res['query']['oldreviewedpages'] );
sort( $pageIds );
$this->assertSame(
@@ -197,7 +197,7 @@ class ApiQueryOldreviewedpagesTest extends ApiTestCase {
public static function provideUsers(): iterable {
// phpcs:disable Squiz.Scope.StaticThisUsage.Found
yield 'named user' => [
- fn () => self::$user,
+ static fn () => self::$user,
];
yield 'IP user' => [
@@ -205,7 +205,7 @@ class ApiQueryOldreviewedpagesTest extends ApiTestCase {
];
yield 'temporary account' => [
- fn () => self::$tempUser,
+ static fn () => self::$tempUser,
];
// phpcs:enable
}
--
2.39.2
--- end ---