This run took 13 seconds.
From 1fe35408e9065c77586f55f5cdebd508e9e6c3dd Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Thu, 14 Nov 2024 09:33:40 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
Change-Id: I5cf88b7a5906a852da217f4316ec8dee2a5ccf81
---
composer.json | 2 +-
includes/PagePropertiesHooks.php | 2 +-
includes/specials/SpecialPageProperties.php | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/composer.json b/composer.json
index b3f8e51..3be6644 100644
--- a/composer.json
+++ b/composer.json
@@ -1,6 +1,6 @@
{
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "44.0.0",
+ "mediawiki/mediawiki-codesniffer": "45.0.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
"php-parallel-lint/php-parallel-lint": "1.4.0"
diff --git a/includes/PagePropertiesHooks.php b/includes/PagePropertiesHooks.php
index 43bb512..0de2c0c 100644
--- a/includes/PagePropertiesHooks.php
+++ b/includes/PagePropertiesHooks.php
@@ -116,7 +116,7 @@ class PagePropertiesHooks {
/**
* @param DatabaseUpdater|null $updater
*/
- public static function onLoadExtensionSchemaUpdates( DatabaseUpdater $updater = null ) {
+ public static function onLoadExtensionSchemaUpdates( ?DatabaseUpdater $updater = null ) {
$base = __DIR__;
$db = $updater->getDB();
$dbType = $db->getType();
diff --git a/includes/specials/SpecialPageProperties.php b/includes/specials/SpecialPageProperties.php
index 6e44377..64fdcdb 100644
--- a/includes/specials/SpecialPageProperties.php
+++ b/includes/specials/SpecialPageProperties.php
@@ -551,7 +551,7 @@ class SpecialPageProperties extends SpecialPage {
* @param Title|null $title
* @return array
*/
- private function getOptionsForTitle( Title $title = null ) {
+ private function getOptionsForTitle( ?Title $title = null ) {
$contentHandlerFactory = MediaWikiServices::getInstance()->getContentHandlerFactory();
$models = $contentHandlerFactory->getContentModels();
$options = [];
--
2.39.2
$ date
--- stdout ---
Thu Nov 14 09:33:30 UTC 2024
--- end ---
$ git clone file:///srv/git/mediawiki-extensions-PageProperties.git repo --depth=1 -b master
--- stderr ---
Cloning into 'repo'...
--- stdout ---
--- end ---
$ git config user.name libraryupgrader
--- stdout ---
--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---
--- end ---
$ git submodule update --init
--- stdout ---
--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.
--- end ---
$ git show-ref refs/heads/master
--- stdout ---
951f570515113c6205b13e5b77a80ee2ac21d89a refs/heads/master
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 418,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 418
}
}
}
--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 24 installs, 0 updates, 0 removals
- Locking composer/semver (3.4.2)
- Locking composer/spdx-licenses (1.5.8)
- Locking dealerdirect/phpcodesniffer-composer-installer (v1.0.0)
- Locking easyrdf/easyrdf (1.1.1)
- Locking mediawiki/mediawiki-codesniffer (v44.0.0)
- Locking mediawiki/minus-x (1.1.3)
- Locking ml/iri (1.1.4)
- Locking ml/json-ld (1.2.1)
- Locking php-parallel-lint/php-console-color (v1.0.1)
- Locking php-parallel-lint/php-console-highlighter (v1.0.0)
- Locking php-parallel-lint/php-parallel-lint (v1.4.0)
- Locking phpcsstandards/phpcsextra (1.2.1)
- Locking phpcsstandards/phpcsutils (1.0.11)
- Locking psr/container (2.0.2)
- Locking squizlabs/php_codesniffer (3.9.0)
- Locking symfony/console (v7.1.8)
- Locking symfony/deprecation-contracts (v3.5.0)
- Locking symfony/polyfill-ctype (v1.31.0)
- Locking symfony/polyfill-intl-grapheme (v1.31.0)
- Locking symfony/polyfill-intl-normalizer (v1.31.0)
- Locking symfony/polyfill-mbstring (v1.31.0)
- Locking symfony/polyfill-php80 (v1.31.0)
- Locking symfony/service-contracts (v3.5.0)
- Locking symfony/string (v7.1.8)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 24 installs, 0 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Installing squizlabs/php_codesniffer (3.9.0): Extracting archive
- Installing dealerdirect/phpcodesniffer-composer-installer (v1.0.0): Extracting archive
- Installing symfony/polyfill-mbstring (v1.31.0): Extracting archive
- Installing easyrdf/easyrdf (1.1.1): Extracting archive
- Installing symfony/polyfill-php80 (v1.31.0): Extracting archive
- Installing phpcsstandards/phpcsutils (1.0.11): Extracting archive
- Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive
- Installing composer/spdx-licenses (1.5.8): Extracting archive
- Installing composer/semver (3.4.2): Extracting archive
- Installing mediawiki/mediawiki-codesniffer (v44.0.0): Extracting archive
- Installing symfony/polyfill-intl-normalizer (v1.31.0): Extracting archive
- Installing symfony/polyfill-intl-grapheme (v1.31.0): Extracting archive
- Installing symfony/polyfill-ctype (v1.31.0): Extracting archive
- Installing symfony/string (v7.1.8): Extracting archive
- Installing symfony/deprecation-contracts (v3.5.0): Extracting archive
- Installing psr/container (2.0.2): Extracting archive
- Installing symfony/service-contracts (v3.5.0): Extracting archive
- Installing symfony/console (v7.1.8): Extracting archive
- Installing mediawiki/minus-x (1.1.3): Extracting archive
- Installing ml/iri (1.1.4): Extracting archive
- Installing ml/json-ld (1.2.1): Extracting archive
- Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
- Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
- Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive
0/22 [>---------------------------] 0%
22/22 [============================] 100%
1 package suggestions were added by new dependencies, use `composer suggest` to see details.
Generating autoload files
14 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Upgrading c:mediawiki/mediawiki-codesniffer from 44.0.0 -> 45.0.0
$ /usr/bin/composer update
--- stderr ---
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 4 updates, 0 removals
- Upgrading composer/semver (3.4.2 => 3.4.3)
- Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0)
- Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12)
- Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 4 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3): Extracting archive
- Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12): Extracting archive
- Upgrading composer/semver (3.4.2 => 3.4.3): Extracting archive
- Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0): Extracting archive
0/4 [>---------------------------] 0%
3/4 [=====================>------] 75%
4/4 [============================] 100%
Generating autoload files
14 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Previously failing phpcs rules: {'Squiz.Scope.MethodScope.Missing', 'Generic.Files.LineLength.TooLong', 'MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName', 'MediaWiki.Usage.SuperGlobalsUsage.SuperGlobals'}
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":6,"warnings":13,"fixable":2},"files":{"\/src\/repo\/PageProperties.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/content\/PagePropertiesJsonDataContent.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/api\/PagePropertiesApiCheckLatestVersion.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/content\/PagePropertiesJsonDataContentHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/specials\/OOUIHTMLFormTabs.php":{"errors":2,"warnings":0,"messages":[{"message":"Visibility must be declared on method \"getValidMethod\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":98,"column":5},{"message":"Visibility must be declared on method \"getBody\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":113,"column":5}]},"\/src\/repo\/maintenance\/migrateSlots.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/PagePropertiesHooks.php":{"errors":1,"warnings":5,"messages":[{"message":"Line exceeds 120 characters; contains 142 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":67,"column":142},{"message":"Line exceeds 120 characters; contains 134 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":81,"column":134},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?DatabaseUpdater $updater = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":119,"column":58},{"message":"Line exceeds 120 characters; contains 197 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":153,"column":197},{"message":"Line exceeds 120 characters; contains 161 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":240,"column":161},{"message":"Line exceeds 120 characters; contains 191 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":259,"column":191}]},"\/src\/repo\/includes\/PageProperties.php":{"errors":1,"warnings":5,"messages":[{"message":"Line exceeds 120 characters; contains 127 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":71,"column":127},{"message":"Line exceeds 120 characters; contains 190 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":243,"column":190},{"message":"Line exceeds 120 characters; contains 130 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":246,"column":130},{"message":"Line exceeds 120 characters; contains 143 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":303,"column":143},{"message":"Method name \"page_ancestors\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":379,"column":19},{"message":"Line exceeds 120 characters; contains 125 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":439,"column":13}]},"\/src\/repo\/includes\/specials\/SpecialPageProperties.php":{"errors":2,"warnings":3,"messages":[{"message":"\"$_POST\" superglobals should not be accessed.","source":"MediaWiki.Usage.SuperGlobalsUsage.SuperGlobals","severity":5,"fixable":false,"type":"ERROR","line":231,"column":61},{"message":"Line exceeds 120 characters; contains 121 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":276,"column":121},{"message":"Line exceeds 120 characters; contains 148 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":419,"column":148},{"message":"Line exceeds 120 characters; contains 154 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":440,"column":154},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?Title $title = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":554,"column":42}]}}}
--- end ---
PHPCS run failed
$ vendor/bin/phpcbf
--- stdout ---
PHPCBF RESULT SUMMARY
--------------------------------------------------------------------------
FILE FIXED REMAINING
--------------------------------------------------------------------------
/src/repo/includes/PagePropertiesHooks.php 1 5
/src/repo/includes/specials/SpecialPageProperties.php 1 4
--------------------------------------------------------------------------
A TOTAL OF 2 ERRORS WERE FIXED IN 2 FILES
--------------------------------------------------------------------------
Time: 709ms; Memory: 8MB
--- end ---
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":4,"warnings":13,"fixable":0},"files":{"\/src\/repo\/PageProperties.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/content\/PagePropertiesJsonDataContentHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/content\/PagePropertiesJsonDataContent.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/migrateSlots.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/api\/PagePropertiesApiCheckLatestVersion.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/PageProperties.php":{"errors":1,"warnings":5,"messages":[{"message":"Line exceeds 120 characters; contains 127 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":71,"column":127},{"message":"Line exceeds 120 characters; contains 190 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":243,"column":190},{"message":"Line exceeds 120 characters; contains 130 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":246,"column":130},{"message":"Line exceeds 120 characters; contains 143 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":303,"column":143},{"message":"Method name \"page_ancestors\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":379,"column":19},{"message":"Line exceeds 120 characters; contains 125 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":439,"column":13}]},"\/src\/repo\/includes\/PagePropertiesHooks.php":{"errors":0,"warnings":5,"messages":[{"message":"Line exceeds 120 characters; contains 142 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":67,"column":142},{"message":"Line exceeds 120 characters; contains 134 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":81,"column":134},{"message":"Line exceeds 120 characters; contains 197 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":153,"column":197},{"message":"Line exceeds 120 characters; contains 161 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":240,"column":161},{"message":"Line exceeds 120 characters; contains 191 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":259,"column":191}]},"\/src\/repo\/includes\/specials\/OOUIHTMLFormTabs.php":{"errors":2,"warnings":0,"messages":[{"message":"Visibility must be declared on method \"getValidMethod\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":98,"column":5},{"message":"Visibility must be declared on method \"getBody\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":113,"column":5}]},"\/src\/repo\/includes\/specials\/SpecialPageProperties.php":{"errors":1,"warnings":3,"messages":[{"message":"\"$_POST\" superglobals should not be accessed.","source":"MediaWiki.Usage.SuperGlobalsUsage.SuperGlobals","severity":5,"fixable":false,"type":"ERROR","line":231,"column":61},{"message":"Line exceeds 120 characters; contains 121 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":276,"column":121},{"message":"Line exceeds 120 characters; contains 148 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":419,"column":148},{"message":"Line exceeds 120 characters; contains 154 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":440,"column":154}]}}}
--- end ---
$ git checkout .phpcs.xml
--- stderr ---
Updated 1 path from the index
--- stdout ---
--- end ---
$ /usr/bin/composer install
--- stderr ---
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating autoload files
14 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
--- end ---
$ /usr/bin/composer test
--- stderr ---
> parallel-lint . --exclude vendor --exclude node_modules
> minus-x check .
> phpcs -sp --cache
--- stdout ---
PHP 8.2.20 | 10 parallel jobs
......... 9/9 (100%)
Checked 9 files in 0.1 seconds
No syntax error found
MinusX
======
Processing /src/repo...
...............................
All good!
......... 9 / 9 (100%)
Time: 122ms; Memory: 8MB
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 418,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 418
}
}
}
--- end ---
$ package-lock-lint package-lock.json
--- stdout ---
Checking package-lock.json
--- end ---
build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
$ git add .
--- stdout ---
--- end ---
$ git commit -F /tmp/tmpxdce28bx
--- stdout ---
[master 1fe3540] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
3 files changed, 3 insertions(+), 3 deletions(-)
--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From 1fe35408e9065c77586f55f5cdebd508e9e6c3dd Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Thu, 14 Nov 2024 09:33:40 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
Change-Id: I5cf88b7a5906a852da217f4316ec8dee2a5ccf81
---
composer.json | 2 +-
includes/PagePropertiesHooks.php | 2 +-
includes/specials/SpecialPageProperties.php | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/composer.json b/composer.json
index b3f8e51..3be6644 100644
--- a/composer.json
+++ b/composer.json
@@ -1,6 +1,6 @@
{
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "44.0.0",
+ "mediawiki/mediawiki-codesniffer": "45.0.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
"php-parallel-lint/php-parallel-lint": "1.4.0"
diff --git a/includes/PagePropertiesHooks.php b/includes/PagePropertiesHooks.php
index 43bb512..0de2c0c 100644
--- a/includes/PagePropertiesHooks.php
+++ b/includes/PagePropertiesHooks.php
@@ -116,7 +116,7 @@ class PagePropertiesHooks {
/**
* @param DatabaseUpdater|null $updater
*/
- public static function onLoadExtensionSchemaUpdates( DatabaseUpdater $updater = null ) {
+ public static function onLoadExtensionSchemaUpdates( ?DatabaseUpdater $updater = null ) {
$base = __DIR__;
$db = $updater->getDB();
$dbType = $db->getType();
diff --git a/includes/specials/SpecialPageProperties.php b/includes/specials/SpecialPageProperties.php
index 6e44377..64fdcdb 100644
--- a/includes/specials/SpecialPageProperties.php
+++ b/includes/specials/SpecialPageProperties.php
@@ -551,7 +551,7 @@ class SpecialPageProperties extends SpecialPage {
* @param Title|null $title
* @return array
*/
- private function getOptionsForTitle( Title $title = null ) {
+ private function getOptionsForTitle( ?Title $title = null ) {
$contentHandlerFactory = MediaWikiServices::getInstance()->getContentHandlerFactory();
$models = $contentHandlerFactory->getContentModels();
$options = [];
--
2.39.2
--- end ---