This run took 18 seconds.
From 96f3c1f7cb16151848bf8bac08790391d6c35cfe Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Wed, 13 Nov 2024 03:21:45 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
The following sniffs are failing and were disabled:
* Generic.Files.LineLength.TooLong
Change-Id: Ib3835fd76e19ab8ea5a30c031fd37e6117259acd
---
.phpcs.xml | 1 +
composer.json | 2 +-
includes/WikiSEO.php | 2 +-
tests/phpunit/Generator/GeneratorTestBase.php | 2 +-
4 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/.phpcs.xml b/.phpcs.xml
index 80b1349..bed0ecb 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,6 +1,7 @@
<?xml version="1.0"?>
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+ <exclude name="Generic.Files.LineLength.TooLong" />
<exclude name="MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPrivate" />
<exclude name="MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected" />
</rule>
diff --git a/composer.json b/composer.json
index 0ce5603..f39219c 100644
--- a/composer.json
+++ b/composer.json
@@ -17,7 +17,7 @@
"composer/installers": ">=1.0.1"
},
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "44.0.0",
+ "mediawiki/mediawiki-codesniffer": "45.0.0",
"mediawiki/mediawiki-phan-config": "0.14.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
diff --git a/includes/WikiSEO.php b/includes/WikiSEO.php
index 3663d5c..88047ff 100644
--- a/includes/WikiSEO.php
+++ b/includes/WikiSEO.php
@@ -121,7 +121,7 @@ class WikiSEO {
* The reason is, if a description was provided and does not equal 'auto' or 'textextracts' we want to use it.
* @see Validator
*/
- public function setMetadata( array $metadataArray, ParserOutput $out = null ): void {
+ public function setMetadata( array $metadataArray, ?ParserOutput $out = null ): void {
$validMetadata = [];
// We'll set a flag to don't overwrite manual descriptions
diff --git a/tests/phpunit/Generator/GeneratorTestBase.php b/tests/phpunit/Generator/GeneratorTestBase.php
index 2cfae07..4255c2c 100644
--- a/tests/phpunit/Generator/GeneratorTestBase.php
+++ b/tests/phpunit/Generator/GeneratorTestBase.php
@@ -23,7 +23,7 @@ class GeneratorTestBase extends MediaWikiIntegrationTestCase {
* @return OutputPage
* @see \OutputPageTest::newInstance()
*/
- protected function newInstance( $config = [], WebRequest $request = null, $options = [], $title = 'My test page' ) {
+ protected function newInstance( $config = [], ?WebRequest $request = null, $options = [], $title = 'My test page' ) {
$context = new RequestContext();
$context->setConfig(
--
2.39.2
$ date
--- stdout ---
Wed Nov 13 03:21:34 UTC 2024
--- end ---
$ git clone file:///srv/git/mediawiki-extensions-WikiSEO.git repo --depth=1 -b master
--- stderr ---
Cloning into 'repo'...
--- stdout ---
--- end ---
$ git config user.name libraryupgrader
--- stdout ---
--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---
--- end ---
$ git submodule update --init
--- stdout ---
--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.
--- end ---
$ git show-ref refs/heads/master
--- stdout ---
de61d8c93cc10e00bb4f9050e16c63a1ed59aa68 refs/heads/master
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 311,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 311
}
}
}
--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 39 installs, 0 updates, 0 removals
- Locking composer/installers (v2.3.0)
- Locking composer/pcre (3.3.2)
- Locking composer/semver (3.4.2)
- Locking composer/spdx-licenses (1.5.8)
- Locking composer/xdebug-handler (3.0.5)
- Locking dealerdirect/phpcodesniffer-composer-installer (v1.0.0)
- Locking doctrine/deprecations (1.1.3)
- Locking felixfbecker/advanced-json-rpc (v3.2.1)
- Locking mediawiki/mediawiki-codesniffer (v44.0.0)
- Locking mediawiki/mediawiki-phan-config (0.14.0)
- Locking mediawiki/minus-x (1.1.3)
- Locking mediawiki/phan-taint-check-plugin (6.0.0)
- Locking microsoft/tolerant-php-parser (v0.1.2)
- Locking netresearch/jsonmapper (v4.5.0)
- Locking phan/phan (5.4.3)
- Locking php-parallel-lint/php-console-color (v1.0.1)
- Locking php-parallel-lint/php-console-highlighter (v1.0.0)
- Locking php-parallel-lint/php-parallel-lint (v1.4.0)
- Locking phpcsstandards/phpcsextra (1.2.1)
- Locking phpcsstandards/phpcsutils (1.0.11)
- Locking phpdocumentor/reflection-common (2.2.0)
- Locking phpdocumentor/reflection-docblock (5.6.0)
- Locking phpdocumentor/type-resolver (1.10.0)
- Locking phpstan/phpdoc-parser (2.0.0)
- Locking psr/container (2.0.2)
- Locking psr/log (3.0.2)
- Locking sabre/event (5.1.7)
- Locking squizlabs/php_codesniffer (3.9.0)
- Locking symfony/console (v7.1.7)
- Locking symfony/deprecation-contracts (v3.5.0)
- Locking symfony/polyfill-ctype (v1.31.0)
- Locking symfony/polyfill-intl-grapheme (v1.31.0)
- Locking symfony/polyfill-intl-normalizer (v1.31.0)
- Locking symfony/polyfill-mbstring (v1.31.0)
- Locking symfony/polyfill-php80 (v1.31.0)
- Locking symfony/service-contracts (v3.5.0)
- Locking symfony/string (v7.1.6)
- Locking tysonandre/var_representation_polyfill (0.1.3)
- Locking webmozart/assert (1.11.0)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 39 installs, 0 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Installing composer/installers (v2.3.0): Extracting archive
- Installing squizlabs/php_codesniffer (3.9.0): Extracting archive
- Installing dealerdirect/phpcodesniffer-composer-installer (v1.0.0): Extracting archive
- Installing composer/pcre (3.3.2): Extracting archive
- Installing symfony/polyfill-php80 (v1.31.0): Extracting archive
- Installing phpcsstandards/phpcsutils (1.0.11): Extracting archive
- Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive
- Installing symfony/polyfill-mbstring (v1.31.0): Extracting archive
- Installing composer/spdx-licenses (1.5.8): Extracting archive
- Installing composer/semver (3.4.2): Extracting archive
- Installing mediawiki/mediawiki-codesniffer (v44.0.0): Extracting archive
- Installing tysonandre/var_representation_polyfill (0.1.3): Extracting archive
- Installing symfony/polyfill-intl-normalizer (v1.31.0): Extracting archive
- Installing symfony/polyfill-intl-grapheme (v1.31.0): Extracting archive
- Installing symfony/polyfill-ctype (v1.31.0): Extracting archive
- Installing symfony/string (v7.1.6): Extracting archive
- Installing symfony/deprecation-contracts (v3.5.0): Extracting archive
- Installing psr/container (2.0.2): Extracting archive
- Installing symfony/service-contracts (v3.5.0): Extracting archive
- Installing symfony/console (v7.1.7): Extracting archive
- Installing sabre/event (5.1.7): Extracting archive
- Installing netresearch/jsonmapper (v4.5.0): Extracting archive
- Installing microsoft/tolerant-php-parser (v0.1.2): Extracting archive
- Installing webmozart/assert (1.11.0): Extracting archive
- Installing phpstan/phpdoc-parser (2.0.0): Extracting archive
- Installing phpdocumentor/reflection-common (2.2.0): Extracting archive
- Installing doctrine/deprecations (1.1.3): Extracting archive
- Installing phpdocumentor/type-resolver (1.10.0): Extracting archive
- Installing phpdocumentor/reflection-docblock (5.6.0): Extracting archive
- Installing felixfbecker/advanced-json-rpc (v3.2.1): Extracting archive
- Installing psr/log (3.0.2): Extracting archive
- Installing composer/xdebug-handler (3.0.5): Extracting archive
- Installing phan/phan (5.4.3): Extracting archive
- Installing mediawiki/phan-taint-check-plugin (6.0.0): Extracting archive
- Installing mediawiki/mediawiki-phan-config (0.14.0): Extracting archive
- Installing mediawiki/minus-x (1.1.3): Extracting archive
- Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
- Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
- Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive
0/36 [>---------------------------] 0%
20/36 [===============>------------] 55%
35/36 [===========================>] 97%
36/36 [============================] 100%
Generating autoload files
17 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Upgrading c:mediawiki/mediawiki-codesniffer from 44.0.0 -> 45.0.0
$ /usr/bin/composer update
--- stderr ---
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 4 updates, 0 removals
- Upgrading composer/semver (3.4.2 => 3.4.3)
- Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0)
- Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12)
- Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 4 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3): Extracting archive
- Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12): Extracting archive
- Upgrading composer/semver (3.4.2 => 3.4.3): Extracting archive
- Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0): Extracting archive
0/4 [>---------------------------] 0%
3/4 [=====================>------] 75%
4/4 [============================] 100%
Generating autoload files
17 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Previously failing phpcs rules: {'MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected', 'MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPrivate'}
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":8,"warnings":0,"fixable":2},"files":{"\/src\/repo\/WikiSEO.i18n.magic.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/WikiSEOLuaPreAddPagePropsHook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Generator\/GeneratorInterface.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/WikiSEOPreAddMetadataHook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/OverwritePageImageProp.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/WikiSEOPreAddPagePropsHook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/TagParser.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/SeoLua.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/ScribuntoHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Generator\/Plugins\/Twitter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/ParserHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/GenerateDescription.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Generator\/Plugins\/DublinCore.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/ApiDescriptionTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/PageHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/DeferredDescriptionUpdate.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ApiDescription.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Generator\/GeneratorTestBase.php":{"errors":1,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?WebRequest $request = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":26,"column":51}]},"\/src\/repo\/tests\/phpunit\/TagParserTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Validator.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Generator\/Plugin\/DublinCoreTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Generator\/Plugins\/Citation.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Generator\/Plugins\/SchemaOrg.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/OverwritePageImagePropTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Hooks\/InfoActionTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Generator\/Plugin\/CitationTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Generator\/Plugin\/TwitterTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Generator\/Plugins\/OpenGraph.php":{"errors":2,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":37,"column":22},{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":38,"column":22}]},"\/src\/repo\/includes\/Hooks\/InfoAction.php":{"errors":2,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPrivate","severity":5,"fixable":false,"type":"ERROR","line":39,"column":13},{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPrivate","severity":5,"fixable":false,"type":"ERROR","line":40,"column":13}]},"\/src\/repo\/tests\/phpunit\/ValidatorTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Generator\/Plugin\/SchemaOrgTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Hooks\/PageHooksTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Generator\/AbstractBaseGenerator.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/WikiSEOTest.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPrivate","severity":5,"fixable":false,"type":"ERROR","line":21,"column":13}]},"\/src\/repo\/tests\/phpunit\/Generator\/MetaTagTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Generator\/MetaTag.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":37,"column":15}]},"\/src\/repo\/tests\/phpunit\/Generator\/Plugin\/OpenGraphTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/WikiSEO.php":{"errors":1,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?ParserOutput $out = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":124,"column":56}]},"\/src\/repo\/includes\/Api\/RestSocialMediaImage.php":{"errors":0,"warnings":0,"messages":[]}}}
--- end ---
PHPCS run failed
$ vendor/bin/phpcbf
--- stdout ---
PHPCBF RESULT SUMMARY
----------------------------------------------------------------------------
FILE FIXED REMAINING
----------------------------------------------------------------------------
/src/repo/tests/phpunit/Generator/GeneratorTestBase.php 1 1
/src/repo/includes/WikiSEO.php 1 0
----------------------------------------------------------------------------
A TOTAL OF 2 ERRORS WERE FIXED IN 2 FILES
----------------------------------------------------------------------------
Time: 948ms; Memory: 8MB
--- end ---
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":6,"warnings":1,"fixable":0},"files":{"\/src\/repo\/WikiSEO.i18n.magic.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/WikiSEOLuaPreAddPagePropsHook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Generator\/GeneratorInterface.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/SeoLua.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Generator\/Plugins\/Twitter.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/WikiSEOPreAddPagePropsHook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/OverwritePageImageProp.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Generator\/Plugins\/DublinCore.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/WikiSEOPreAddMetadataHook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/TagParser.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/GenerateDescription.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/ScribuntoHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/ParserHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ApiDescription.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/DeferredDescriptionUpdate.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/PageHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/ApiDescriptionTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Validator.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/TagParserTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Generator\/Plugins\/Citation.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Generator\/Plugins\/SchemaOrg.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Generator\/Plugin\/DublinCoreTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Generator\/Plugin\/CitationTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Generator\/GeneratorTestBase.php":{"errors":0,"warnings":1,"messages":[{"message":"Line exceeds 120 characters; contains 121 characters","source":"Generic.Files.LineLength.TooLong","severity":5,"fixable":false,"type":"WARNING","line":26,"column":121}]},"\/src\/repo\/includes\/Generator\/Plugins\/OpenGraph.php":{"errors":2,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":37,"column":22},{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":38,"column":22}]},"\/src\/repo\/tests\/phpunit\/Generator\/Plugin\/TwitterTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Generator\/Plugin\/SchemaOrgTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/InfoAction.php":{"errors":2,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPrivate","severity":5,"fixable":false,"type":"ERROR","line":39,"column":13},{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPrivate","severity":5,"fixable":false,"type":"ERROR","line":40,"column":13}]},"\/src\/repo\/tests\/phpunit\/Hooks\/InfoActionTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/OverwritePageImagePropTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/ValidatorTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Hooks\/PageHooksTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Generator\/AbstractBaseGenerator.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/WikiSEO.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Generator\/MetaTagTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Generator\/MetaTag.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":37,"column":15}]},"\/src\/repo\/includes\/Api\/RestSocialMediaImage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Generator\/Plugin\/OpenGraphTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/WikiSEOTest.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPrivate","severity":5,"fixable":false,"type":"ERROR","line":21,"column":13}]}}}
--- end ---
* sniff Generic.Files.LineLength.TooLong is now failing
$ git checkout .phpcs.xml
--- stderr ---
Updated 1 path from the index
--- stdout ---
--- end ---
$ /usr/bin/composer install
--- stderr ---
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating autoload files
17 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
--- end ---
$ /usr/bin/composer test
--- stderr ---
> parallel-lint . --exclude vendor --exclude node_modules
> phpcs -sp --cache
> minus-x check .
--- stdout ---
PHP 8.2.20 | 10 parallel jobs
........................................ 40/40 (100%)
Checked 40 files in 0.2 seconds
No syntax error found
........................................ 40 / 40 (100%)
Time: 293ms; Memory: 8MB
MinusX
======
Processing /src/repo...
.............................................................
.............................................................
....
All good!
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 311,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 311
}
}
}
--- end ---
$ package-lock-lint package-lock.json
--- stdout ---
Checking package-lock.json
--- end ---
build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
The following sniffs are failing and were disabled:
* Generic.Files.LineLength.TooLong
$ git add .
--- stdout ---
--- end ---
$ git commit -F /tmp/tmpfisyhgju
--- stdout ---
[master 96f3c1f] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
4 files changed, 4 insertions(+), 3 deletions(-)
--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From 96f3c1f7cb16151848bf8bac08790391d6c35cfe Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Wed, 13 Nov 2024 03:21:45 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
The following sniffs are failing and were disabled:
* Generic.Files.LineLength.TooLong
Change-Id: Ib3835fd76e19ab8ea5a30c031fd37e6117259acd
---
.phpcs.xml | 1 +
composer.json | 2 +-
includes/WikiSEO.php | 2 +-
tests/phpunit/Generator/GeneratorTestBase.php | 2 +-
4 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/.phpcs.xml b/.phpcs.xml
index 80b1349..bed0ecb 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,6 +1,7 @@
<?xml version="1.0"?>
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+ <exclude name="Generic.Files.LineLength.TooLong" />
<exclude name="MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPrivate" />
<exclude name="MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected" />
</rule>
diff --git a/composer.json b/composer.json
index 0ce5603..f39219c 100644
--- a/composer.json
+++ b/composer.json
@@ -17,7 +17,7 @@
"composer/installers": ">=1.0.1"
},
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "44.0.0",
+ "mediawiki/mediawiki-codesniffer": "45.0.0",
"mediawiki/mediawiki-phan-config": "0.14.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
diff --git a/includes/WikiSEO.php b/includes/WikiSEO.php
index 3663d5c..88047ff 100644
--- a/includes/WikiSEO.php
+++ b/includes/WikiSEO.php
@@ -121,7 +121,7 @@ class WikiSEO {
* The reason is, if a description was provided and does not equal 'auto' or 'textextracts' we want to use it.
* @see Validator
*/
- public function setMetadata( array $metadataArray, ParserOutput $out = null ): void {
+ public function setMetadata( array $metadataArray, ?ParserOutput $out = null ): void {
$validMetadata = [];
// We'll set a flag to don't overwrite manual descriptions
diff --git a/tests/phpunit/Generator/GeneratorTestBase.php b/tests/phpunit/Generator/GeneratorTestBase.php
index 2cfae07..4255c2c 100644
--- a/tests/phpunit/Generator/GeneratorTestBase.php
+++ b/tests/phpunit/Generator/GeneratorTestBase.php
@@ -23,7 +23,7 @@ class GeneratorTestBase extends MediaWikiIntegrationTestCase {
* @return OutputPage
* @see \OutputPageTest::newInstance()
*/
- protected function newInstance( $config = [], WebRequest $request = null, $options = [], $title = 'My test page' ) {
+ protected function newInstance( $config = [], ?WebRequest $request = null, $options = [], $title = 'My test page' ) {
$context = new RequestContext();
$context->setConfig(
--
2.39.2
--- end ---