This run took 17 seconds.
From ac1913b9ae1851f2bbb3c9aa3d26af9642bde948 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Thu, 7 Nov 2024 18:25:57 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Usage.NullableType.ExplicitNullableTypes
Change-Id: I8603a8954c6249d7ab46e90219678422e3e58693
---
.phpcs.xml | 4 +++-
composer.json | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/.phpcs.xml b/.phpcs.xml
index b915cf8..b9e92ea 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,6 +1,8 @@
<?xml version="1.0"?>
<ruleset>
- <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki" />
+ <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+ <exclude name="MediaWiki.Usage.NullableType.ExplicitNullableTypes" />
+ </rule>
<file>.</file>
<arg name="extensions" value="php"/>
<arg name="encoding" value="UTF-8"/>
diff --git a/composer.json b/composer.json
index 6cf52f3..89cde47 100644
--- a/composer.json
+++ b/composer.json
@@ -33,7 +33,7 @@
"installer-name": "Vector"
},
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "44.0.0",
+ "mediawiki/mediawiki-codesniffer": "45.0.0",
"mediawiki/mediawiki-phan-config": "0.14.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
--
2.39.2
$ date
--- stdout ---
Thu Nov 7 18:25:44 UTC 2024
--- end ---
$ git clone file:///srv/git/mediawiki-skins-Vector.git repo --depth=1 -b REL1_43
--- stderr ---
Cloning into 'repo'...
--- stdout ---
--- end ---
$ git config user.name libraryupgrader
--- stdout ---
--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---
--- end ---
$ git submodule update --init
--- stdout ---
--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.
--- end ---
$ git show-ref refs/heads/REL1_43
--- stdout ---
1bfdc40be9f20e4c01a8b0fed4c8120f808265c7 refs/heads/REL1_43
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 902,
"optional": 2,
"peer": 0,
"peerOptional": 0,
"total": 902
}
}
}
--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 39 installs, 0 updates, 0 removals
- Locking composer/installers (v2.3.0)
- Locking composer/pcre (3.3.1)
- Locking composer/semver (3.4.2)
- Locking composer/spdx-licenses (1.5.8)
- Locking composer/xdebug-handler (3.0.5)
- Locking dealerdirect/phpcodesniffer-composer-installer (v1.0.0)
- Locking doctrine/deprecations (1.1.3)
- Locking felixfbecker/advanced-json-rpc (v3.2.1)
- Locking mediawiki/mediawiki-codesniffer (v44.0.0)
- Locking mediawiki/mediawiki-phan-config (0.14.0)
- Locking mediawiki/minus-x (1.1.3)
- Locking mediawiki/phan-taint-check-plugin (6.0.0)
- Locking microsoft/tolerant-php-parser (v0.1.2)
- Locking netresearch/jsonmapper (v4.5.0)
- Locking phan/phan (5.4.3)
- Locking php-parallel-lint/php-console-color (v1.0.1)
- Locking php-parallel-lint/php-console-highlighter (v1.0.0)
- Locking php-parallel-lint/php-parallel-lint (v1.4.0)
- Locking phpcsstandards/phpcsextra (1.2.1)
- Locking phpcsstandards/phpcsutils (1.0.11)
- Locking phpdocumentor/reflection-common (2.2.0)
- Locking phpdocumentor/reflection-docblock (5.5.1)
- Locking phpdocumentor/type-resolver (1.9.0)
- Locking phpstan/phpdoc-parser (1.33.0)
- Locking psr/container (2.0.2)
- Locking psr/log (3.0.2)
- Locking sabre/event (5.1.7)
- Locking squizlabs/php_codesniffer (3.9.0)
- Locking symfony/console (v7.1.7)
- Locking symfony/deprecation-contracts (v3.5.0)
- Locking symfony/polyfill-ctype (v1.31.0)
- Locking symfony/polyfill-intl-grapheme (v1.31.0)
- Locking symfony/polyfill-intl-normalizer (v1.31.0)
- Locking symfony/polyfill-mbstring (v1.31.0)
- Locking symfony/polyfill-php80 (v1.31.0)
- Locking symfony/service-contracts (v3.5.0)
- Locking symfony/string (v7.1.6)
- Locking tysonandre/var_representation_polyfill (0.1.3)
- Locking webmozart/assert (1.11.0)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 39 installs, 0 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Installing composer/installers (v2.3.0): Extracting archive
- Installing squizlabs/php_codesniffer (3.9.0): Extracting archive
- Installing dealerdirect/phpcodesniffer-composer-installer (v1.0.0): Extracting archive
- Installing composer/pcre (3.3.1): Extracting archive
- Installing symfony/polyfill-php80 (v1.31.0): Extracting archive
- Installing phpcsstandards/phpcsutils (1.0.11): Extracting archive
- Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive
- Installing symfony/polyfill-mbstring (v1.31.0): Extracting archive
- Installing composer/spdx-licenses (1.5.8): Extracting archive
- Installing composer/semver (3.4.2): Extracting archive
- Installing mediawiki/mediawiki-codesniffer (v44.0.0): Extracting archive
- Installing tysonandre/var_representation_polyfill (0.1.3): Extracting archive
- Installing symfony/polyfill-intl-normalizer (v1.31.0): Extracting archive
- Installing symfony/polyfill-intl-grapheme (v1.31.0): Extracting archive
- Installing symfony/polyfill-ctype (v1.31.0): Extracting archive
- Installing symfony/string (v7.1.6): Extracting archive
- Installing symfony/deprecation-contracts (v3.5.0): Extracting archive
- Installing psr/container (2.0.2): Extracting archive
- Installing symfony/service-contracts (v3.5.0): Extracting archive
- Installing symfony/console (v7.1.7): Extracting archive
- Installing sabre/event (5.1.7): Extracting archive
- Installing netresearch/jsonmapper (v4.5.0): Extracting archive
- Installing microsoft/tolerant-php-parser (v0.1.2): Extracting archive
- Installing webmozart/assert (1.11.0): Extracting archive
- Installing phpstan/phpdoc-parser (1.33.0): Extracting archive
- Installing phpdocumentor/reflection-common (2.2.0): Extracting archive
- Installing doctrine/deprecations (1.1.3): Extracting archive
- Installing phpdocumentor/type-resolver (1.9.0): Extracting archive
- Installing phpdocumentor/reflection-docblock (5.5.1): Extracting archive
- Installing felixfbecker/advanced-json-rpc (v3.2.1): Extracting archive
- Installing psr/log (3.0.2): Extracting archive
- Installing composer/xdebug-handler (3.0.5): Extracting archive
- Installing phan/phan (5.4.3): Extracting archive
- Installing mediawiki/phan-taint-check-plugin (6.0.0): Extracting archive
- Installing mediawiki/mediawiki-phan-config (0.14.0): Extracting archive
- Installing mediawiki/minus-x (1.1.3): Extracting archive
- Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
- Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
- Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive
0/36 [>---------------------------] 0%
24/36 [==================>---------] 66%
35/36 [===========================>] 97%
36/36 [============================] 100%
Generating autoload files
17 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Upgrading c:mediawiki/mediawiki-codesniffer from 44.0.0 -> 45.0.0
$ /usr/bin/composer update
--- stderr ---
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 4 updates, 0 removals
- Upgrading composer/semver (3.4.2 => 3.4.3)
- Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0)
- Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12)
- Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 4 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3): Extracting archive
- Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12): Extracting archive
- Upgrading composer/semver (3.4.2 => 3.4.3): Extracting archive
- Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0): Extracting archive
0/4 [>---------------------------] 0%
3/4 [=====================>------] 75%
4/4 [============================] 100%
Generating autoload files
17 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Previously failing phpcs rules: set()
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":3,"warnings":0,"fixable":3},"files":{"\/src\/repo\/includes\/VectorServices.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponent.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/HookRunner.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/FeatureManagement\/Requirement.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentMenuListItem.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/FeatureManagement\/Requirements\/SimpleRequirement.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentMenu.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Services\/LanguageService.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/FeatureManagement\/Requirements\/LoggedInRequirement.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/FeatureManagement\/Requirements\/ABRequirement.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/structure\/BundleSizeTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentLink.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/FeatureManagement\/Requirements\/LimitedWidthContentRequirement.php":{"errors":1,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?Title $title = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":51,"column":9}]},"\/src\/repo\/includes\/Components\/VectorComponentPinnableHeader.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentMainMenuAction.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ServiceWiring.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/FeatureManagement\/Requirements\/DynamicConfigRequirement.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentPinnableContainer.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentDropdown.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentButton.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/FeatureManagement\/Requirements\/ABRequirementTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentMainMenu.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentTableOfContents.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentPageTools.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentVariants.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/FeatureManagement\/Requirements\/DynamicConfigRequirementTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/FeatureManagement\/Requirements\/LoggedInRequirementTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/FeatureManagement\/Requirements\/OverrideableRequirementHelper.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentAppearance.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/Services\/LanguageServiceTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/FeatureManagement\/Requirements\/UserPreferenceRequirement.php":{"errors":1,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?Title $title = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":64,"column":9}]},"\/src\/repo\/includes\/SkinVectorLegacy.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/FeatureManagement\/Requirements\/UserPreferenceRequirementTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/SkinVector22Test.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/components\/VectorComponentMainMenuActionTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentStickyHeader.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Constants.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/FeatureManagement\/Requirements\/OverridableConfigRequirement.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/ServiceWiringTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentMainMenuActionOptOut.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/FeatureManagement\/FeatureManagerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentSearchBox.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/components\/VectorComponentAppearanceTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/components\/VectorComponentDropdownTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ConfigHelper.php":{"errors":1,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?Title $title = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":35,"column":80}]},"\/src\/repo\/tests\/phpunit\/unit\/components\/VectorComponentMainMenuTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/components\/VectorComponentPinnableElementTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentLanguageDropdown.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/components\/VectorComponentPageToolsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/components\/VectorComponentPinnableHeaderTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/FeatureManagement\/FeatureManager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/components\/VectorComponentButtonTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/components\/VectorComponentLanguageDropdownTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/components\/VectorComponentMenuTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/components\/VectorComponentLinkTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentUserLinks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentPinnableElement.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/FeatureManagement\/FeatureManagerFactory.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/FeatureManagement\/Requirements\/OverridableConfigRequirementTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/components\/VectorComponentPinnableContainerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/FeatureManagement\/FeatureManagerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/ConfigHelperTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/SkinVector22.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/components\/VectorComponentTableOfContentsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/VectorSearchResourceLoaderConfigHook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/SkinVectorTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/CentralAuthHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/VectorHooksTest.php":{"errors":0,"warnings":0,"messages":[]}}}
--- end ---
PHPCS run failed
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":3,"warnings":0,"fixable":3},"files":{"\/src\/repo\/includes\/Components\/VectorComponent.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/VectorServices.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/HookRunner.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/FeatureManagement\/Requirement.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Services\/LanguageService.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/FeatureManagement\/Requirements\/SimpleRequirement.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentMenuListItem.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/FeatureManagement\/Requirements\/LoggedInRequirement.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/structure\/BundleSizeTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/FeatureManagement\/Requirements\/DynamicConfigRequirement.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentLink.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentMenu.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/FeatureManagement\/Requirements\/ABRequirement.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentMainMenuAction.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentDropdown.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentButton.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/FeatureManagement\/Requirements\/LimitedWidthContentRequirement.php":{"errors":1,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?Title $title = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":51,"column":9}]},"\/src\/repo\/includes\/FeatureManagement\/Requirements\/OverrideableRequirementHelper.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentPinnableContainer.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentVariants.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/FeatureManagement\/Requirements\/LoggedInRequirementTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentMainMenu.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/FeatureManagement\/Requirements\/DynamicConfigRequirementTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentTableOfContents.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentPinnableHeader.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/FeatureManagement\/Requirements\/ABRequirementTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentPageTools.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/Services\/LanguageServiceTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentAppearance.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ServiceWiring.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/FeatureManagement\/Requirements\/UserPreferenceRequirement.php":{"errors":1,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?Title $title = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":64,"column":9}]},"\/src\/repo\/includes\/SkinVectorLegacy.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/SkinVector22Test.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/ServiceWiringTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/components\/VectorComponentMainMenuActionTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentLanguageDropdown.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/FeatureManagement\/Requirements\/UserPreferenceRequirementTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Constants.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/FeatureManagement\/Requirements\/OverridableConfigRequirement.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/components\/VectorComponentDropdownTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/FeatureManagement\/FeatureManagerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentStickyHeader.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentSearchBox.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/components\/VectorComponentAppearanceTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentMainMenuActionOptOut.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/FeatureManagement\/FeatureManager.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/components\/VectorComponentMainMenuTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/FeatureManagement\/FeatureManagerFactory.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/FeatureManagement\/Requirements\/OverridableConfigRequirementTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/components\/VectorComponentPinnableElementTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/components\/VectorComponentButtonTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/components\/VectorComponentPinnableHeaderTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/components\/VectorComponentPageToolsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/components\/VectorComponentPinnableContainerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ConfigHelper.php":{"errors":1,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?Title $title = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":35,"column":80}]},"\/src\/repo\/tests\/phpunit\/unit\/components\/VectorComponentLanguageDropdownTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/components\/VectorComponentMenuTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/components\/VectorComponentLinkTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/FeatureManagement\/FeatureManagerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentUserLinks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/components\/VectorComponentTableOfContentsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/ConfigHelperTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Components\/VectorComponentPinnableElement.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/SkinVectorTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/CentralAuthHooks.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/SkinVector22.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/Hooks\/VectorSearchResourceLoaderConfigHook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/VectorHooksTest.php":{"errors":0,"warnings":0,"messages":[]}}}
--- end ---
* sniff MediaWiki.Usage.NullableType.ExplicitNullableTypes is now failing
$ git checkout .phpcs.xml
--- stderr ---
Updated 1 path from the index
--- stdout ---
--- end ---
$ /usr/bin/composer install
--- stderr ---
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating autoload files
17 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
--- end ---
$ /usr/bin/composer test
--- stderr ---
> parallel-lint . --exclude node_modules --exclude vendor
> phpcs -sp --cache
> minus-x check .
--- stdout ---
PHP 8.2.20 | 10 parallel jobs
............................................................ 60/70 ( 85%)
.......... 70/70 (100%)
Checked 70 files in 0.3 seconds
No syntax error found
................................... 35 / 35 (100%)
Time: 269ms; Memory: 10MB
MinusX
======
Processing /src/repo...
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.......................
All good!
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 902,
"optional": 2,
"peer": 0,
"peerOptional": 0,
"total": 902
}
}
}
--- end ---
$ package-lock-lint package-lock.json
--- stdout ---
Checking package-lock.json
--- end ---
build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Usage.NullableType.ExplicitNullableTypes
$ git add .
--- stdout ---
--- end ---
$ git commit -F /tmp/tmp32dp9dpj
--- stdout ---
[REL1_43 ac1913b] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
2 files changed, 4 insertions(+), 2 deletions(-)
--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From ac1913b9ae1851f2bbb3c9aa3d26af9642bde948 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Thu, 7 Nov 2024 18:25:57 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Usage.NullableType.ExplicitNullableTypes
Change-Id: I8603a8954c6249d7ab46e90219678422e3e58693
---
.phpcs.xml | 4 +++-
composer.json | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/.phpcs.xml b/.phpcs.xml
index b915cf8..b9e92ea 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,6 +1,8 @@
<?xml version="1.0"?>
<ruleset>
- <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki" />
+ <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+ <exclude name="MediaWiki.Usage.NullableType.ExplicitNullableTypes" />
+ </rule>
<file>.</file>
<arg name="extensions" value="php"/>
<arg name="encoding" value="UTF-8"/>
diff --git a/composer.json b/composer.json
index 6cf52f3..89cde47 100644
--- a/composer.json
+++ b/composer.json
@@ -33,7 +33,7 @@
"installer-name": "Vector"
},
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "44.0.0",
+ "mediawiki/mediawiki-codesniffer": "45.0.0",
"mediawiki/mediawiki-phan-config": "0.14.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
--
2.39.2
--- end ---