mediawiki/extensions/TitleIcon: main (log #1588484)

sourcepatches

This run took 17 seconds.

From 9c0d057be801ba38c7a719389b9bf9c07d7a7f31 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Tue, 5 Nov 2024 03:13:40 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0

Change-Id: I660e0b24620353a047122472a07f97b0f9eef730
---
 composer.json                                 | 2 +-
 tests/phpunit/integration/IconManagerTest.php | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/composer.json b/composer.json
index 761f499..5c69337 100644
--- a/composer.json
+++ b/composer.json
@@ -18,7 +18,7 @@
 		}
 	],
 	"require-dev": {
-		"mediawiki/mediawiki-codesniffer": "44.0.0",
+		"mediawiki/mediawiki-codesniffer": "45.0.0",
 		"mediawiki/mediawiki-phan-config": "0.14.0",
 		"mediawiki/minus-x": "1.1.3",
 		"php-parallel-lint/php-console-highlighter": "1.0.0",
diff --git a/tests/phpunit/integration/IconManagerTest.php b/tests/phpunit/integration/IconManagerTest.php
index 7a1e546..c2d1366 100644
--- a/tests/phpunit/integration/IconManagerTest.php
+++ b/tests/phpunit/integration/IconManagerTest.php
@@ -37,8 +37,8 @@ class IconManagerTest extends MediaWikiIntegrationTestCase {
 
 	private function setPageContent(
 		string $testPageContent,
-		string $testCategoryContent = null,
-		string $testNamespaceContent = null
+		?string $testCategoryContent = null,
+		?string $testNamespaceContent = null
 	): array {
 		$result = [];
 		if ( $testNamespaceContent ) {
-- 
2.39.2

$ date
--- stdout ---
Tue Nov  5 03:13:29 UTC 2024

--- end ---
$ git clone file:///srv/git/mediawiki-extensions-TitleIcon.git repo --depth=1 -b master
--- stderr ---
Cloning into 'repo'...
--- stdout ---

--- end ---
$ git config user.name libraryupgrader
--- stdout ---

--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---

--- end ---
$ git submodule update --init
--- stdout ---

--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.

--- end ---
$ git show-ref refs/heads/master
--- stdout ---
9fea6799d72ea8c36874a50e974c50dd0e99ca54 refs/heads/master

--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
  "auditReportVersion": 2,
  "vulnerabilities": {},
  "metadata": {
    "vulnerabilities": {
      "info": 0,
      "low": 0,
      "moderate": 0,
      "high": 0,
      "critical": 0,
      "total": 0
    },
    "dependencies": {
      "prod": 1,
      "dev": 314,
      "optional": 0,
      "peer": 1,
      "peerOptional": 0,
      "total": 314
    }
  }
}

--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 38 installs, 0 updates, 0 removals
  - Locking composer/pcre (3.3.1)
  - Locking composer/semver (3.4.2)
  - Locking composer/spdx-licenses (1.5.8)
  - Locking composer/xdebug-handler (3.0.5)
  - Locking dealerdirect/phpcodesniffer-composer-installer (v1.0.0)
  - Locking doctrine/deprecations (1.1.3)
  - Locking felixfbecker/advanced-json-rpc (v3.2.1)
  - Locking mediawiki/mediawiki-codesniffer (v44.0.0)
  - Locking mediawiki/mediawiki-phan-config (0.14.0)
  - Locking mediawiki/minus-x (1.1.3)
  - Locking mediawiki/phan-taint-check-plugin (6.0.0)
  - Locking microsoft/tolerant-php-parser (v0.1.2)
  - Locking netresearch/jsonmapper (v4.5.0)
  - Locking phan/phan (5.4.3)
  - Locking php-parallel-lint/php-console-color (v1.0.1)
  - Locking php-parallel-lint/php-console-highlighter (v1.0.0)
  - Locking php-parallel-lint/php-parallel-lint (v1.4.0)
  - Locking phpcsstandards/phpcsextra (1.2.1)
  - Locking phpcsstandards/phpcsutils (1.0.11)
  - Locking phpdocumentor/reflection-common (2.2.0)
  - Locking phpdocumentor/reflection-docblock (5.5.0)
  - Locking phpdocumentor/type-resolver (1.9.0)
  - Locking phpstan/phpdoc-parser (1.33.0)
  - Locking psr/container (2.0.2)
  - Locking psr/log (3.0.2)
  - Locking sabre/event (5.1.7)
  - Locking squizlabs/php_codesniffer (3.9.0)
  - Locking symfony/console (v7.1.6)
  - Locking symfony/deprecation-contracts (v3.5.0)
  - Locking symfony/polyfill-ctype (v1.31.0)
  - Locking symfony/polyfill-intl-grapheme (v1.31.0)
  - Locking symfony/polyfill-intl-normalizer (v1.31.0)
  - Locking symfony/polyfill-mbstring (v1.31.0)
  - Locking symfony/polyfill-php80 (v1.31.0)
  - Locking symfony/service-contracts (v3.5.0)
  - Locking symfony/string (v7.1.6)
  - Locking tysonandre/var_representation_polyfill (0.1.3)
  - Locking webmozart/assert (1.11.0)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 38 installs, 0 updates, 0 removals
    0 [>---------------------------]    0 [->--------------------------]
  - Installing squizlabs/php_codesniffer (3.9.0): Extracting archive
  - Installing dealerdirect/phpcodesniffer-composer-installer (v1.0.0): Extracting archive
  - Installing composer/pcre (3.3.1): Extracting archive
  - Installing symfony/polyfill-php80 (v1.31.0): Extracting archive
  - Installing phpcsstandards/phpcsutils (1.0.11): Extracting archive
  - Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive
  - Installing symfony/polyfill-mbstring (v1.31.0): Extracting archive
  - Installing composer/spdx-licenses (1.5.8): Extracting archive
  - Installing composer/semver (3.4.2): Extracting archive
  - Installing mediawiki/mediawiki-codesniffer (v44.0.0): Extracting archive
  - Installing tysonandre/var_representation_polyfill (0.1.3): Extracting archive
  - Installing symfony/polyfill-intl-normalizer (v1.31.0): Extracting archive
  - Installing symfony/polyfill-intl-grapheme (v1.31.0): Extracting archive
  - Installing symfony/polyfill-ctype (v1.31.0): Extracting archive
  - Installing symfony/string (v7.1.6): Extracting archive
  - Installing symfony/deprecation-contracts (v3.5.0): Extracting archive
  - Installing psr/container (2.0.2): Extracting archive
  - Installing symfony/service-contracts (v3.5.0): Extracting archive
  - Installing symfony/console (v7.1.6): Extracting archive
  - Installing sabre/event (5.1.7): Extracting archive
  - Installing netresearch/jsonmapper (v4.5.0): Extracting archive
  - Installing microsoft/tolerant-php-parser (v0.1.2): Extracting archive
  - Installing webmozart/assert (1.11.0): Extracting archive
  - Installing phpstan/phpdoc-parser (1.33.0): Extracting archive
  - Installing phpdocumentor/reflection-common (2.2.0): Extracting archive
  - Installing doctrine/deprecations (1.1.3): Extracting archive
  - Installing phpdocumentor/type-resolver (1.9.0): Extracting archive
  - Installing phpdocumentor/reflection-docblock (5.5.0): Extracting archive
  - Installing felixfbecker/advanced-json-rpc (v3.2.1): Extracting archive
  - Installing psr/log (3.0.2): Extracting archive
  - Installing composer/xdebug-handler (3.0.5): Extracting archive
  - Installing phan/phan (5.4.3): Extracting archive
  - Installing mediawiki/phan-taint-check-plugin (6.0.0): Extracting archive
  - Installing mediawiki/mediawiki-phan-config (0.14.0): Extracting archive
  - Installing mediawiki/minus-x (1.1.3): Extracting archive
  - Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
  - Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
  - Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive
  0/36 [>---------------------------]   0%
 20/36 [===============>------------]  55%
 32/36 [========================>---]  88%
 36/36 [============================] 100%
Generating autoload files
16 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils

--- end ---
Upgrading c:mediawiki/mediawiki-codesniffer from 44.0.0 -> 45.0.0
$ /usr/bin/composer update
--- stderr ---
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 4 updates, 0 removals
  - Upgrading composer/semver (3.4.2 => 3.4.3)
  - Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0)
  - Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12)
  - Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 4 updates, 0 removals
    0 [>---------------------------]    0 [->--------------------------]
  - Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3): Extracting archive
  - Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12): Extracting archive
  - Upgrading composer/semver (3.4.2 => 3.4.3): Extracting archive
  - Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0): Extracting archive
 0/4 [>---------------------------]   0%
 3/4 [=====================>------]  75%
 4/4 [============================] 100%
Generating autoload files
16 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils

--- end ---
Previously failing phpcs rules: set()
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":2,"warnings":0,"fixable":2},"files":{"\/src\/repo\/.phan\/stubs\/DIProperty.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/stubs\/StoreFactory.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/stubs\/DIWikiPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/stubs\/SemanticData.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/stubs\/Store.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/MainHookHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/i18n\/TitleIconMagic.i18n.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ServiceWiring.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/stubs\/SMWDataItem.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ApiQueryTitleIcons.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/SMWInterface.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/InitHookHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Icon.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/IconManagerTest.php":{"errors":2,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?string $testCategoryContent = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":40,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?string $testNamespaceContent = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":41,"column":9}]},"\/src\/repo\/src\/IconManager.php":{"errors":0,"warnings":0,"messages":[]}}}

--- end ---
PHPCS run failed
$ vendor/bin/phpcbf
--- stdout ---

PHPCBF RESULT SUMMARY
----------------------------------------------------------------------------
FILE                                                        FIXED  REMAINING
----------------------------------------------------------------------------
/src/repo/tests/phpunit/integration/IconManagerTest.php     2      0
----------------------------------------------------------------------------
A TOTAL OF 2 ERRORS WERE FIXED IN 1 FILE
----------------------------------------------------------------------------

Time: 359ms; Memory: 6MB



--- end ---
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":0,"warnings":0,"fixable":0},"files":{"\/src\/repo\/.phan\/stubs\/DIWikiPage.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/i18n\/TitleIconMagic.i18n.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/stubs\/StoreFactory.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/stubs\/SMWDataItem.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/stubs\/SemanticData.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/stubs\/DIProperty.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ServiceWiring.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ApiQueryTitleIcons.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/SMWInterface.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/InitHookHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/MainHookHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/stubs\/Store.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Icon.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/IconManagerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/IconManager.php":{"errors":0,"warnings":0,"messages":[]}}}

--- end ---
$ git checkout .phpcs.xml
--- stderr ---
Updated 1 path from the index
--- stdout ---

--- end ---
$ /usr/bin/composer install
--- stderr ---
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating autoload files
16 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---

--- end ---
$ /usr/bin/composer test
--- stderr ---
> parallel-lint . --exclude vendor --exclude node_modules
> phpcs -sp --cache
> minus-x check .
--- stdout ---
PHP 8.2.20 | 10 parallel jobs
................                                             16/16 (100%)


Checked 16 files in 0.1 seconds
No syntax error found
................ 16 / 16 (100%)


Time: 227ms; Memory: 38MB

MinusX
======
Processing /src/repo...
.............................................................
..........
All good!

--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
  "auditReportVersion": 2,
  "vulnerabilities": {},
  "metadata": {
    "vulnerabilities": {
      "info": 0,
      "low": 0,
      "moderate": 0,
      "high": 0,
      "critical": 0,
      "total": 0
    },
    "dependencies": {
      "prod": 1,
      "dev": 314,
      "optional": 0,
      "peer": 1,
      "peerOptional": 0,
      "total": 314
    }
  }
}

--- end ---
$ package-lock-lint package-lock.json
--- stdout ---
Checking package-lock.json

--- end ---
build: Updating mediawiki/mediawiki-codesniffer to 45.0.0

$ git add .
--- stdout ---

--- end ---
$ git commit -F /tmp/tmpml0ha3jd
--- stdout ---
[master 9c0d057] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
 2 files changed, 3 insertions(+), 3 deletions(-)

--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From 9c0d057be801ba38c7a719389b9bf9c07d7a7f31 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Tue, 5 Nov 2024 03:13:40 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0

Change-Id: I660e0b24620353a047122472a07f97b0f9eef730
---
 composer.json                                 | 2 +-
 tests/phpunit/integration/IconManagerTest.php | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/composer.json b/composer.json
index 761f499..5c69337 100644
--- a/composer.json
+++ b/composer.json
@@ -18,7 +18,7 @@
 		}
 	],
 	"require-dev": {
-		"mediawiki/mediawiki-codesniffer": "44.0.0",
+		"mediawiki/mediawiki-codesniffer": "45.0.0",
 		"mediawiki/mediawiki-phan-config": "0.14.0",
 		"mediawiki/minus-x": "1.1.3",
 		"php-parallel-lint/php-console-highlighter": "1.0.0",
diff --git a/tests/phpunit/integration/IconManagerTest.php b/tests/phpunit/integration/IconManagerTest.php
index 7a1e546..c2d1366 100644
--- a/tests/phpunit/integration/IconManagerTest.php
+++ b/tests/phpunit/integration/IconManagerTest.php
@@ -37,8 +37,8 @@ class IconManagerTest extends MediaWikiIntegrationTestCase {
 
 	private function setPageContent(
 		string $testPageContent,
-		string $testCategoryContent = null,
-		string $testNamespaceContent = null
+		?string $testCategoryContent = null,
+		?string $testNamespaceContent = null
 	): array {
 		$result = [];
 		if ( $testNamespaceContent ) {
-- 
2.39.2


--- end ---
Source code is licensed under the AGPL.