This run took 10 seconds.
From 3c2a06963f836c565888b2200f63233e5abb7bd8 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Sat, 2 Nov 2024 06:05:06 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
Change-Id: I7946cbea133338801ec4c904bbcac90ce6efdb29
---
composer.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/composer.json b/composer.json
index 08da618..897051c 100644
--- a/composer.json
+++ b/composer.json
@@ -1,6 +1,6 @@
{
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "44.0.0",
+ "mediawiki/mediawiki-codesniffer": "45.0.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
"php-parallel-lint/php-parallel-lint": "1.4.0"
--
2.39.2
$ date
--- stdout ---
Sat Nov 2 06:04:58 UTC 2024
--- end ---
$ git clone file:///srv/git/mediawiki-tools-code-utils.git repo --depth=1 -b master
--- stderr ---
Cloning into 'repo'...
--- stdout ---
--- end ---
$ git config user.name libraryupgrader
--- stdout ---
--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---
--- end ---
$ git submodule update --init
--- stdout ---
--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.
--- end ---
$ git show-ref refs/heads/master
--- stdout ---
64a340fd885709710a96725dc3675ddfefd0c4b2 refs/heads/master
--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 21 installs, 0 updates, 0 removals
- Locking composer/semver (3.4.2)
- Locking composer/spdx-licenses (1.5.8)
- Locking dealerdirect/phpcodesniffer-composer-installer (v1.0.0)
- Locking mediawiki/mediawiki-codesniffer (v44.0.0)
- Locking mediawiki/minus-x (1.1.3)
- Locking php-parallel-lint/php-console-color (v1.0.1)
- Locking php-parallel-lint/php-console-highlighter (v1.0.0)
- Locking php-parallel-lint/php-parallel-lint (v1.4.0)
- Locking phpcsstandards/phpcsextra (1.2.1)
- Locking phpcsstandards/phpcsutils (1.0.11)
- Locking psr/container (2.0.2)
- Locking squizlabs/php_codesniffer (3.9.0)
- Locking symfony/console (v7.1.6)
- Locking symfony/deprecation-contracts (v3.5.0)
- Locking symfony/polyfill-ctype (v1.31.0)
- Locking symfony/polyfill-intl-grapheme (v1.31.0)
- Locking symfony/polyfill-intl-normalizer (v1.31.0)
- Locking symfony/polyfill-mbstring (v1.31.0)
- Locking symfony/polyfill-php80 (v1.31.0)
- Locking symfony/service-contracts (v3.5.0)
- Locking symfony/string (v7.1.6)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 21 installs, 0 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Installing squizlabs/php_codesniffer (3.9.0): Extracting archive
- Installing dealerdirect/phpcodesniffer-composer-installer (v1.0.0): Extracting archive
- Installing symfony/polyfill-php80 (v1.31.0): Extracting archive
- Installing phpcsstandards/phpcsutils (1.0.11): Extracting archive
- Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive
- Installing symfony/polyfill-mbstring (v1.31.0): Extracting archive
- Installing composer/spdx-licenses (1.5.8): Extracting archive
- Installing composer/semver (3.4.2): Extracting archive
- Installing mediawiki/mediawiki-codesniffer (v44.0.0): Extracting archive
- Installing symfony/polyfill-intl-normalizer (v1.31.0): Extracting archive
- Installing symfony/polyfill-intl-grapheme (v1.31.0): Extracting archive
- Installing symfony/polyfill-ctype (v1.31.0): Extracting archive
- Installing symfony/string (v7.1.6): Extracting archive
- Installing symfony/deprecation-contracts (v3.5.0): Extracting archive
- Installing psr/container (2.0.2): Extracting archive
- Installing symfony/service-contracts (v3.5.0): Extracting archive
- Installing symfony/console (v7.1.6): Extracting archive
- Installing mediawiki/minus-x (1.1.3): Extracting archive
- Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
- Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
- Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive
0/19 [>---------------------------] 0%
19/19 [============================] 100%
Generating autoload files
14 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Upgrading c:mediawiki/mediawiki-codesniffer from 44.0.0 -> 45.0.0
$ /usr/bin/composer update
--- stderr ---
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 4 updates, 0 removals
- Upgrading composer/semver (3.4.2 => 3.4.3)
- Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0)
- Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12)
- Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 4 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3): Extracting archive
- Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12): Extracting archive
- Upgrading composer/semver (3.4.2 => 3.4.3): Extracting archive
- Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0): Extracting archive
0/4 [>---------------------------] 0%
3/4 [=====================>------] 75%
4/4 [============================] 100%
Generating autoload files
14 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Previously failing phpcs rules: {'Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition', 'Generic.CodeAnalysis.AssignmentInCondition.Found', 'MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected', 'MediaWiki.Files.ClassMatchesFilename.NotMatch', 'MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic', 'MediaWiki.Commenting.FunctionComment.MissingParamTag', 'MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix', 'MediaWiki.Commenting.FunctionComment.MissingReturn', 'MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected', 'MediaWiki.Commenting.FunctionComment.MissingParamName', 'MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix', 'Generic.CodeAnalysis.RequireExplicitBooleanOperatorPrecedence.MissingParentheses', 'MediaWiki.Commenting.FunctionComment.NoParamType'}
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":58,"warnings":2,"fixable":0},"files":{"\/src\/repo\/trim-i18n.php":{"errors":1,"warnings":0,"messages":[{"message":"Class name 'TrimI18n' does not match filename 'trim-i18n.php'","source":"MediaWiki.Files.ClassMatchesFilename.NotMatch","severity":5,"fixable":false,"type":"ERROR","line":17,"column":1}]},"\/src\/repo\/includes\/MwCodeUtilsArgs.php":{"errors":2,"warnings":0,"messages":[{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":37,"column":12},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":82,"column":12}]},"\/src\/repo\/clone-all.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/find-long-functions.php":{"errors":17,"warnings":0,"messages":[{"message":"Expected parameter type before parameter name \"$token_array\"","source":"MediaWiki.Commenting.FunctionComment.NoParamType","severity":5,"fixable":false,"type":"ERROR","line":49,"column":4},{"message":"Global function \"_analyze_tokens()\" is lacking a valid prefix ('wf'). It should be wf_analyze_tokens().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":51,"column":1},{"message":"Doc comment for parameter \"$state\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":136,"column":1},{"message":"Doc comment for parameter \"$token\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":136,"column":1},{"message":"Global function \"debug_state()\" is lacking a valid prefix ('wf'). It should be wfDebug_state().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":139,"column":1},{"message":"Class name 'TokenIterator' does not match filename 'find-long-functions.php'","source":"MediaWiki.Files.ClassMatchesFilename.NotMatch","severity":5,"fixable":false,"type":"ERROR","line":156,"column":1},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":157,"column":5},{"message":"Doc comment for parameter \"$wanted_token_index\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":161,"column":5},{"message":"Missing return type or @return tag in function comment","source":"MediaWiki.Commenting.FunctionComment.MissingReturn","severity":5,"fixable":false,"type":"ERROR","line":163,"column":6},{"message":"Doc comment for parameter \"$token\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":180,"column":1},{"message":"Missing parameter name","source":"MediaWiki.Commenting.FunctionComment.MissingParamName","severity":5,"fixable":false,"type":"ERROR","line":182,"column":4},{"message":"Global function \"_filter()\" is lacking a valid prefix ('wf'). It should be wf_filter().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":185,"column":1},{"message":"Global variable \"$wanted_tokens\" is lacking an allowed prefix ('wg'). Should be \"$wgWanted_tokens\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":186,"column":5},{"message":"Global variable \"$wanted_strings\" is lacking an allowed prefix ('wg'). Should be \"$wgWanted_strings\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":186,"column":5},{"message":"Global variable \"$unwanted_tokens\" is lacking an allowed prefix ('wg'). Should be \"$wgUnwanted_tokens\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":186,"column":5},{"message":"Global function \"analyze_file()\" is lacking a valid prefix ('wf'). It should be wfAnalyze_file().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":199,"column":1},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":199,"column":1}]},"\/src\/repo\/lint.php":{"errors":4,"warnings":1,"messages":[{"message":"Doc comment for parameter \"$verbose\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":57,"column":1},{"message":"Global function \"mwCodeUtils_lintDir()\" is lacking a valid prefix ('wf'). It should be wfMwCodeUtils_lintDir().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":62,"column":1},{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition","severity":5,"fixable":false,"type":"WARNING","line":71,"column":35},{"message":"Doc comment for parameter \"$verbose\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":88,"column":1},{"message":"Global function \"mwCodeUtils_lintFile()\" is lacking a valid prefix ('wf'). It should be wfMwCodeUtils_lintFile().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":93,"column":1}]},"\/src\/repo\/find-class-case-mismatches.php":{"errors":10,"warnings":0,"messages":[{"message":"Global function \"tokenDump()\" is lacking a valid prefix ('wf'). It should be wfTokenDump().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":35,"column":1},{"message":"Class name 'TokenScanner' does not match filename 'find-class-case-mismatches.php'","source":"MediaWiki.Files.ClassMatchesFilename.NotMatch","severity":5,"fixable":false,"type":"ERROR","line":43,"column":1},{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":44,"column":15},{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":45,"column":15},{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":46,"column":15},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":48,"column":12},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":52,"column":15},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":77,"column":12},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":97,"column":12},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":165,"column":15}]},"\/src\/repo\/find-entries.php":{"errors":24,"warnings":1,"messages":[{"message":"Global function \"debug()\" is lacking a valid prefix ('wf'). It should be wfDebug().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":44,"column":1},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":44,"column":1},{"message":"Global variable \"$debug\" is lacking an allowed prefix ('wg'). Should be \"$wgDebug\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":45,"column":5},{"message":"Global function \"getLastSignificantToken()\" is lacking a valid prefix ('wf'). It should be wfGetLastSignificantToken().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":51,"column":1},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":51,"column":1},{"message":"Doc comment for parameter \"$tokens\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":61,"column":1},{"message":"Doc comment for parameter \"$i\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":61,"column":1},{"message":"Doc comment for parameter \"$resultdir\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":61,"column":1},{"message":"Missing return type or @return tag in function comment","source":"MediaWiki.Commenting.FunctionComment.MissingReturn","severity":5,"fixable":false,"type":"ERROR","line":66,"column":2},{"message":"Global function \"advanceDirnames()\" is lacking a valid prefix ('wf'). It should be wfAdvanceDirnames().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":67,"column":1},{"message":"Doc comment for parameter \"$currentFilename\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":93,"column":1},{"message":"Doc comment for parameter \"$tokens\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":93,"column":1},{"message":"Doc comment for parameter \"$i\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":93,"column":1},{"message":"Missing return type or @return tag in function comment","source":"MediaWiki.Commenting.FunctionComment.MissingReturn","severity":5,"fixable":false,"type":"ERROR","line":95,"column":2},{"message":"Global function \"getIncludeFilename()\" is lacking a valid prefix ('wf'). It should be wfGetIncludeFilename().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":96,"column":1},{"message":"Global variable \"$includedFilenames\" is lacking an allowed prefix ('wg'). Should be \"$wgIncludedFilenames\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":98,"column":5},{"message":"Doc comment for parameter \"$path\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":169,"column":1},{"message":"Missing return type or @return tag in function comment","source":"MediaWiki.Commenting.FunctionComment.MissingReturn","severity":5,"fixable":false,"type":"ERROR","line":174,"column":2},{"message":"Global function \"cacheableAnalysis()\" is lacking a valid prefix ('wf'). It should be wfCacheableAnalysis().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":175,"column":1},{"message":"Global function \"isEntryPoint()\" is lacking a valid prefix ('wf'). It should be wfIsEntryPoint().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":179,"column":1},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":179,"column":1},{"message":"Global variable \"$whitelistedFunctions\" is lacking an allowed prefix ('wg'). Should be \"$wgWhitelistedFunctions\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":181,"column":5},{"message":"Global variable \"$includedFilenames\" is lacking an allowed prefix ('wg'). Should be \"$wgIncludedFilenames\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":181,"column":5},{"message":"Mixing different binary boolean operators within an expression without using parentheses to clarify precedence is not allowed.","source":"Generic.CodeAnalysis.RequireExplicitBooleanOperatorPrecedence.MissingParentheses","severity":5,"fixable":false,"type":"ERROR","line":213,"column":22},{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.Found","severity":5,"fixable":false,"type":"WARNING","line":284,"column":41}]}}}
--- end ---
PHPCS run failed
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":58,"warnings":2,"fixable":0},"files":{"\/src\/repo\/lint.php":{"errors":4,"warnings":1,"messages":[{"message":"Doc comment for parameter \"$verbose\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":57,"column":1},{"message":"Global function \"mwCodeUtils_lintDir()\" is lacking a valid prefix ('wf'). It should be wfMwCodeUtils_lintDir().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":62,"column":1},{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition","severity":5,"fixable":false,"type":"WARNING","line":71,"column":35},{"message":"Doc comment for parameter \"$verbose\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":88,"column":1},{"message":"Global function \"mwCodeUtils_lintFile()\" is lacking a valid prefix ('wf'). It should be wfMwCodeUtils_lintFile().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":93,"column":1}]},"\/src\/repo\/clone-all.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/MwCodeUtilsArgs.php":{"errors":2,"warnings":0,"messages":[{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":37,"column":12},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":82,"column":12}]},"\/src\/repo\/trim-i18n.php":{"errors":1,"warnings":0,"messages":[{"message":"Class name 'TrimI18n' does not match filename 'trim-i18n.php'","source":"MediaWiki.Files.ClassMatchesFilename.NotMatch","severity":5,"fixable":false,"type":"ERROR","line":17,"column":1}]},"\/src\/repo\/find-long-functions.php":{"errors":17,"warnings":0,"messages":[{"message":"Expected parameter type before parameter name \"$token_array\"","source":"MediaWiki.Commenting.FunctionComment.NoParamType","severity":5,"fixable":false,"type":"ERROR","line":49,"column":4},{"message":"Global function \"_analyze_tokens()\" is lacking a valid prefix ('wf'). It should be wf_analyze_tokens().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":51,"column":1},{"message":"Doc comment for parameter \"$state\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":136,"column":1},{"message":"Doc comment for parameter \"$token\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":136,"column":1},{"message":"Global function \"debug_state()\" is lacking a valid prefix ('wf'). It should be wfDebug_state().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":139,"column":1},{"message":"Class name 'TokenIterator' does not match filename 'find-long-functions.php'","source":"MediaWiki.Files.ClassMatchesFilename.NotMatch","severity":5,"fixable":false,"type":"ERROR","line":156,"column":1},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":157,"column":5},{"message":"Doc comment for parameter \"$wanted_token_index\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":161,"column":5},{"message":"Missing return type or @return tag in function comment","source":"MediaWiki.Commenting.FunctionComment.MissingReturn","severity":5,"fixable":false,"type":"ERROR","line":163,"column":6},{"message":"Doc comment for parameter \"$token\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":180,"column":1},{"message":"Missing parameter name","source":"MediaWiki.Commenting.FunctionComment.MissingParamName","severity":5,"fixable":false,"type":"ERROR","line":182,"column":4},{"message":"Global function \"_filter()\" is lacking a valid prefix ('wf'). It should be wf_filter().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":185,"column":1},{"message":"Global variable \"$wanted_tokens\" is lacking an allowed prefix ('wg'). Should be \"$wgWanted_tokens\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":186,"column":5},{"message":"Global variable \"$wanted_strings\" is lacking an allowed prefix ('wg'). Should be \"$wgWanted_strings\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":186,"column":5},{"message":"Global variable \"$unwanted_tokens\" is lacking an allowed prefix ('wg'). Should be \"$wgUnwanted_tokens\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":186,"column":5},{"message":"Global function \"analyze_file()\" is lacking a valid prefix ('wf'). It should be wfAnalyze_file().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":199,"column":1},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":199,"column":1}]},"\/src\/repo\/find-class-case-mismatches.php":{"errors":10,"warnings":0,"messages":[{"message":"Global function \"tokenDump()\" is lacking a valid prefix ('wf'). It should be wfTokenDump().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":35,"column":1},{"message":"Class name 'TokenScanner' does not match filename 'find-class-case-mismatches.php'","source":"MediaWiki.Files.ClassMatchesFilename.NotMatch","severity":5,"fixable":false,"type":"ERROR","line":43,"column":1},{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":44,"column":15},{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":45,"column":15},{"message":"Missing class property doc comment","source":"MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":46,"column":15},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":48,"column":12},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":52,"column":15},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":77,"column":12},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":97,"column":12},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":165,"column":15}]},"\/src\/repo\/find-entries.php":{"errors":24,"warnings":1,"messages":[{"message":"Global function \"debug()\" is lacking a valid prefix ('wf'). It should be wfDebug().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":44,"column":1},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":44,"column":1},{"message":"Global variable \"$debug\" is lacking an allowed prefix ('wg'). Should be \"$wgDebug\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":45,"column":5},{"message":"Global function \"getLastSignificantToken()\" is lacking a valid prefix ('wf'). It should be wfGetLastSignificantToken().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":51,"column":1},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":51,"column":1},{"message":"Doc comment for parameter \"$tokens\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":61,"column":1},{"message":"Doc comment for parameter \"$i\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":61,"column":1},{"message":"Doc comment for parameter \"$resultdir\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":61,"column":1},{"message":"Missing return type or @return tag in function comment","source":"MediaWiki.Commenting.FunctionComment.MissingReturn","severity":5,"fixable":false,"type":"ERROR","line":66,"column":2},{"message":"Global function \"advanceDirnames()\" is lacking a valid prefix ('wf'). It should be wfAdvanceDirnames().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":67,"column":1},{"message":"Doc comment for parameter \"$currentFilename\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":93,"column":1},{"message":"Doc comment for parameter \"$tokens\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":93,"column":1},{"message":"Doc comment for parameter \"$i\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":93,"column":1},{"message":"Missing return type or @return tag in function comment","source":"MediaWiki.Commenting.FunctionComment.MissingReturn","severity":5,"fixable":false,"type":"ERROR","line":95,"column":2},{"message":"Global function \"getIncludeFilename()\" is lacking a valid prefix ('wf'). It should be wfGetIncludeFilename().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":96,"column":1},{"message":"Global variable \"$includedFilenames\" is lacking an allowed prefix ('wg'). Should be \"$wgIncludedFilenames\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":98,"column":5},{"message":"Doc comment for parameter \"$path\" missing","source":"MediaWiki.Commenting.FunctionComment.MissingParamTag","severity":5,"fixable":false,"type":"ERROR","line":169,"column":1},{"message":"Missing return type or @return tag in function comment","source":"MediaWiki.Commenting.FunctionComment.MissingReturn","severity":5,"fixable":false,"type":"ERROR","line":174,"column":2},{"message":"Global function \"cacheableAnalysis()\" is lacking a valid prefix ('wf'). It should be wfCacheableAnalysis().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":175,"column":1},{"message":"Global function \"isEntryPoint()\" is lacking a valid prefix ('wf'). It should be wfIsEntryPoint().","source":"MediaWiki.NamingConventions.PrefixedGlobalFunctions.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":179,"column":1},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":179,"column":1},{"message":"Global variable \"$whitelistedFunctions\" is lacking an allowed prefix ('wg'). Should be \"$wgWhitelistedFunctions\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":181,"column":5},{"message":"Global variable \"$includedFilenames\" is lacking an allowed prefix ('wg'). Should be \"$wgIncludedFilenames\".","source":"MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix","severity":5,"fixable":false,"type":"ERROR","line":181,"column":5},{"message":"Mixing different binary boolean operators within an expression without using parentheses to clarify precedence is not allowed.","source":"Generic.CodeAnalysis.RequireExplicitBooleanOperatorPrecedence.MissingParentheses","severity":5,"fixable":false,"type":"ERROR","line":213,"column":22},{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.Found","severity":5,"fixable":false,"type":"WARNING","line":284,"column":41}]}}}
--- end ---
$ git checkout .phpcs.xml
--- stderr ---
Updated 1 path from the index
--- stdout ---
--- end ---
$ /usr/bin/composer install
--- stderr ---
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating autoload files
14 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
--- end ---
$ /usr/bin/composer test
--- stderr ---
> parallel-lint . --exclude vendor --exclude node_modules
> phpcs -sp --cache
> minus-x check .
--- stdout ---
PHP 8.2.20 | 10 parallel jobs
......... 9/9 (100%)
Checked 9 files in 0.1 seconds
No syntax error found
....... 7 / 7 (100%)
Time: 113ms; Memory: 8MB
MinusX
======
Processing /src/repo...
...........................
All good!
--- end ---
build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
$ git add .
--- stdout ---
--- end ---
$ git commit -F /tmp/tmpg0crktqr
--- stdout ---
[master 3c2a069] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
1 file changed, 1 insertion(+), 1 deletion(-)
--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From 3c2a06963f836c565888b2200f63233e5abb7bd8 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Sat, 2 Nov 2024 06:05:06 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
Change-Id: I7946cbea133338801ec4c904bbcac90ce6efdb29
---
composer.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/composer.json b/composer.json
index 08da618..897051c 100644
--- a/composer.json
+++ b/composer.json
@@ -1,6 +1,6 @@
{
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "44.0.0",
+ "mediawiki/mediawiki-codesniffer": "45.0.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
"php-parallel-lint/php-parallel-lint": "1.4.0"
--
2.39.2
--- end ---