This run took 17 seconds.
From 3b3382859bdb4cd06e161dd387f0f0fbc3653882 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Sat, 2 Nov 2024 03:05:38 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
Change-Id: Icadd6d1d7adba20a8622dc1ad499fa553978c755
---
composer.json | 2 +-
includes/PagesList.php | 4 ++--
includes/specials/PagesListOptions.php | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/composer.json b/composer.json
index 25415a8..64d8cd7 100644
--- a/composer.json
+++ b/composer.json
@@ -1,6 +1,6 @@
{
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "44.0.0",
+ "mediawiki/mediawiki-codesniffer": "45.0.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
"php-parallel-lint/php-parallel-lint": "1.4.0"
diff --git a/includes/PagesList.php b/includes/PagesList.php
index 9d55800..e59f960 100644
--- a/includes/PagesList.php
+++ b/includes/PagesList.php
@@ -86,7 +86,7 @@ class PagesList extends ContextSource {
* @param IContextSource|null $context
*/
function __construct( IDatabase $db, $namespace = null, $nsInvert = false, $associated = false,
- Title $category = null, Title $basePage = null, IContextSource $context = null ) {
+ ?Title $category = null, ?Title $basePage = null, ?IContextSource $context = null ) {
if ( $context ) {
$this->setContext( $context );
}
@@ -236,7 +236,7 @@ class PagesList extends ContextSource {
return get_class( $this );
}
- function getList( $format, $showLastUser, $showLastModification, OutputPage $out = null ) {
+ function getList( $format, $showLastUser, $showLastModification, ?OutputPage $out = null ) {
$useAjax = false;
switch ( $format ) {
case 'datatable':
diff --git a/includes/specials/PagesListOptions.php b/includes/specials/PagesListOptions.php
index 81a68a8..7d2385a 100644
--- a/includes/specials/PagesListOptions.php
+++ b/includes/specials/PagesListOptions.php
@@ -21,7 +21,7 @@ class PagesListOptions extends ContextSource {
* @param FormOptions $opts
* @param IContextSource|null $context
*/
- function __construct( Title $pageTitle, FormOptions $opts, IContextSource $context = null ) {
+ function __construct( Title $pageTitle, FormOptions $opts, ?IContextSource $context = null ) {
$this->pageTitle = $pageTitle;
$this->opts = $opts;
--
2.39.2
$ date
--- stdout ---
Sat Nov 2 03:05:26 UTC 2024
--- end ---
$ git clone file:///srv/git/mediawiki-extensions-PagesList.git repo --depth=1 -b master
--- stderr ---
Cloning into 'repo'...
--- stdout ---
--- end ---
$ git config user.name libraryupgrader
--- stdout ---
--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---
--- end ---
$ git submodule update --init
--- stderr ---
Submodule 'modules/DataTables' (https://github.com/DataTables/DataTables.git) registered for path 'modules/DataTables'
Cloning into '/src/repo/modules/DataTables'...
--- stdout ---
Submodule path 'modules/DataTables': checked out '24b2d114606725d05c1e79155284babc47d728ca'
--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.
--- end ---
$ git show-ref refs/heads/master
--- stdout ---
4d332dac94f6d0af9aed666a990df86246928dda refs/heads/master
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 428,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 428
}
}
}
--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 21 installs, 0 updates, 0 removals
- Locking composer/semver (3.4.2)
- Locking composer/spdx-licenses (1.5.8)
- Locking dealerdirect/phpcodesniffer-composer-installer (v1.0.0)
- Locking mediawiki/mediawiki-codesniffer (v44.0.0)
- Locking mediawiki/minus-x (1.1.3)
- Locking php-parallel-lint/php-console-color (v1.0.1)
- Locking php-parallel-lint/php-console-highlighter (v1.0.0)
- Locking php-parallel-lint/php-parallel-lint (v1.4.0)
- Locking phpcsstandards/phpcsextra (1.2.1)
- Locking phpcsstandards/phpcsutils (1.0.11)
- Locking psr/container (2.0.2)
- Locking squizlabs/php_codesniffer (3.9.0)
- Locking symfony/console (v7.1.6)
- Locking symfony/deprecation-contracts (v3.5.0)
- Locking symfony/polyfill-ctype (v1.31.0)
- Locking symfony/polyfill-intl-grapheme (v1.31.0)
- Locking symfony/polyfill-intl-normalizer (v1.31.0)
- Locking symfony/polyfill-mbstring (v1.31.0)
- Locking symfony/polyfill-php80 (v1.31.0)
- Locking symfony/service-contracts (v3.5.0)
- Locking symfony/string (v7.1.6)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 21 installs, 0 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Installing squizlabs/php_codesniffer (3.9.0): Extracting archive
- Installing dealerdirect/phpcodesniffer-composer-installer (v1.0.0): Extracting archive
- Installing symfony/polyfill-php80 (v1.31.0): Extracting archive
- Installing phpcsstandards/phpcsutils (1.0.11): Extracting archive
- Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive
- Installing symfony/polyfill-mbstring (v1.31.0): Extracting archive
- Installing composer/spdx-licenses (1.5.8): Extracting archive
- Installing composer/semver (3.4.2): Extracting archive
- Installing mediawiki/mediawiki-codesniffer (v44.0.0): Extracting archive
- Installing symfony/polyfill-intl-normalizer (v1.31.0): Extracting archive
- Installing symfony/polyfill-intl-grapheme (v1.31.0): Extracting archive
- Installing symfony/polyfill-ctype (v1.31.0): Extracting archive
- Installing symfony/string (v7.1.6): Extracting archive
- Installing symfony/deprecation-contracts (v3.5.0): Extracting archive
- Installing psr/container (2.0.2): Extracting archive
- Installing symfony/service-contracts (v3.5.0): Extracting archive
- Installing symfony/console (v7.1.6): Extracting archive
- Installing mediawiki/minus-x (1.1.3): Extracting archive
- Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
- Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
- Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive
0/19 [>---------------------------] 0%
19/19 [============================] 100%
Generating autoload files
14 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Upgrading c:mediawiki/mediawiki-codesniffer from 44.0.0 -> 45.0.0
$ /usr/bin/composer update
--- stderr ---
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 4 updates, 0 removals
- Upgrading composer/semver (3.4.2 => 3.4.3)
- Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0)
- Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12)
- Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 4 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3): Extracting archive
- Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12): Extracting archive
- Upgrading composer/semver (3.4.2 => 3.4.3): Extracting archive
- Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0): Extracting archive
0/4 [>---------------------------] 0%
3/4 [=====================>------] 75%
4/4 [============================] 100%
Generating autoload files
14 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Previously failing phpcs rules: {'MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic', 'Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition', 'MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage', 'PSR2.ControlStructures.SwitchDeclaration.TerminatingComment', 'Squiz.Scope.MethodScope.Missing', 'MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam', 'PSR12.Properties.ConstantVisibility.NotFound', 'MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment', 'MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation'}
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":32,"warnings":25,"fixable":5},"files":{"\/src\/repo\/PagesList.magic.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/specials\/PagesListOptions.php":{"errors":4,"warnings":1,"messages":[{"message":"Visibility must be declared on method \"__construct\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":24,"column":5},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?IContextSource $context = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":24,"column":64},{"message":"@global is not a valid function annotation","source":"MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":37,"column":8},{"message":"Should use function $this->getConfig()->get() rather than global $wgScript","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":41,"column":16},{"message":"Visibility must be declared on method \"getExtraOptions\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":93,"column":5}]},"\/src\/repo\/PagesList.i18n.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/api\/PagesListAPI.php":{"errors":2,"warnings":2,"messages":[{"message":"@global is not a valid function annotation","source":"MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":23,"column":8},{"message":"@global is not a valid function annotation","source":"MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":24,"column":8},{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListShowLastUser","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":28,"column":16},{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListShowLastModification","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":28,"column":42}]},"\/src\/repo\/includes\/specials\/SpecialPagesList.php":{"errors":0,"warnings":3,"messages":[{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListUseAjax","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":25,"column":16},{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListShowLastUser","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":45,"column":16},{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListShowLastModification","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":45,"column":42}]},"\/src\/repo\/includes\/specials\/SpecialPagesListQueryPage.php":{"errors":12,"warnings":3,"messages":[{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":50,"column":5},{"message":"Visibility must be declared on method \"isExpensive\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":50,"column":5},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":54,"column":5},{"message":"Visibility must be declared on method \"getQueryInfo\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":54,"column":5},{"message":"Visibility must be declared on method \"usesTimestamps\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":58,"column":5},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":62,"column":5},{"message":"Visibility must be declared on method \"getOrderFields\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":62,"column":5},{"message":"Visibility must be declared on method \"sortDescending\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":66,"column":5},{"message":"@global is not a valid function annotation","source":"MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":80,"column":8},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":82,"column":8},{"message":"Visibility must be declared on method \"formatResult\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":85,"column":5},{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListShowLastUser","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":86,"column":16},{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListShowLastModification","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":86,"column":42},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":92,"column":12},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":96,"column":12}]},"\/src\/repo\/includes\/PagesListHooks.php":{"errors":3,"warnings":0,"messages":[{"message":"@global is not a valid function annotation","source":"MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":16,"column":8},{"message":"@global is not a valid function annotation","source":"MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":69,"column":8},{"message":"@global is not a valid function annotation","source":"MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":70,"column":8}]},"\/src\/repo\/includes\/PagesList.php":{"errors":11,"warnings":16,"messages":[{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":14,"column":5},{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":19,"column":5},{"message":"Visibility must be declared on method \"__construct\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":88,"column":5},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?Title $category = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":89,"column":9},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?Title $basePage = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":89,"column":33},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?IContextSource $context = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":89,"column":57},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":118,"column":34},{"message":"Visibility must be declared on method \"getQueryInfo\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":154,"column":5},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":190,"column":25},{"message":"Visibility must be declared on method \"getNamespaceCond\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":210,"column":5},{"message":"Visibility must be declared on method \"getSqlComment\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":235,"column":5},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":239,"column":5},{"message":"Visibility must be declared on method \"getList\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":239,"column":5},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?OutputPage $out = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":239,"column":70},{"message":"There must be a comment when fall-through is intentional in a non-empty case body","source":"PSR2.ControlStructures.SwitchDeclaration.TerminatingComment","severity":5,"fixable":false,"type":"ERROR","line":242,"column":13},{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListUseAjax","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":245,"column":24},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":273,"column":8},{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition","severity":5,"fixable":false,"type":"WARNING","line":317,"column":32},{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition","severity":5,"fixable":false,"type":"WARNING","line":345,"column":25},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":371,"column":8},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":381,"column":8},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":395,"column":8},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":415,"column":8},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":425,"column":8},{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition","severity":5,"fixable":false,"type":"WARNING","line":444,"column":28},{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition","severity":5,"fixable":false,"type":"WARNING","line":461,"column":28},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":473,"column":8}]}}}
--- end ---
PHPCS run failed
$ vendor/bin/phpcbf
--- stdout ---
PHPCBF RESULT SUMMARY
----------------------------------------------------------------------
FILE FIXED REMAINING
----------------------------------------------------------------------
/src/repo/includes/specials/PagesListOptions.php 1 4
/src/repo/includes/PagesList.php 4 23
----------------------------------------------------------------------
A TOTAL OF 5 ERRORS WERE FIXED IN 2 FILES
----------------------------------------------------------------------
Time: 437ms; Memory: 8MB
--- end ---
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":27,"warnings":25,"fixable":0},"files":{"\/src\/repo\/includes\/specials\/SpecialPagesListQueryPage.php":{"errors":12,"warnings":3,"messages":[{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":50,"column":5},{"message":"Visibility must be declared on method \"isExpensive\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":50,"column":5},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":54,"column":5},{"message":"Visibility must be declared on method \"getQueryInfo\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":54,"column":5},{"message":"Visibility must be declared on method \"usesTimestamps\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":58,"column":5},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":62,"column":5},{"message":"Visibility must be declared on method \"getOrderFields\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":62,"column":5},{"message":"Visibility must be declared on method \"sortDescending\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":66,"column":5},{"message":"@global is not a valid function annotation","source":"MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":80,"column":8},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":82,"column":8},{"message":"Visibility must be declared on method \"formatResult\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":85,"column":5},{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListShowLastUser","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":86,"column":16},{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListShowLastModification","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":86,"column":42},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":92,"column":12},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":96,"column":12}]},"\/src\/repo\/PagesList.magic.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/PagesList.i18n.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/specials\/SpecialPagesList.php":{"errors":0,"warnings":3,"messages":[{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListUseAjax","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":25,"column":16},{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListShowLastUser","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":45,"column":16},{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListShowLastModification","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":45,"column":42}]},"\/src\/repo\/includes\/api\/PagesListAPI.php":{"errors":2,"warnings":2,"messages":[{"message":"@global is not a valid function annotation","source":"MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":23,"column":8},{"message":"@global is not a valid function annotation","source":"MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":24,"column":8},{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListShowLastUser","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":28,"column":16},{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListShowLastModification","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":28,"column":42}]},"\/src\/repo\/includes\/PagesListHooks.php":{"errors":3,"warnings":0,"messages":[{"message":"@global is not a valid function annotation","source":"MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":16,"column":8},{"message":"@global is not a valid function annotation","source":"MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":69,"column":8},{"message":"@global is not a valid function annotation","source":"MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":70,"column":8}]},"\/src\/repo\/includes\/specials\/PagesListOptions.php":{"errors":3,"warnings":1,"messages":[{"message":"Visibility must be declared on method \"__construct\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":24,"column":5},{"message":"@global is not a valid function annotation","source":"MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":37,"column":8},{"message":"Should use function $this->getConfig()->get() rather than global $wgScript","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":41,"column":16},{"message":"Visibility must be declared on method \"getExtraOptions\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":93,"column":5}]},"\/src\/repo\/includes\/PagesList.php":{"errors":7,"warnings":16,"messages":[{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":14,"column":5},{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":19,"column":5},{"message":"Visibility must be declared on method \"__construct\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":88,"column":5},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":118,"column":34},{"message":"Visibility must be declared on method \"getQueryInfo\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":154,"column":5},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":190,"column":25},{"message":"Visibility must be declared on method \"getNamespaceCond\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":210,"column":5},{"message":"Visibility must be declared on method \"getSqlComment\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":235,"column":5},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":239,"column":5},{"message":"Visibility must be declared on method \"getList\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":239,"column":5},{"message":"There must be a comment when fall-through is intentional in a non-empty case body","source":"PSR2.ControlStructures.SwitchDeclaration.TerminatingComment","severity":5,"fixable":false,"type":"ERROR","line":242,"column":13},{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListUseAjax","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":245,"column":24},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":273,"column":8},{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition","severity":5,"fixable":false,"type":"WARNING","line":317,"column":32},{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition","severity":5,"fixable":false,"type":"WARNING","line":345,"column":25},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":371,"column":8},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":381,"column":8},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":395,"column":8},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":415,"column":8},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":425,"column":8},{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition","severity":5,"fixable":false,"type":"WARNING","line":444,"column":28},{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition","severity":5,"fixable":false,"type":"WARNING","line":461,"column":28},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":473,"column":8}]}}}
--- end ---
$ git checkout .phpcs.xml
--- stderr ---
Updated 1 path from the index
--- stdout ---
--- end ---
$ /usr/bin/composer install
--- stderr ---
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating autoload files
14 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
--- end ---
$ /usr/bin/composer test
--- stderr ---
> parallel-lint . --exclude vendor --exclude node_modules
> minus-x check .
> phpcs -sp --cache
--- stdout ---
PHP 8.2.20 | 10 parallel jobs
.................................... 36/36 (100%)
Checked 36 files in 0.2 seconds
No syntax error found
MinusX
======
Processing /src/repo...
.............................................................
....................................
All good!
........ 8 / 8 (100%)
Time: 119ms; Memory: 8MB
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 428,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 428
}
}
}
--- end ---
$ package-lock-lint package-lock.json
--- stdout ---
Checking package-lock.json
--- end ---
build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
$ git add .
--- stdout ---
--- end ---
$ git commit -F /tmp/tmpkylvodmb
--- stdout ---
[master 3b33828] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
3 files changed, 4 insertions(+), 4 deletions(-)
--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From 3b3382859bdb4cd06e161dd387f0f0fbc3653882 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Sat, 2 Nov 2024 03:05:38 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
Change-Id: Icadd6d1d7adba20a8622dc1ad499fa553978c755
---
composer.json | 2 +-
includes/PagesList.php | 4 ++--
includes/specials/PagesListOptions.php | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/composer.json b/composer.json
index 25415a8..64d8cd7 100644
--- a/composer.json
+++ b/composer.json
@@ -1,6 +1,6 @@
{
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "44.0.0",
+ "mediawiki/mediawiki-codesniffer": "45.0.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
"php-parallel-lint/php-parallel-lint": "1.4.0"
diff --git a/includes/PagesList.php b/includes/PagesList.php
index 9d55800..e59f960 100644
--- a/includes/PagesList.php
+++ b/includes/PagesList.php
@@ -86,7 +86,7 @@ class PagesList extends ContextSource {
* @param IContextSource|null $context
*/
function __construct( IDatabase $db, $namespace = null, $nsInvert = false, $associated = false,
- Title $category = null, Title $basePage = null, IContextSource $context = null ) {
+ ?Title $category = null, ?Title $basePage = null, ?IContextSource $context = null ) {
if ( $context ) {
$this->setContext( $context );
}
@@ -236,7 +236,7 @@ class PagesList extends ContextSource {
return get_class( $this );
}
- function getList( $format, $showLastUser, $showLastModification, OutputPage $out = null ) {
+ function getList( $format, $showLastUser, $showLastModification, ?OutputPage $out = null ) {
$useAjax = false;
switch ( $format ) {
case 'datatable':
diff --git a/includes/specials/PagesListOptions.php b/includes/specials/PagesListOptions.php
index 81a68a8..7d2385a 100644
--- a/includes/specials/PagesListOptions.php
+++ b/includes/specials/PagesListOptions.php
@@ -21,7 +21,7 @@ class PagesListOptions extends ContextSource {
* @param FormOptions $opts
* @param IContextSource|null $context
*/
- function __construct( Title $pageTitle, FormOptions $opts, IContextSource $context = null ) {
+ function __construct( Title $pageTitle, FormOptions $opts, ?IContextSource $context = null ) {
$this->pageTitle = $pageTitle;
$this->opts = $opts;
--
2.39.2
--- end ---