$ date
--- stdout ---
Fri Sep 20 03:00:58 UTC 2024
--- end ---
$ git clone file:///srv/git/mediawiki-extensions-PagesList.git repo --depth=1 -b master
--- stderr ---
Cloning into 'repo'...
--- stdout ---
--- end ---
$ git config user.name libraryupgrader
--- stdout ---
--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---
--- end ---
$ git submodule update --init
--- stderr ---
Submodule 'modules/DataTables' (https://github.com/DataTables/DataTables.git) registered for path 'modules/DataTables'
Cloning into '/src/repo/modules/DataTables'...
--- stdout ---
Submodule path 'modules/DataTables': checked out '24b2d114606725d05c1e79155284babc47d728ca'
--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.
--- end ---
$ git show-ref refs/heads/master
--- stdout ---
a3d7e17e1cd6f9c71c7e3f82f91aaa1314bcd40f refs/heads/master
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {
"micromatch": {
"name": "micromatch",
"severity": "moderate",
"isDirect": false,
"via": [
{
"source": 1098681,
"name": "micromatch",
"dependency": "micromatch",
"title": "Regular Expression Denial of Service (ReDoS) in micromatch",
"url": "https://github.com/advisories/GHSA-952p-6rrq-rcjv",
"severity": "moderate",
"cwe": [
"CWE-1333"
],
"cvss": {
"score": 5.3,
"vectorString": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:L"
},
"range": "<4.0.8"
}
],
"effects": [],
"range": "<4.0.8",
"nodes": [
"node_modules/micromatch"
],
"fixAvailable": true
}
},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 1,
"high": 0,
"critical": 0,
"total": 1
},
"dependencies": {
"prod": 1,
"dev": 428,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 428
}
}
}
--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 21 installs, 0 updates, 0 removals
- Locking composer/semver (3.4.0)
- Locking composer/spdx-licenses (1.5.8)
- Locking dealerdirect/phpcodesniffer-composer-installer (v1.0.0)
- Locking mediawiki/mediawiki-codesniffer (v43.0.0)
- Locking mediawiki/minus-x (1.1.3)
- Locking php-parallel-lint/php-console-color (v1.0.1)
- Locking php-parallel-lint/php-console-highlighter (v1.0.0)
- Locking php-parallel-lint/php-parallel-lint (v1.4.0)
- Locking phpcsstandards/phpcsextra (1.1.2)
- Locking phpcsstandards/phpcsutils (1.0.9)
- Locking psr/container (2.0.2)
- Locking squizlabs/php_codesniffer (3.8.1)
- Locking symfony/console (v7.1.4)
- Locking symfony/deprecation-contracts (v3.5.0)
- Locking symfony/polyfill-ctype (v1.31.0)
- Locking symfony/polyfill-intl-grapheme (v1.31.0)
- Locking symfony/polyfill-intl-normalizer (v1.31.0)
- Locking symfony/polyfill-mbstring (v1.31.0)
- Locking symfony/polyfill-php80 (v1.31.0)
- Locking symfony/service-contracts (v3.5.0)
- Locking symfony/string (v7.1.4)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 21 installs, 0 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Installing squizlabs/php_codesniffer (3.8.1): Extracting archive
- Installing dealerdirect/phpcodesniffer-composer-installer (v1.0.0): Extracting archive
- Installing symfony/polyfill-php80 (v1.31.0): Extracting archive
- Installing phpcsstandards/phpcsutils (1.0.9): Extracting archive
- Installing phpcsstandards/phpcsextra (1.1.2): Extracting archive
- Installing symfony/polyfill-mbstring (v1.31.0): Extracting archive
- Installing composer/spdx-licenses (1.5.8): Extracting archive
- Installing composer/semver (3.4.0): Extracting archive
- Installing mediawiki/mediawiki-codesniffer (v43.0.0): Extracting archive
- Installing symfony/polyfill-intl-normalizer (v1.31.0): Extracting archive
- Installing symfony/polyfill-intl-grapheme (v1.31.0): Extracting archive
- Installing symfony/polyfill-ctype (v1.31.0): Extracting archive
- Installing symfony/string (v7.1.4): Extracting archive
- Installing symfony/deprecation-contracts (v3.5.0): Extracting archive
- Installing psr/container (2.0.2): Extracting archive
- Installing symfony/service-contracts (v3.5.0): Extracting archive
- Installing symfony/console (v7.1.4): Extracting archive
- Installing mediawiki/minus-x (1.1.3): Extracting archive
- Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
- Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
- Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive
0/19 [>---------------------------] 0%
19/19 [============================] 100%
Generating autoload files
13 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Upgrading c:mediawiki/mediawiki-codesniffer from 43.0.0 -> 44.0.0
$ /usr/bin/composer update
--- stderr ---
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 5 updates, 0 removals
- Upgrading composer/semver (3.4.0 => 3.4.2)
- Upgrading mediawiki/mediawiki-codesniffer (v43.0.0 => v44.0.0)
- Upgrading phpcsstandards/phpcsextra (1.1.2 => 1.2.1)
- Upgrading phpcsstandards/phpcsutils (1.0.9 => 1.0.11)
- Upgrading squizlabs/php_codesniffer (3.8.1 => 3.9.0)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 5 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Upgrading squizlabs/php_codesniffer (3.8.1 => 3.9.0): Extracting archive
- Upgrading phpcsstandards/phpcsutils (1.0.9 => 1.0.11): Extracting archive
- Upgrading phpcsstandards/phpcsextra (1.1.2 => 1.2.1): Extracting archive
- Upgrading composer/semver (3.4.0 => 3.4.2): Extracting archive
- Upgrading mediawiki/mediawiki-codesniffer (v43.0.0 => v44.0.0): Extracting archive
0/5 [>---------------------------] 0%
4/5 [======================>-----] 80%
5/5 [============================] 100%
Generating autoload files
14 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Previously failing phpcs rules: {'Squiz.Scope.MethodScope.Missing', 'PSR12.Properties.ConstantVisibility.NotFound', 'Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition', 'MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage', 'MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation', 'PSR2.ControlStructures.SwitchDeclaration.TerminatingComment', 'MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment', 'MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam', 'MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic'}
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":27,"warnings":25,"fixable":0},"files":{"\/src\/repo\/includes\/specials\/SpecialPagesListQueryPage.php":{"errors":12,"warnings":3,"messages":[{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":46,"column":5},{"message":"Visibility must be declared on method \"isExpensive\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":46,"column":5},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":50,"column":5},{"message":"Visibility must be declared on method \"getQueryInfo\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":50,"column":5},{"message":"Visibility must be declared on method \"usesTimestamps\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":54,"column":5},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":58,"column":5},{"message":"Visibility must be declared on method \"getOrderFields\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":58,"column":5},{"message":"Visibility must be declared on method \"sortDescending\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":62,"column":5},{"message":"@global is not a valid function annotation","source":"MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":76,"column":8},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":78,"column":8},{"message":"Visibility must be declared on method \"formatResult\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":81,"column":5},{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListShowLastUser","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":82,"column":16},{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListShowLastModification","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":82,"column":42},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":88,"column":12},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":92,"column":12}]},"\/src\/repo\/PagesList.i18n.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/PagesList.magic.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/api\/PagesListAPI.php":{"errors":2,"warnings":2,"messages":[{"message":"@global is not a valid function annotation","source":"MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":21,"column":8},{"message":"@global is not a valid function annotation","source":"MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":22,"column":8},{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListShowLastUser","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":26,"column":16},{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListShowLastModification","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":26,"column":42}]},"\/src\/repo\/includes\/specials\/SpecialPagesList.php":{"errors":0,"warnings":3,"messages":[{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListUseAjax","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":23,"column":16},{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListShowLastUser","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":42,"column":16},{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListShowLastModification","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":42,"column":42}]},"\/src\/repo\/includes\/PagesListHooks.php":{"errors":3,"warnings":0,"messages":[{"message":"@global is not a valid function annotation","source":"MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":16,"column":8},{"message":"@global is not a valid function annotation","source":"MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":69,"column":8},{"message":"@global is not a valid function annotation","source":"MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":70,"column":8}]},"\/src\/repo\/includes\/specials\/PagesListOptions.php":{"errors":3,"warnings":1,"messages":[{"message":"Visibility must be declared on method \"__construct\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":24,"column":5},{"message":"@global is not a valid function annotation","source":"MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":37,"column":8},{"message":"Should use function $this->getConfig()->get() rather than global $wgScript","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":41,"column":16},{"message":"Visibility must be declared on method \"getExtraOptions\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":93,"column":5}]},"\/src\/repo\/includes\/PagesList.php":{"errors":7,"warnings":16,"messages":[{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":14,"column":5},{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":19,"column":5},{"message":"Visibility must be declared on method \"__construct\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":88,"column":5},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":118,"column":34},{"message":"Visibility must be declared on method \"getQueryInfo\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":154,"column":5},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":190,"column":25},{"message":"Visibility must be declared on method \"getNamespaceCond\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":210,"column":5},{"message":"Visibility must be declared on method \"getSqlComment\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":235,"column":5},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":239,"column":5},{"message":"Visibility must be declared on method \"getList\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":239,"column":5},{"message":"There must be a comment when fall-through is intentional in a non-empty case body","source":"PSR2.ControlStructures.SwitchDeclaration.TerminatingComment","severity":5,"fixable":false,"type":"ERROR","line":242,"column":13},{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListUseAjax","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":245,"column":24},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":273,"column":8},{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition","severity":5,"fixable":false,"type":"WARNING","line":317,"column":32},{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition","severity":5,"fixable":false,"type":"WARNING","line":345,"column":25},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":371,"column":8},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":381,"column":8},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":395,"column":8},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":415,"column":8},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":425,"column":8},{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition","severity":5,"fixable":false,"type":"WARNING","line":444,"column":28},{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition","severity":5,"fixable":false,"type":"WARNING","line":461,"column":28},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":473,"column":8}]}}}
--- end ---
PHPCS run failed
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":27,"warnings":25,"fixable":0},"files":{"\/src\/repo\/includes\/specials\/SpecialPagesListQueryPage.php":{"errors":12,"warnings":3,"messages":[{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":46,"column":5},{"message":"Visibility must be declared on method \"isExpensive\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":46,"column":5},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":50,"column":5},{"message":"Visibility must be declared on method \"getQueryInfo\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":50,"column":5},{"message":"Visibility must be declared on method \"usesTimestamps\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":54,"column":5},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":58,"column":5},{"message":"Visibility must be declared on method \"getOrderFields\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":58,"column":5},{"message":"Visibility must be declared on method \"sortDescending\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":62,"column":5},{"message":"@global is not a valid function annotation","source":"MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":76,"column":8},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":78,"column":8},{"message":"Visibility must be declared on method \"formatResult\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":81,"column":5},{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListShowLastUser","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":82,"column":16},{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListShowLastModification","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":82,"column":42},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":88,"column":12},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":92,"column":12}]},"\/src\/repo\/PagesList.i18n.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/PagesList.magic.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/specials\/SpecialPagesList.php":{"errors":0,"warnings":3,"messages":[{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListUseAjax","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":23,"column":16},{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListShowLastUser","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":42,"column":16},{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListShowLastModification","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":42,"column":42}]},"\/src\/repo\/includes\/api\/PagesListAPI.php":{"errors":2,"warnings":2,"messages":[{"message":"@global is not a valid function annotation","source":"MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":21,"column":8},{"message":"@global is not a valid function annotation","source":"MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":22,"column":8},{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListShowLastUser","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":26,"column":16},{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListShowLastModification","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":26,"column":42}]},"\/src\/repo\/includes\/PagesListHooks.php":{"errors":3,"warnings":0,"messages":[{"message":"@global is not a valid function annotation","source":"MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":16,"column":8},{"message":"@global is not a valid function annotation","source":"MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":69,"column":8},{"message":"@global is not a valid function annotation","source":"MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":70,"column":8}]},"\/src\/repo\/includes\/specials\/PagesListOptions.php":{"errors":3,"warnings":1,"messages":[{"message":"Visibility must be declared on method \"__construct\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":24,"column":5},{"message":"@global is not a valid function annotation","source":"MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation","severity":5,"fixable":false,"type":"ERROR","line":37,"column":8},{"message":"Should use function $this->getConfig()->get() rather than global $wgScript","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":41,"column":16},{"message":"Visibility must be declared on method \"getExtraOptions\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":93,"column":5}]},"\/src\/repo\/includes\/PagesList.php":{"errors":7,"warnings":16,"messages":[{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":14,"column":5},{"message":"Visibility must be declared on all constants if your project supports PHP 7.1 or later","source":"PSR12.Properties.ConstantVisibility.NotFound","severity":5,"fixable":false,"type":"WARNING","line":19,"column":5},{"message":"Visibility must be declared on method \"__construct\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":88,"column":5},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":118,"column":34},{"message":"Visibility must be declared on method \"getQueryInfo\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":154,"column":5},{"message":"Comments should start on new line.","source":"MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment","severity":5,"fixable":false,"type":"WARNING","line":190,"column":25},{"message":"Visibility must be declared on method \"getNamespaceCond\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":210,"column":5},{"message":"Visibility must be declared on method \"getSqlComment\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":235,"column":5},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic","severity":5,"fixable":false,"type":"ERROR","line":239,"column":5},{"message":"Visibility must be declared on method \"getList\"","source":"Squiz.Scope.MethodScope.Missing","severity":5,"fixable":false,"type":"ERROR","line":239,"column":5},{"message":"There must be a comment when fall-through is intentional in a non-empty case body","source":"PSR2.ControlStructures.SwitchDeclaration.TerminatingComment","severity":5,"fixable":false,"type":"ERROR","line":242,"column":13},{"message":"Should use function $this->getConfig()->get() rather than global $wgPagesListUseAjax","source":"MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage","severity":5,"fixable":false,"type":"WARNING","line":245,"column":24},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":273,"column":8},{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition","severity":5,"fixable":false,"type":"WARNING","line":317,"column":32},{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition","severity":5,"fixable":false,"type":"WARNING","line":345,"column":25},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":371,"column":8},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":381,"column":8},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":395,"column":8},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":415,"column":8},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":425,"column":8},{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition","severity":5,"fixable":false,"type":"WARNING","line":444,"column":28},{"message":"Variable assignment found within a condition. Did you mean to do a comparison ?","source":"Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition","severity":5,"fixable":false,"type":"WARNING","line":461,"column":28},{"message":"`object` should rarely be used as a typehint. If more specific types are known, list them. If only plain anonymous objects are expected, use `stdClass`. If the intent is indeed to allow any object, mark it with a \/\/ phpcs:\u2026 comment or set this rule's <severity> to 0.","source":"MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam","severity":5,"fixable":false,"type":"WARNING","line":473,"column":8}]}}}
--- end ---
$ git checkout .phpcs.xml
--- stderr ---
Updated 1 path from the index
--- stdout ---
--- end ---
$ /usr/bin/composer install
--- stderr ---
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating autoload files
14 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
--- end ---
$ /usr/bin/composer test
--- stderr ---
> parallel-lint . --exclude vendor --exclude node_modules
> minus-x check .
> phpcs -sp --cache
--- stdout ---
PHP 8.2.20 | 10 parallel jobs
.................................... 36/36 (100%)
Checked 36 files in 0.2 seconds
No syntax error found
MinusX
======
Processing /src/repo...
.............................................................
....................................
All good!
........ 8 / 8 (100%)
Time: 126ms; Memory: 8MB
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {
"micromatch": {
"name": "micromatch",
"severity": "moderate",
"isDirect": false,
"via": [
{
"source": 1098681,
"name": "micromatch",
"dependency": "micromatch",
"title": "Regular Expression Denial of Service (ReDoS) in micromatch",
"url": "https://github.com/advisories/GHSA-952p-6rrq-rcjv",
"severity": "moderate",
"cwe": [
"CWE-1333"
],
"cvss": {
"score": 5.3,
"vectorString": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:L"
},
"range": "<4.0.8"
}
],
"effects": [],
"range": "<4.0.8",
"nodes": [
"node_modules/micromatch"
],
"fixAvailable": true
}
},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 1,
"high": 0,
"critical": 0,
"total": 1
},
"dependencies": {
"prod": 1,
"dev": 428,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 428
}
}
}
--- end ---
Attempting to npm audit fix
$ /usr/bin/npm audit fix --dry-run --only=dev --json
--- stderr ---
npm WARN invalid config only="dev" set in command line options
npm WARN invalid config Must be one of: null, prod, production
--- stdout ---
{
"added": 428,
"removed": 0,
"changed": 0,
"audited": 429,
"funding": 90,
"audit": {
"auditReportVersion": 2,
"vulnerabilities": {
"micromatch": {
"name": "micromatch",
"severity": "moderate",
"isDirect": false,
"via": [
{
"source": 1098681,
"name": "micromatch",
"dependency": "micromatch",
"title": "Regular Expression Denial of Service (ReDoS) in micromatch",
"url": "https://github.com/advisories/GHSA-952p-6rrq-rcjv",
"severity": "moderate",
"cwe": [
"CWE-1333"
],
"cvss": {
"score": 5.3,
"vectorString": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:L"
},
"range": "<4.0.8"
}
],
"effects": [],
"range": "<4.0.8",
"nodes": [
""
],
"fixAvailable": true
}
},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 1,
"high": 0,
"critical": 0,
"total": 1
},
"dependencies": {
"prod": 1,
"dev": 428,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 428
}
}
}
}
--- end ---
{"added": 428, "removed": 0, "changed": 0, "audited": 429, "funding": 90, "audit": {"auditReportVersion": 2, "vulnerabilities": {"micromatch": {"name": "micromatch", "severity": "moderate", "isDirect": false, "via": [{"source": 1098681, "name": "micromatch", "dependency": "micromatch", "title": "Regular Expression Denial of Service (ReDoS) in micromatch", "url": "https://github.com/advisories/GHSA-952p-6rrq-rcjv", "severity": "moderate", "cwe": ["CWE-1333"], "cvss": {"score": 5.3, "vectorString": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:L"}, "range": "<4.0.8"}], "effects": [], "range": "<4.0.8", "nodes": [""], "fixAvailable": true}}, "metadata": {"vulnerabilities": {"info": 0, "low": 0, "moderate": 1, "high": 0, "critical": 0, "total": 1}, "dependencies": {"prod": 1, "dev": 428, "optional": 0, "peer": 1, "peerOptional": 0, "total": 428}}}}
$ /usr/bin/npm audit fix --only=dev
--- stderr ---
npm WARN invalid config only="dev" set in command line options
npm WARN invalid config Must be one of: null, prod, production
--- stdout ---
added 428 packages, and audited 429 packages in 4s
90 packages are looking for funding
run `npm fund` for details
found 0 vulnerabilities
--- end ---
Verifying that tests still pass
$ /usr/bin/npm ci
--- stdout ---
added 428 packages, and audited 429 packages in 5s
90 packages are looking for funding
run `npm fund` for details
found 0 vulnerabilities
--- end ---
$ /usr/bin/npm test
--- stdout ---
> test
> grunt test
Running "eslint:all" (eslint) task
Running "banana:PagesList" (banana) task
>> 1 message directory checked.
Running "stylelint:all" (stylelint) task
>> Linted 0 files without errors
Done.
--- end ---
{"1098681": {"source": 1098681, "name": "micromatch", "dependency": "micromatch", "title": "Regular Expression Denial of Service (ReDoS) in micromatch", "url": "https://github.com/advisories/GHSA-952p-6rrq-rcjv", "severity": "moderate", "cwe": ["CWE-1333"], "cvss": {"score": 5.3, "vectorString": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:L"}, "range": "<4.0.8"}}
Upgrading n:micromatch from 4.0.7 -> 4.0.8
$ package-lock-lint package-lock.json
--- stdout ---
Checking package-lock.json
--- end ---
build: Updating dependencies
composer:
* mediawiki/mediawiki-codesniffer: 43.0.0 → 44.0.0
npm:
* micromatch: 4.0.7 → 4.0.8
* https://github.com/advisories/GHSA-952p-6rrq-rcjv
$ git add .
--- stdout ---
--- end ---
$ git commit -F /tmp/tmpv5p6t9ou
--- stdout ---
[master 3c48f5f] build: Updating dependencies
2 files changed, 7 insertions(+), 7 deletions(-)
--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From 3c48f5f50faecf19878ad3506323931208d21968 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Fri, 20 Sep 2024 03:01:28 +0000
Subject: [PATCH] build: Updating dependencies
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
composer:
* mediawiki/mediawiki-codesniffer: 43.0.0 → 44.0.0
npm:
* micromatch: 4.0.7 → 4.0.8
* https://github.com/advisories/GHSA-952p-6rrq-rcjv
Change-Id: I980bfea7b246d676fe284c3b067d5ef94e22a1dc
---
composer.json | 2 +-
package-lock.json | 12 ++++++------
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/composer.json b/composer.json
index 1962b85..25415a8 100644
--- a/composer.json
+++ b/composer.json
@@ -1,6 +1,6 @@
{
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "43.0.0",
+ "mediawiki/mediawiki-codesniffer": "44.0.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
"php-parallel-lint/php-parallel-lint": "1.4.0"
diff --git a/package-lock.json b/package-lock.json
index a5e4f83..8015f72 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -3299,9 +3299,9 @@
}
},
"node_modules/micromatch": {
- "version": "4.0.7",
- "resolved": "https://registry.npmjs.org/micromatch/-/micromatch-4.0.7.tgz",
- "integrity": "sha512-LPP/3KorzCwBxfeUuZmaR6bG2kdeHSbe0P2tY3FLRU4vYrjYz5hI4QZwV0njUx3jeuKe67YukQ1LSPZBKDqO/Q==",
+ "version": "4.0.8",
+ "resolved": "https://registry.npmjs.org/micromatch/-/micromatch-4.0.8.tgz",
+ "integrity": "sha512-PXwfBhYu0hBCPw8Dn0E+WDYb7af3dSLVWKi3HGv84IdF4TyFoC0ysxFd0Goxw7nSv4T/PzEJQxsYsEiFCKo2BA==",
"dev": true,
"dependencies": {
"braces": "^3.0.3",
@@ -7550,9 +7550,9 @@
"dev": true
},
"micromatch": {
- "version": "4.0.7",
- "resolved": "https://registry.npmjs.org/micromatch/-/micromatch-4.0.7.tgz",
- "integrity": "sha512-LPP/3KorzCwBxfeUuZmaR6bG2kdeHSbe0P2tY3FLRU4vYrjYz5hI4QZwV0njUx3jeuKe67YukQ1LSPZBKDqO/Q==",
+ "version": "4.0.8",
+ "resolved": "https://registry.npmjs.org/micromatch/-/micromatch-4.0.8.tgz",
+ "integrity": "sha512-PXwfBhYu0hBCPw8Dn0E+WDYb7af3dSLVWKi3HGv84IdF4TyFoC0ysxFd0Goxw7nSv4T/PzEJQxsYsEiFCKo2BA==",
"dev": true,
"requires": {
"braces": "^3.0.3",
--
2.39.2
--- end ---