From 361157cfddc0888c837d9d4fc6d15ca6cc7ccc21 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Fri, 29 Mar 2024 14:33:03 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 43.0.0
Change-Id: I43224ddfc8d88334c7c5ed4562e2df236fac5bae
---
composer.json | 7 ++++++-
tests/phpunit/HooksTest.php | 6 +++---
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/composer.json b/composer.json
index 7521f91..4d9f345 100644
--- a/composer.json
+++ b/composer.json
@@ -4,7 +4,7 @@
"type": "mediawiki-extension",
"license": "GPL-2.0-or-later",
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "41.0.0",
+ "mediawiki/mediawiki-codesniffer": "43.0.0",
"mediawiki/mediawiki-phan-config": "0.14.0",
"mediawiki/minus-x": "1.1.1",
"php-parallel-lint/php-console-highlighter": "1.0.0",
@@ -22,5 +22,10 @@
],
"phan": "phan -d . --long-progress-bar",
"phpcs": "phpcs -sp --cache"
+ },
+ "config": {
+ "allow-plugins": {
+ "dealerdirect/phpcodesniffer-composer-installer": true
+ }
}
}
diff --git a/tests/phpunit/HooksTest.php b/tests/phpunit/HooksTest.php
index 116a10f..3b539df 100644
--- a/tests/phpunit/HooksTest.php
+++ b/tests/phpunit/HooksTest.php
@@ -60,7 +60,7 @@ class HooksTest extends ApiTestCase {
* @covers ::onModifyMessageGroupStates
*/
public function testOnModifyMessageGroupStates_nonMatch() {
- list( $result ) = $this->doApiRequestWithToken( [
+ [ $result ] = $this->doApiRequestWithToken( [
'action' => 'groupreview',
'group' => self::NORMAL_MESSAGE_GROUP,
'language' => 'es',
@@ -82,7 +82,7 @@ class HooksTest extends ApiTestCase {
public function testOnModifyMessageGroupStates_matchDeny() {
$this->expectException( ApiUsageException::class );
$this->expectExceptionMessage( 'You don\'t have permission to manage message groups.' );
- list( $result ) = $this->doApiRequestWithToken( [
+ [ $result ] = $this->doApiRequestWithToken( [
'action' => 'groupreview',
'group' => self::FUNDRAISING_MESSAGE_GROUP,
'language' => 'es',
@@ -99,7 +99,7 @@ class HooksTest extends ApiTestCase {
global $wgFundraisingTranslateWorkflowPublishRight;
$this->setGroupPermissions( 'user', $wgFundraisingTranslateWorkflowPublishRight, true );
- list( $result ) = $this->doApiRequestWithToken( [
+ [ $result ] = $this->doApiRequestWithToken( [
'action' => 'groupreview',
'group' => self::FUNDRAISING_MESSAGE_GROUP,
'language' => 'es',
--
2.39.2
$ date
--- stdout ---
Fri Mar 29 14:32:53 UTC 2024
--- end ---
$ git clone file:///srv/git/mediawiki-extensions-FundraisingTranslateWorkflow.git repo --depth=1 -b master
--- stderr ---
Cloning into 'repo'...
--- stdout ---
--- end ---
$ git config user.name libraryupgrader
--- stdout ---
--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---
--- end ---
$ git submodule update --init
--- stdout ---
--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.
--- end ---
$ git show-ref refs/heads/master
--- stdout ---
0003c9a9374b13ed3ac505d99705832765a2dc24 refs/heads/master
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 306,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 306
}
}
}
--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 36 installs, 0 updates, 0 removals
- Locking composer/pcre (3.1.3)
- Locking composer/semver (3.3.2)
- Locking composer/spdx-licenses (1.5.8)
- Locking composer/xdebug-handler (3.0.4)
- Locking doctrine/deprecations (1.1.3)
- Locking felixfbecker/advanced-json-rpc (v3.2.1)
- Locking mediawiki/mediawiki-codesniffer (v41.0.0)
- Locking mediawiki/mediawiki-phan-config (0.14.0)
- Locking mediawiki/minus-x (1.1.1)
- Locking mediawiki/phan-taint-check-plugin (6.0.0)
- Locking microsoft/tolerant-php-parser (v0.1.2)
- Locking netresearch/jsonmapper (v4.4.1)
- Locking phan/phan (5.4.3)
- Locking php-parallel-lint/php-console-color (v1.0.1)
- Locking php-parallel-lint/php-console-highlighter (v1.0.0)
- Locking php-parallel-lint/php-parallel-lint (v1.3.2)
- Locking phpdocumentor/reflection-common (2.2.0)
- Locking phpdocumentor/reflection-docblock (5.3.0)
- Locking phpdocumentor/type-resolver (1.8.2)
- Locking phpstan/phpdoc-parser (1.27.0)
- Locking psr/container (2.0.2)
- Locking psr/log (2.0.0)
- Locking sabre/event (5.1.4)
- Locking squizlabs/php_codesniffer (3.7.2)
- Locking symfony/console (v5.4.36)
- Locking symfony/deprecation-contracts (v3.4.0)
- Locking symfony/polyfill-ctype (v1.29.0)
- Locking symfony/polyfill-intl-grapheme (v1.29.0)
- Locking symfony/polyfill-intl-normalizer (v1.29.0)
- Locking symfony/polyfill-mbstring (v1.29.0)
- Locking symfony/polyfill-php73 (v1.29.0)
- Locking symfony/polyfill-php80 (v1.29.0)
- Locking symfony/service-contracts (v3.4.1)
- Locking symfony/string (v6.4.4)
- Locking tysonandre/var_representation_polyfill (0.1.3)
- Locking webmozart/assert (1.11.0)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 36 installs, 0 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Installing composer/pcre (3.1.3): Extracting archive
- Installing symfony/polyfill-php80 (v1.29.0): Extracting archive
- Installing squizlabs/php_codesniffer (3.7.2): Extracting archive
- Installing symfony/polyfill-mbstring (v1.29.0): Extracting archive
- Installing composer/spdx-licenses (1.5.8): Extracting archive
- Installing composer/semver (3.3.2): Extracting archive
- Installing mediawiki/mediawiki-codesniffer (v41.0.0): Extracting archive
- Installing tysonandre/var_representation_polyfill (0.1.3): Extracting archive
- Installing symfony/polyfill-intl-normalizer (v1.29.0): Extracting archive
- Installing symfony/polyfill-intl-grapheme (v1.29.0): Extracting archive
- Installing symfony/polyfill-ctype (v1.29.0): Extracting archive
- Installing symfony/string (v6.4.4): Extracting archive
- Installing psr/container (2.0.2): Extracting archive
- Installing symfony/service-contracts (v3.4.1): Extracting archive
- Installing symfony/polyfill-php73 (v1.29.0): Extracting archive
- Installing symfony/deprecation-contracts (v3.4.0): Extracting archive
- Installing symfony/console (v5.4.36): Extracting archive
- Installing sabre/event (5.1.4): Extracting archive
- Installing netresearch/jsonmapper (v4.4.1): Extracting archive
- Installing microsoft/tolerant-php-parser (v0.1.2): Extracting archive
- Installing webmozart/assert (1.11.0): Extracting archive
- Installing phpstan/phpdoc-parser (1.27.0): Extracting archive
- Installing phpdocumentor/reflection-common (2.2.0): Extracting archive
- Installing doctrine/deprecations (1.1.3): Extracting archive
- Installing phpdocumentor/type-resolver (1.8.2): Extracting archive
- Installing phpdocumentor/reflection-docblock (5.3.0): Extracting archive
- Installing felixfbecker/advanced-json-rpc (v3.2.1): Extracting archive
- Installing psr/log (2.0.0): Extracting archive
- Installing composer/xdebug-handler (3.0.4): Extracting archive
- Installing phan/phan (5.4.3): Extracting archive
- Installing mediawiki/phan-taint-check-plugin (6.0.0): Extracting archive
- Installing mediawiki/mediawiki-phan-config (0.14.0): Extracting archive
- Installing mediawiki/minus-x (1.1.1): Extracting archive
- Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
- Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
- Installing php-parallel-lint/php-parallel-lint (v1.3.2): Extracting archive
0/36 [>---------------------------] 0%
18/36 [==============>-------------] 50%
28/36 [=====================>------] 77%
36/36 [============================] 100%
3 package suggestions were added by new dependencies, use `composer suggest` to see details.
Generating autoload files
15 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
--- end ---
Upgrading c:mediawiki/mediawiki-codesniffer from 41.0.0 -> 43.0.0
$ /usr/bin/composer update
--- stderr ---
Loading composer repositories with package information
Updating dependencies
Lock file operations: 3 installs, 3 updates, 0 removals
- Upgrading composer/semver (3.3.2 => 3.4.0)
- Locking dealerdirect/phpcodesniffer-composer-installer (v1.0.0)
- Upgrading mediawiki/mediawiki-codesniffer (v41.0.0 => v43.0.0)
- Locking phpcsstandards/phpcsextra (1.1.2)
- Locking phpcsstandards/phpcsutils (1.0.9)
- Upgrading squizlabs/php_codesniffer (3.7.2 => 3.8.1)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 3 installs, 3 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Upgrading squizlabs/php_codesniffer (3.7.2 => 3.8.1): Extracting archive
- Installing dealerdirect/phpcodesniffer-composer-installer (v1.0.0): Extracting archive
- Installing phpcsstandards/phpcsutils (1.0.9): Extracting archive
- Installing phpcsstandards/phpcsextra (1.1.2): Extracting archive
- Upgrading composer/semver (3.3.2 => 3.4.0): Extracting archive
- Upgrading mediawiki/mediawiki-codesniffer (v41.0.0 => v43.0.0): Extracting archive
0/4 [>---------------------------] 0%
4/4 [============================] 100%
Generating autoload files
16 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
set()
Tests fail!
$ vendor/bin/phpcbf
--- stdout ---
PHPCBF RESULT SUMMARY
----------------------------------------------------------------------
FILE FIXED REMAINING
----------------------------------------------------------------------
/src/repo/tests/phpunit/HooksTest.php 3 0
----------------------------------------------------------------------
A TOTAL OF 3 ERRORS WERE FIXED IN 1 FILE
----------------------------------------------------------------------
Time: 118ms; Memory: 6MB
--- end ---
$ git checkout .phpcs.xml
--- stderr ---
Updated 1 path from the index
--- stdout ---
--- end ---
$ /usr/bin/composer install
--- stderr ---
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating autoload files
16 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
--- end ---
$ /usr/bin/composer test
--- stderr ---
> parallel-lint . --exclude vendor --exclude node_modules
> phpcs -sp --cache
> minus-x check .
--- stdout ---
PHP 8.2.7 | 10 parallel jobs
... 3/3 (100 %)
Checked 3 files in 0.1 seconds
No syntax error found
... 3 / 3 (100%)
Time: 103ms; Memory: 14MB
MinusX
======
Processing /src/repo...
..................................................
All good!
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 306,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 306
}
}
}
--- end ---
$ package-lock-lint package-lock.json
--- stdout ---
Checking package-lock.json
--- end ---
build: Updating mediawiki/mediawiki-codesniffer to 43.0.0
$ git add .
--- stdout ---
--- end ---
$ git commit -F /tmp/tmpgh_d429u
--- stdout ---
[master 361157c] build: Updating mediawiki/mediawiki-codesniffer to 43.0.0
2 files changed, 9 insertions(+), 4 deletions(-)
--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From 361157cfddc0888c837d9d4fc6d15ca6cc7ccc21 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Fri, 29 Mar 2024 14:33:03 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 43.0.0
Change-Id: I43224ddfc8d88334c7c5ed4562e2df236fac5bae
---
composer.json | 7 ++++++-
tests/phpunit/HooksTest.php | 6 +++---
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/composer.json b/composer.json
index 7521f91..4d9f345 100644
--- a/composer.json
+++ b/composer.json
@@ -4,7 +4,7 @@
"type": "mediawiki-extension",
"license": "GPL-2.0-or-later",
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "41.0.0",
+ "mediawiki/mediawiki-codesniffer": "43.0.0",
"mediawiki/mediawiki-phan-config": "0.14.0",
"mediawiki/minus-x": "1.1.1",
"php-parallel-lint/php-console-highlighter": "1.0.0",
@@ -22,5 +22,10 @@
],
"phan": "phan -d . --long-progress-bar",
"phpcs": "phpcs -sp --cache"
+ },
+ "config": {
+ "allow-plugins": {
+ "dealerdirect/phpcodesniffer-composer-installer": true
+ }
}
}
diff --git a/tests/phpunit/HooksTest.php b/tests/phpunit/HooksTest.php
index 116a10f..3b539df 100644
--- a/tests/phpunit/HooksTest.php
+++ b/tests/phpunit/HooksTest.php
@@ -60,7 +60,7 @@ class HooksTest extends ApiTestCase {
* @covers ::onModifyMessageGroupStates
*/
public function testOnModifyMessageGroupStates_nonMatch() {
- list( $result ) = $this->doApiRequestWithToken( [
+ [ $result ] = $this->doApiRequestWithToken( [
'action' => 'groupreview',
'group' => self::NORMAL_MESSAGE_GROUP,
'language' => 'es',
@@ -82,7 +82,7 @@ class HooksTest extends ApiTestCase {
public function testOnModifyMessageGroupStates_matchDeny() {
$this->expectException( ApiUsageException::class );
$this->expectExceptionMessage( 'You don\'t have permission to manage message groups.' );
- list( $result ) = $this->doApiRequestWithToken( [
+ [ $result ] = $this->doApiRequestWithToken( [
'action' => 'groupreview',
'group' => self::FUNDRAISING_MESSAGE_GROUP,
'language' => 'es',
@@ -99,7 +99,7 @@ class HooksTest extends ApiTestCase {
global $wgFundraisingTranslateWorkflowPublishRight;
$this->setGroupPermissions( 'user', $wgFundraisingTranslateWorkflowPublishRight, true );
- list( $result ) = $this->doApiRequestWithToken( [
+ [ $result ] = $this->doApiRequestWithToken( [
'action' => 'groupreview',
'group' => self::FUNDRAISING_MESSAGE_GROUP,
'language' => 'es',
--
2.39.2
--- end ---