This run took 43 seconds.
From 11ace460744649c5ec2655f1490b294aa6e418de Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Tue, 9 Nov 2021 00:41:34 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 38.0.0
Additional changes:
* eslint: Added `wikimedia/mediawiki` profile (T262222).
Change-Id: I9778c5cb0cfb01b13a1fc8fcb71cdbc7e1ad359c
---
.eslintrc.json | 3 ++-
composer.json | 2 +-
tests/phpunit/api/ApiManageMessageGroupsTest.php | 4 ++--
3 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/.eslintrc.json b/.eslintrc.json
index 04f9da7..6acf306 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -1,6 +1,7 @@
{
"root": true,
"extends": [
- "wikimedia/server"
+ "wikimedia/server",
+ "wikimedia/mediawiki"
]
}
diff --git a/composer.json b/composer.json
index 61b2d46..ac886d7 100644
--- a/composer.json
+++ b/composer.json
@@ -54,7 +54,7 @@
"mustangostang/spyc": "^0.6.3"
},
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "37.0.0",
+ "mediawiki/mediawiki-codesniffer": "38.0.0",
"mediawiki/mediawiki-phan-config": "0.11.0",
"mediawiki/minus-x": "1.1.1",
"php-parallel-lint/php-console-highlighter": "0.5.0",
diff --git a/tests/phpunit/api/ApiManageMessageGroupsTest.php b/tests/phpunit/api/ApiManageMessageGroupsTest.php
index 6feee1d..51521d5 100644
--- a/tests/phpunit/api/ApiManageMessageGroupsTest.php
+++ b/tests/phpunit/api/ApiManageMessageGroupsTest.php
@@ -140,11 +140,11 @@ class ApiManageMessageGroupsTest extends ApiTestCase {
$this->assertArrayHasKey( 'key', $deletedMsg, 'previously renamed message is ' .
' updated when an add as new operation is performed.' );
- $this->assertEquals( $deletedMsg['key'], 'renameDeleted' );
+ $this->assertEquals( 'renameDeleted', $deletedMsg['key'] );
$this->assertArrayHasKey( 'key', $addedMsg, 'previously renamed message is ' .
' updated when an add as new operation is performed.' );
- $this->assertEquals( $addedMsg['key'], 'renameAdded' );
+ $this->assertEquals( 'renameAdded', $addedMsg['key'] );
$deletedMsg = $sourceChanges->findMessage( 'en-gb', 'renameDeleted',
[ MessageSourceChange::DELETION ] );
--
2.20.1
$ date
Tue Nov 9 00:40:57 UTC 2021
$ git clone file:///srv/git/mediawiki-extensions-Translate.git repo --depth=1 -b master
Cloning into 'repo'...
$ git config user.name libraryupgrader
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
$ git submodule update --init
$ grr init
Installed commit-msg hook.
$ git show-ref refs/heads/master
6e42f920c85431f6def82cc8aa52a16bb5e5b797 refs/heads/master
$ composer install
Loading composer repositories with package information
Warning from https://repo.packagist.org: Support for Composer 1 is deprecated and some packages will not be available. You should upgrade to Composer 2. See https://blog.packagist.com/deprecating-composer-1-support/
Updating dependencies (including require-dev)
Package operations: 39 installs, 0 updates, 0 removals
- Installing composer/installers (v2.0.1): Loading from cache
- Installing squizlabs/php_codesniffer (3.6.0): Loading from cache
- Installing dealerdirect/phpcodesniffer-composer-installer (v0.7.1): Downloading (connecting...)Downloading (0%) Downloading (10%)Downloading (20%)Downloading (95%)Downloading (100%)
- Installing mustangostang/spyc (0.6.3): Downloading (connecting...)Downloading (0%) Downloading (20%)Downloading (45%)Downloading (65%)Downloading (85%)Downloading (100%)
- Installing sebastian/diff (3.0.3): Loading from cache
- Installing composer/spdx-licenses (1.5.5): Loading from cache
- Installing composer/semver (3.2.6): Loading from cache
- Installing mediawiki/mediawiki-codesniffer (v37.0.0): Loading from cache
- Installing tysonandre/var_representation_polyfill (0.1.1): Loading from cache
- Installing symfony/polyfill-php80 (v1.23.1): Loading from cache
- Installing symfony/polyfill-mbstring (v1.23.1): Loading from cache
- Installing symfony/polyfill-intl-normalizer (v1.23.0): Loading from cache
- Installing symfony/polyfill-intl-grapheme (v1.23.1): Loading from cache
- Installing symfony/polyfill-ctype (v1.23.0): Loading from cache
- Installing symfony/string (v5.3.10): Loading from cache
- Installing psr/container (1.1.1): Loading from cache
- Installing symfony/service-contracts (v2.4.0): Loading from cache
- Installing symfony/polyfill-php73 (v1.23.0): Loading from cache
- Installing symfony/deprecation-contracts (v2.4.0): Loading from cache
- Installing symfony/console (v5.3.10): Loading from cache
- Installing psr/log (1.1.4): Loading from cache
- Installing sabre/event (5.1.4): Loading from cache
- Installing netresearch/jsonmapper (v4.0.0): Loading from cache
- Installing microsoft/tolerant-php-parser (v0.1.1): Loading from cache
- Installing phpdocumentor/reflection-common (2.2.0): Loading from cache
- Installing webmozart/assert (1.10.0): Loading from cache
- Installing phpdocumentor/type-resolver (1.5.1): Loading from cache
- Installing phpdocumentor/reflection-docblock (5.3.0): Loading from cache
- Installing felixfbecker/advanced-json-rpc (v3.2.1): Loading from cache
- Installing composer/xdebug-handler (2.0.2): Loading from cache
- Installing phan/phan (5.2.0): Loading from cache
- Installing mediawiki/phan-taint-check-plugin (3.3.2): Loading from cache
- Installing mediawiki/mediawiki-phan-config (0.11.0): Loading from cache
- Installing mediawiki/minus-x (1.1.1): Loading from cache
- Installing php-parallel-lint/php-console-color (v0.3): Loading from cache
- Installing php-parallel-lint/php-console-highlighter (v0.5): Loading from cache
- Installing php-parallel-lint/php-parallel-lint (v1.3.1): Loading from cache
- Installing phpstan/phpdoc-parser (0.4.9): Downloading (connecting...)Downloading (0%) Downloading (25%)Downloading (35%)Downloading (60%)Downloading (85%)Downloading (95%)Downloading (100%)
- Installing slevomat/coding-standard (6.4.1): Downloading (connecting...)Downloading (0%) Downloading (5%)Downloading (10%)Downloading (15%)Downloading (20%)Downloading (25%)Downloading (30%)Downloading (35%)Downloading (40%)Downloading (45%)Downloading (50%)Downloading (55%)Downloading (60%)Downloading (65%)Downloading (70%)Downloading (75%)Downloading (80%)Downloading (85%)Downloading (90%)Downloading (95%)Downloading (100%)
tysonandre/var_representation_polyfill suggests installing ext-var_representation (*)
symfony/service-contracts suggests installing symfony/service-implementation
symfony/console suggests installing symfony/event-dispatcher
symfony/console suggests installing symfony/lock
symfony/console suggests installing symfony/process
phan/phan suggests installing ext-ast (Needed for parsing ASTs (unless --use-fallback-parser is used). 1.0.1+ is needed, 1.0.14+ is recommended.)
phan/phan suggests installing ext-var_representation (Suggested for converting values to strings in issue messages)
Writing lock file
Generating autoload files
16 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../slevomat/coding-standard
Upgrading c:mediawiki/mediawiki-codesniffer from 37.0.0 -> 38.0.0
$ composer update
Loading composer repositories with package information
Warning from https://repo.packagist.org: Support for Composer 1 is deprecated and some packages will not be available. You should upgrade to Composer 2. See https://blog.packagist.com/deprecating-composer-1-support/
Updating dependencies (including require-dev)
Package operations: 0 installs, 2 updates, 1 removal
- Removing sebastian/diff (3.0.3)
- Updating squizlabs/php_codesniffer (3.6.0 => 3.6.1): Loading from cache
- Updating mediawiki/mediawiki-codesniffer (v37.0.0 => v38.0.0): Loading from cache
Writing lock file
Generating autoload files
15 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../slevomat/coding-standard
{'MediaWiki.Commenting.MissingCovers.MissingCovers', 'MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPrivate', 'MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic', 'MediaWiki.Commenting.PropertyDocumentation.MissingVar', 'MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationProtected', 'Generic.Files.OneObjectStructurePerFile.MultipleFound', 'MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment', 'MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage', 'MediaWiki.Commenting.PropertyDocumentation.WrongStyle', 'MediaWiki.Commenting.FunctionComment.WrongStyle', 'MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected', 'MediaWiki.Commenting.FunctionComment.MissingDocumentationPrivate'}
Tests fail!
$ vendor/bin/phpcbf
PHPCBF RESULT SUMMARY
----------------------------------------------------------------------
FILE FIXED REMAINING
----------------------------------------------------------------------
.../tests/phpunit/api/ApiManageMessageGroupsTest.php 2 0
----------------------------------------------------------------------
A TOTAL OF 2 ERRORS WERE FIXED IN 1 FILE
----------------------------------------------------------------------
Time: 6.93 secs; Memory: 28MB
$ git checkout .phpcs.xml
$ composer install
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Nothing to install or update
Generating autoload files
15 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
$ composer test
> parallel-lint . --exclude vendor --exclude node_modules --no-progress
PHP 7.3.29 | 10 parallel jobs
Checked 441 files in 2.1 seconds
No syntax error found
> phpcs -p -s --cache
............................................................ 60 / 441 (14%)
............................................................ 120 / 441 (27%)
............................................................ 180 / 441 (41%)
............................................................ 240 / 441 (54%)
............................................................ 300 / 441 (68%)
............................................................ 360 / 441 (82%)
............................................................ 420 / 441 (95%)
..................... 441 / 441 (100%)
Time: 228ms; Memory: 26MB
> minus-x check .
MinusX
======
Processing /src/repo...
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
.............................................................
...................
All good!
$ package-lock-lint package-lock.json
Checking package-lock.json
$ git add .
$ git commit -F /tmp/tmp8yucssrf
[master 11ace46] build: Updating mediawiki/mediawiki-codesniffer to 38.0.0
3 files changed, 5 insertions(+), 4 deletions(-)
$ git format-patch HEAD~1 --stdout
From 11ace460744649c5ec2655f1490b294aa6e418de Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Tue, 9 Nov 2021 00:41:34 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 38.0.0
Additional changes:
* eslint: Added `wikimedia/mediawiki` profile (T262222).
Change-Id: I9778c5cb0cfb01b13a1fc8fcb71cdbc7e1ad359c
---
.eslintrc.json | 3 ++-
composer.json | 2 +-
tests/phpunit/api/ApiManageMessageGroupsTest.php | 4 ++--
3 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/.eslintrc.json b/.eslintrc.json
index 04f9da7..6acf306 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -1,6 +1,7 @@
{
"root": true,
"extends": [
- "wikimedia/server"
+ "wikimedia/server",
+ "wikimedia/mediawiki"
]
}
diff --git a/composer.json b/composer.json
index 61b2d46..ac886d7 100644
--- a/composer.json
+++ b/composer.json
@@ -54,7 +54,7 @@
"mustangostang/spyc": "^0.6.3"
},
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "37.0.0",
+ "mediawiki/mediawiki-codesniffer": "38.0.0",
"mediawiki/mediawiki-phan-config": "0.11.0",
"mediawiki/minus-x": "1.1.1",
"php-parallel-lint/php-console-highlighter": "0.5.0",
diff --git a/tests/phpunit/api/ApiManageMessageGroupsTest.php b/tests/phpunit/api/ApiManageMessageGroupsTest.php
index 6feee1d..51521d5 100644
--- a/tests/phpunit/api/ApiManageMessageGroupsTest.php
+++ b/tests/phpunit/api/ApiManageMessageGroupsTest.php
@@ -140,11 +140,11 @@ class ApiManageMessageGroupsTest extends ApiTestCase {
$this->assertArrayHasKey( 'key', $deletedMsg, 'previously renamed message is ' .
' updated when an add as new operation is performed.' );
- $this->assertEquals( $deletedMsg['key'], 'renameDeleted' );
+ $this->assertEquals( 'renameDeleted', $deletedMsg['key'] );
$this->assertArrayHasKey( 'key', $addedMsg, 'previously renamed message is ' .
' updated when an add as new operation is performed.' );
- $this->assertEquals( $addedMsg['key'], 'renameAdded' );
+ $this->assertEquals( 'renameAdded', $addedMsg['key'] );
$deletedMsg = $sourceChanges->findMessage( 'en-gb', 'renameDeleted',
[ MessageSourceChange::DELETION ] );
--
2.20.1