This run took 18 seconds.
From 6d398a3e90eaa1dd06da253aced9d69466c254a0 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Thu, 14 Nov 2024 11:05:01 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Usage.NullableType.ExplicitNullableTypes
Change-Id: I25aeb1f857154df29014d061fc71c8a58765264b
---
.phpcs.xml | 1 +
composer.json | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/.phpcs.xml b/.phpcs.xml
index 34f062f..e1853ea 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,6 +2,7 @@
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude name="MediaWiki.Commenting.FunctionComment.WrongStyle" />
+ <exclude name="MediaWiki.Usage.NullableType.ExplicitNullableTypes" />
</rule>
<file>.</file>
<arg name="extensions" value="php" />
diff --git a/composer.json b/composer.json
index 453608a..a1edd38 100644
--- a/composer.json
+++ b/composer.json
@@ -1,6 +1,6 @@
{
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "44.0.0",
+ "mediawiki/mediawiki-codesniffer": "45.0.0",
"mediawiki/mediawiki-phan-config": "0.14.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
--
2.39.2
$ date
--- stdout ---
Thu Nov 14 11:04:48 UTC 2024
--- end ---
$ git clone file:///srv/git/mediawiki-extensions-ReadingLists.git repo --depth=1 -b REL1_43
--- stderr ---
Cloning into 'repo'...
--- stdout ---
--- end ---
$ git config user.name libraryupgrader
--- stdout ---
--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---
--- end ---
$ git submodule update --init
--- stdout ---
--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.
--- end ---
$ git show-ref refs/heads/REL1_43
--- stdout ---
be713eac517c9982b9650339fd432fa85ac1a735 refs/heads/REL1_43
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 355,
"dev": 384,
"optional": 3,
"peer": 2,
"peerOptional": 0,
"total": 739
}
}
}
--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 38 installs, 0 updates, 0 removals
- Locking composer/pcre (3.3.2)
- Locking composer/semver (3.4.2)
- Locking composer/spdx-licenses (1.5.8)
- Locking composer/xdebug-handler (3.0.5)
- Locking dealerdirect/phpcodesniffer-composer-installer (v1.0.0)
- Locking doctrine/deprecations (1.1.3)
- Locking felixfbecker/advanced-json-rpc (v3.2.1)
- Locking mediawiki/mediawiki-codesniffer (v44.0.0)
- Locking mediawiki/mediawiki-phan-config (0.14.0)
- Locking mediawiki/minus-x (1.1.3)
- Locking mediawiki/phan-taint-check-plugin (6.0.0)
- Locking microsoft/tolerant-php-parser (v0.1.2)
- Locking netresearch/jsonmapper (v4.5.0)
- Locking phan/phan (5.4.3)
- Locking php-parallel-lint/php-console-color (v1.0.1)
- Locking php-parallel-lint/php-console-highlighter (v1.0.0)
- Locking php-parallel-lint/php-parallel-lint (v1.4.0)
- Locking phpcsstandards/phpcsextra (1.2.1)
- Locking phpcsstandards/phpcsutils (1.0.11)
- Locking phpdocumentor/reflection-common (2.2.0)
- Locking phpdocumentor/reflection-docblock (5.6.0)
- Locking phpdocumentor/type-resolver (1.10.0)
- Locking phpstan/phpdoc-parser (2.0.0)
- Locking psr/container (2.0.2)
- Locking psr/log (3.0.2)
- Locking sabre/event (5.1.7)
- Locking squizlabs/php_codesniffer (3.9.0)
- Locking symfony/console (v7.1.8)
- Locking symfony/deprecation-contracts (v3.5.0)
- Locking symfony/polyfill-ctype (v1.31.0)
- Locking symfony/polyfill-intl-grapheme (v1.31.0)
- Locking symfony/polyfill-intl-normalizer (v1.31.0)
- Locking symfony/polyfill-mbstring (v1.31.0)
- Locking symfony/polyfill-php80 (v1.31.0)
- Locking symfony/service-contracts (v3.5.0)
- Locking symfony/string (v7.1.8)
- Locking tysonandre/var_representation_polyfill (0.1.3)
- Locking webmozart/assert (1.11.0)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 38 installs, 0 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Installing squizlabs/php_codesniffer (3.9.0): Extracting archive
- Installing dealerdirect/phpcodesniffer-composer-installer (v1.0.0): Extracting archive
- Installing composer/pcre (3.3.2): Extracting archive
- Installing symfony/polyfill-php80 (v1.31.0): Extracting archive
- Installing phpcsstandards/phpcsutils (1.0.11): Extracting archive
- Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive
- Installing symfony/polyfill-mbstring (v1.31.0): Extracting archive
- Installing composer/spdx-licenses (1.5.8): Extracting archive
- Installing composer/semver (3.4.2): Extracting archive
- Installing mediawiki/mediawiki-codesniffer (v44.0.0): Extracting archive
- Installing tysonandre/var_representation_polyfill (0.1.3): Extracting archive
- Installing symfony/polyfill-intl-normalizer (v1.31.0): Extracting archive
- Installing symfony/polyfill-intl-grapheme (v1.31.0): Extracting archive
- Installing symfony/polyfill-ctype (v1.31.0): Extracting archive
- Installing symfony/string (v7.1.8): Extracting archive
- Installing symfony/deprecation-contracts (v3.5.0): Extracting archive
- Installing psr/container (2.0.2): Extracting archive
- Installing symfony/service-contracts (v3.5.0): Extracting archive
- Installing symfony/console (v7.1.8): Extracting archive
- Installing sabre/event (5.1.7): Extracting archive
- Installing netresearch/jsonmapper (v4.5.0): Extracting archive
- Installing microsoft/tolerant-php-parser (v0.1.2): Extracting archive
- Installing webmozart/assert (1.11.0): Extracting archive
- Installing phpstan/phpdoc-parser (2.0.0): Extracting archive
- Installing phpdocumentor/reflection-common (2.2.0): Extracting archive
- Installing doctrine/deprecations (1.1.3): Extracting archive
- Installing phpdocumentor/type-resolver (1.10.0): Extracting archive
- Installing phpdocumentor/reflection-docblock (5.6.0): Extracting archive
- Installing felixfbecker/advanced-json-rpc (v3.2.1): Extracting archive
- Installing psr/log (3.0.2): Extracting archive
- Installing composer/xdebug-handler (3.0.5): Extracting archive
- Installing phan/phan (5.4.3): Extracting archive
- Installing mediawiki/phan-taint-check-plugin (6.0.0): Extracting archive
- Installing mediawiki/mediawiki-phan-config (0.14.0): Extracting archive
- Installing mediawiki/minus-x (1.1.3): Extracting archive
- Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
- Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
- Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive
0/36 [>---------------------------] 0%
20/36 [===============>------------] 55%
33/36 [=========================>--] 91%
36/36 [============================] 100%
Generating autoload files
16 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Upgrading c:mediawiki/mediawiki-codesniffer from 44.0.0 -> 45.0.0
$ /usr/bin/composer update
--- stderr ---
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 4 updates, 0 removals
- Upgrading composer/semver (3.4.2 => 3.4.3)
- Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0)
- Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12)
- Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 4 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3): Extracting archive
- Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12): Extracting archive
- Upgrading composer/semver (3.4.2 => 3.4.3): Extracting archive
- Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0): Extracting archive
0/4 [>---------------------------] 0%
3/4 [=====================>------] 75%
4/4 [============================] 100%
Generating autoload files
16 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Previously failing phpcs rules: {'MediaWiki.Commenting.FunctionComment.WrongStyle'}
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":8,"warnings":0,"fixable":6},"files":{"\/src\/repo\/src\/HookHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Doc\/ReadingListEntryRow.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Doc\/ReadingListRowWithMergeFlag.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Doc\/ReadingListEntryRowWithMergeFlag.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ReadingListRepositoryException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/SchemaHookHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ReverseInterwikiLookupInterface.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Doc\/ReadingListRow.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Utils.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Api\/ApiReadingListsSetup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/purge.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/ListsDeleteHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/UtilsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/SpecialReadingLists.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/ListsPagesHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/ServiceWiringTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Api\/ApiReadingLists.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/ListsEntriesDeleteHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/ListsIdHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/ReadingLists.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Api\/ApiReadingListsDeleteEntry.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Api\/ApiReadingListsTeardown.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Api\/ApiQueryTrait.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/ReverseInterwikiLookupTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/populateProjectsFromSiteMatrix.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/ListsUpdateHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/ListsChangesSinceHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/SetupHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Api\/ApiReadingListsCreateTest.php":{"errors":1,"warnings":0,"messages":[{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":76,"column":15}]},"\/src\/repo\/.phan\/config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/ListsEntriesHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Api\/ApiReadingListsUpdate.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/ReadingListsTokenAwareHandlerTrait.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/Rest\/ReadingListsTokenAwareHandlerTraitTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/ListsCreateBatchHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/ListsCreateHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/ListsEntriesCreateHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Api\/ApiTraitTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Api\/ApiReadingListsUpdateTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Rest\/ListsIdHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Api\/ApiReadingListsDelete.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/populateWithTestData.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/TeardownHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/Rest\/RestUtilTraitTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Api\/ApiReadingListsCreateEntry.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/RestUtilTrait.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/ReadingListsTestHelperTrait.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Api\/ApiQueryReadingListEntriesTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Api\/ApiReadingListsCreateEntryTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Api\/ApiQueryReadingLists.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Api\/ApiQueryReadingListsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Api\/ApiReadingListsDeleteEntryTest.php":{"errors":1,"warnings":0,"messages":[{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":66,"column":12}]},"\/src\/repo\/maintenance\/fixListSize.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Api\/ApiReadingListsSetupAndTeardownTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Api\/ApiTrait.php":{"errors":1,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?UserIdentity $user = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":90,"column":50}]},"\/src\/repo\/src\/Api\/ApiQueryReadingListEntries.php":{"errors":1,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?ApiPageSet $resultPageSet = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":53,"column":27}]},"\/src\/repo\/tests\/phpunit\/integration\/Rest\/ListsCreateBatchHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/ServiceWiring.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Rest\/ListsUpdateHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Api\/ApiReadingListsDeleteTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/ListsHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Rest\/ListsEntriesCreateHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Api\/ApiQueryTraitTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/ListsEntriesCreateBatchHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Rest\/ListsPagesHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ReverseInterwikiLookup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Rest\/ListsCreateHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Rest\/SetupAndTeardownHandlersTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Rest\/ListsChangesSinceHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Rest\/ListsEntriesHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Api\/ApiReadingListsCreate.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Rest\/ListsHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/RestTestHelperTrait.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Rest\/ListsEntriesDeleteHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/ReadingListsHandlerTrait.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Rest\/ListsDeleteHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Rest\/ListsEntriesCreateBatchHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ReadingListRepository.php":{"errors":4,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?array $from = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":369,"column":68},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?array $from = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":640,"column":55},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?array $from = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":761,"column":90},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?array $from = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":797,"column":62}]},"\/src\/repo\/tests\/phpunit\/ReadingListRepositoryTest.php":{"errors":0,"warnings":0,"messages":[]}}}
--- end ---
PHPCS run failed
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":8,"warnings":0,"fixable":6},"files":{"\/src\/repo\/src\/Doc\/ReadingListRowWithMergeFlag.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Doc\/ReadingListEntryRow.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Doc\/ReadingListEntryRowWithMergeFlag.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/HookHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ReverseInterwikiLookupInterface.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/SchemaHookHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ReadingListRepositoryException.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Doc\/ReadingListRow.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Utils.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Api\/ApiReadingListsSetup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/SetupHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/ListsDeleteHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/purge.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/ListsChangesSinceHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Api\/ApiReadingLists.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/UtilsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/SpecialReadingLists.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Api\/ApiReadingListsDeleteEntry.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/ServiceWiringTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/ListsEntriesDeleteHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Api\/ApiReadingListsTeardown.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/ListsIdHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Api\/ApiReadingListsUpdate.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/ReadingLists.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/ListsPagesHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Api\/ApiQueryTrait.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/ReverseInterwikiLookupTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/populateProjectsFromSiteMatrix.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/ListsUpdateHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/ListsEntriesHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/TeardownHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/ListsCreateBatchHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Api\/ApiReadingListsCreateTest.php":{"errors":1,"warnings":0,"messages":[{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":76,"column":15}]},"\/src\/repo\/src\/Api\/ApiReadingListsDelete.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/ReadingListsTokenAwareHandlerTrait.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/.phan\/config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Api\/ApiTraitTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/ListsCreateHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/Rest\/ReadingListsTokenAwareHandlerTraitTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Api\/ApiReadingListsUpdateTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Api\/ApiTrait.php":{"errors":1,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?UserIdentity $user = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":90,"column":50}]},"\/src\/repo\/src\/Rest\/ListsEntriesCreateHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Rest\/ListsIdHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/RestUtilTrait.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/unit\/Rest\/RestUtilTraitTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Api\/ApiReadingListsCreateEntryTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Api\/ApiReadingListsDeleteEntryTest.php":{"errors":1,"warnings":0,"messages":[{"message":"You must use \"\/**\" style comments for a function comment","source":"MediaWiki.Commenting.FunctionComment.WrongStyle","severity":5,"fixable":false,"type":"ERROR","line":66,"column":12}]},"\/src\/repo\/src\/Api\/ApiQueryReadingListEntries.php":{"errors":1,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?ApiPageSet $resultPageSet = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":53,"column":27}]},"\/src\/repo\/tests\/phpunit\/Api\/ApiQueryReadingListEntriesTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/populateWithTestData.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Api\/ApiReadingListsCreateEntry.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/ListsHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Api\/ApiReadingListsSetupAndTeardownTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Api\/ApiQueryTraitTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Api\/ApiQueryReadingLists.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/ReadingListsTestHelperTrait.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ReverseInterwikiLookup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Api\/ApiQueryReadingListsTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/maintenance\/fixListSize.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/ListsEntriesCreateBatchHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/Api\/ApiReadingListsDeleteTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Rest\/ListsUpdateHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Rest\/ListsCreateBatchHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Api\/ApiReadingListsCreate.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/ServiceWiring.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Rest\/ListsEntriesCreateHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Rest\/ListsHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Rest\/ListsPagesHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/ReadingListsHandlerTrait.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Rest\/ListsCreateHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Rest\/SetupAndTeardownHandlersTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Rest\/ListsChangesSinceHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Rest\/ListsEntriesDeleteHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Rest\/ListsDeleteHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/RestTestHelperTrait.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Rest\/ListsEntriesHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/tests\/phpunit\/integration\/Rest\/ListsEntriesCreateBatchHandlerTest.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ReadingListRepository.php":{"errors":4,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?array $from = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":369,"column":68},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?array $from = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":640,"column":55},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?array $from = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":761,"column":90},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?array $from = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":797,"column":62}]},"\/src\/repo\/tests\/phpunit\/ReadingListRepositoryTest.php":{"errors":0,"warnings":0,"messages":[]}}}
--- end ---
* sniff MediaWiki.Usage.NullableType.ExplicitNullableTypes is now failing
$ git checkout .phpcs.xml
--- stderr ---
Updated 1 path from the index
--- stdout ---
--- end ---
$ /usr/bin/composer install
--- stderr ---
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating autoload files
16 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
--- end ---
$ /usr/bin/composer test
--- stderr ---
> parallel-lint . --exclude vendor --exclude node_modules
> phpcs -sp --cache
> minus-x check .
--- stdout ---
PHP 8.2.20 | 10 parallel jobs
............................................................ 60/79 ( 75%)
................... 79/79 (100%)
Checked 79 files in 0.4 seconds
No syntax error found
........................................ 40 / 40 (100%)
Time: 292ms; Memory: 10MB
MinusX
======
Processing /src/repo...
.............................................................
.............................................................
.............................................................
.............................................................
................
All good!
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 355,
"dev": 384,
"optional": 3,
"peer": 2,
"peerOptional": 0,
"total": 739
}
}
}
--- end ---
$ package-lock-lint package-lock.json
--- stdout ---
Checking package-lock.json
--- end ---
build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Usage.NullableType.ExplicitNullableTypes
$ git add .
--- stdout ---
--- end ---
$ git commit -F /tmp/tmpujlef3h0
--- stdout ---
[REL1_43 6d398a3] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
2 files changed, 2 insertions(+), 1 deletion(-)
--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From 6d398a3e90eaa1dd06da253aced9d69466c254a0 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Thu, 14 Nov 2024 11:05:01 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Usage.NullableType.ExplicitNullableTypes
Change-Id: I25aeb1f857154df29014d061fc71c8a58765264b
---
.phpcs.xml | 1 +
composer.json | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/.phpcs.xml b/.phpcs.xml
index 34f062f..e1853ea 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,6 +2,7 @@
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude name="MediaWiki.Commenting.FunctionComment.WrongStyle" />
+ <exclude name="MediaWiki.Usage.NullableType.ExplicitNullableTypes" />
</rule>
<file>.</file>
<arg name="extensions" value="php" />
diff --git a/composer.json b/composer.json
index 453608a..a1edd38 100644
--- a/composer.json
+++ b/composer.json
@@ -1,6 +1,6 @@
{
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "44.0.0",
+ "mediawiki/mediawiki-codesniffer": "45.0.0",
"mediawiki/mediawiki-phan-config": "0.14.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
--
2.39.2
--- end ---