log #1582100

$ date
--- stdout ---
Sat Nov  2 04:10:18 UTC 2024

--- end ---
$ git clone file:///srv/git/mediawiki-extensions-UnifiedTaskOverview.git repo --depth=1 -b master
--- stderr ---
Cloning into 'repo'...
--- stdout ---

--- end ---
$ git config user.name libraryupgrader
--- stdout ---

--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---

--- end ---
$ git submodule update --init
--- stdout ---

--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.

--- end ---
$ git show-ref refs/heads/master
--- stdout ---
c9da44bd0044a103cbaf07b598fc3f87bed611a2 refs/heads/master

--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 24 installs, 0 updates, 0 removals
  - Locking composer/installers (v2.3.0)
  - Locking composer/semver (3.4.2)
  - Locking composer/spdx-licenses (1.5.8)
  - Locking dealerdirect/phpcodesniffer-composer-installer (v1.0.0)
  - Locking mediawiki/mediawiki-codesniffer (v44.0.0)
  - Locking mediawiki/minus-x (1.1.3)
  - Locking mwstake/mediawiki-component-manifestregistry (2.1.3)
  - Locking mwstake/mediawiki-componentloader (1.0.0)
  - Locking php-parallel-lint/php-console-color (v1.0.1)
  - Locking php-parallel-lint/php-console-highlighter (v1.0.0)
  - Locking php-parallel-lint/php-parallel-lint (v1.4.0)
  - Locking phpcsstandards/phpcsextra (1.2.1)
  - Locking phpcsstandards/phpcsutils (1.0.11)
  - Locking psr/container (2.0.2)
  - Locking squizlabs/php_codesniffer (3.9.0)
  - Locking symfony/console (v7.1.6)
  - Locking symfony/deprecation-contracts (v3.5.0)
  - Locking symfony/polyfill-ctype (v1.31.0)
  - Locking symfony/polyfill-intl-grapheme (v1.31.0)
  - Locking symfony/polyfill-intl-normalizer (v1.31.0)
  - Locking symfony/polyfill-mbstring (v1.31.0)
  - Locking symfony/polyfill-php80 (v1.31.0)
  - Locking symfony/service-contracts (v3.5.0)
  - Locking symfony/string (v7.1.6)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 24 installs, 0 updates, 0 removals
    0 [>---------------------------]    0 [->--------------------------]
  - Installing composer/installers (v2.3.0): Extracting archive
  - Installing squizlabs/php_codesniffer (3.9.0): Extracting archive
  - Installing dealerdirect/phpcodesniffer-composer-installer (v1.0.0): Extracting archive
  - Installing symfony/polyfill-php80 (v1.31.0): Extracting archive
  - Installing phpcsstandards/phpcsutils (1.0.11): Extracting archive
  - Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive
  - Installing symfony/polyfill-mbstring (v1.31.0): Extracting archive
  - Installing composer/spdx-licenses (1.5.8): Extracting archive
  - Installing composer/semver (3.4.2): Extracting archive
  - Installing mediawiki/mediawiki-codesniffer (v44.0.0): Extracting archive
  - Installing symfony/polyfill-intl-normalizer (v1.31.0): Extracting archive
  - Installing symfony/polyfill-intl-grapheme (v1.31.0): Extracting archive
  - Installing symfony/polyfill-ctype (v1.31.0): Extracting archive
  - Installing symfony/string (v7.1.6): Extracting archive
  - Installing symfony/deprecation-contracts (v3.5.0): Extracting archive
  - Installing psr/container (2.0.2): Extracting archive
  - Installing symfony/service-contracts (v3.5.0): Extracting archive
  - Installing symfony/console (v7.1.6): Extracting archive
  - Installing mediawiki/minus-x (1.1.3): Extracting archive
  - Installing mwstake/mediawiki-componentloader (1.0.0): Extracting archive
  - Installing mwstake/mediawiki-component-manifestregistry (2.1.3): Extracting archive
  - Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
  - Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
  - Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive
  0/21 [>---------------------------]   0%
 21/21 [============================] 100%
Generating autoload files
15 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils

--- end ---
Upgrading c:mediawiki/mediawiki-codesniffer from 44.0.0 -> 45.0.0
$ /usr/bin/composer update
--- stderr ---
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 4 updates, 0 removals
  - Upgrading composer/semver (3.4.2 => 3.4.3)
  - Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0)
  - Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12)
  - Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 4 updates, 0 removals
    0 [>---------------------------]    0 [->--------------------------]
  - Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3): Extracting archive
  - Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12): Extracting archive
  - Upgrading composer/semver (3.4.2 => 3.4.3): Extracting archive
  - Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0): Extracting archive
 0/4 [>---------------------------]   0%
 3/4 [=====================>------]  75%
 4/4 [============================] 100%
Generating autoload files
15 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils

--- end ---
Previously failing phpcs rules: set()
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":2,"warnings":0,"fixable":2},"files":{"\/src\/repo\/languages\/UnifiedTaskOverview.i18n.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Special\/UnifiedTaskOverview.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/ITaskDescriptor.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/ListHandler.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/HookHandler\/SkinTemplateNavigation\/Setup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/GetTaskDescriptors.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/SimpleTaskDescriptor.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AttentionIndicator\/TaskOverview.php":{"errors":2,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?AttentionIndicatorFactory $attentionIndicatorFactory = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":43,"column":38},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?IRegistry $registry = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":44,"column":9}]}}}

--- end ---
PHPCS run failed
$ vendor/bin/phpcbf
--- stdout ---

PHPCBF RESULT SUMMARY
----------------------------------------------------------------------
FILE                                                  FIXED  REMAINING
----------------------------------------------------------------------
/src/repo/src/AttentionIndicator/TaskOverview.php     2      0
----------------------------------------------------------------------
A TOTAL OF 2 ERRORS WERE FIXED IN 1 FILE
----------------------------------------------------------------------

Time: 163ms; Memory: 6MB



--- end ---
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":0,"warnings":0,"fixable":0},"files":{"\/src\/repo\/src\/ITaskDescriptor.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/GetTaskDescriptors.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Special\/UnifiedTaskOverview.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/SimpleTaskDescriptor.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/languages\/UnifiedTaskOverview.i18n.alias.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/HookHandler\/SkinTemplateNavigation\/Setup.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/AttentionIndicator\/TaskOverview.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Rest\/ListHandler.php":{"errors":0,"warnings":0,"messages":[]}}}

--- end ---
$ git checkout .phpcs.xml
--- stderr ---
Updated 1 path from the index
--- stdout ---

--- end ---
$ /usr/bin/composer install
--- stderr ---
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating autoload files
15 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---

--- end ---
$ /usr/bin/composer test
--- stderr ---
> parallel-lint . --exclude vendor --exclude node_modules
> minus-x check .
> phpcs -sp
--- stdout ---
PHP 8.2.20 | 10 parallel jobs
........                                                     8/8 (100%)


Checked 8 files in 0.1 seconds
No syntax error found
MinusX
======
Processing /src/repo...
........................................................
All good!
........ 8 / 8 (100%)


Time: 136ms; Memory: 6MB


--- end ---
build: Updating mediawiki/mediawiki-codesniffer to 45.0.0

$ git add .
--- stdout ---

--- end ---
$ git commit -F /tmp/tmpqhz1c8dv
--- stdout ---
[master 3887252] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
 2 files changed, 3 insertions(+), 3 deletions(-)

--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From 3887252ab29b8085efc02b6daaf64671e7580ad1 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Sat, 2 Nov 2024 04:10:26 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0

Change-Id: I558d24d66e7cbadea7f3c61fa9ac6e3493c812bd
---
 composer.json                           | 2 +-
 src/AttentionIndicator/TaskOverview.php | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/composer.json b/composer.json
index f8c82b3..1aae632 100644
--- a/composer.json
+++ b/composer.json
@@ -9,7 +9,7 @@
 		"mwstake/mediawiki-component-manifestregistry": "~2"
 	},
 	"require-dev": {
-		"mediawiki/mediawiki-codesniffer": "44.0.0",
+		"mediawiki/mediawiki-codesniffer": "45.0.0",
 		"mediawiki/minus-x": "1.1.3",
 		"php-parallel-lint/php-console-highlighter": "1.0.0",
 		"php-parallel-lint/php-parallel-lint": "1.4.0"
diff --git a/src/AttentionIndicator/TaskOverview.php b/src/AttentionIndicator/TaskOverview.php
index 88b1e6a..efc4b97 100644
--- a/src/AttentionIndicator/TaskOverview.php
+++ b/src/AttentionIndicator/TaskOverview.php
@@ -40,8 +40,8 @@ class TaskOverview extends Collection {
 	 * @return IAttentionIndicator
 	 */
 	public static function factory( string $key, Config $config, User $user,
-		MediaWikiServices $services, AttentionIndicatorFactory $attentionIndicatorFactory = null,
-		IRegistry $registry = null ) {
+		MediaWikiServices $services, ?AttentionIndicatorFactory $attentionIndicatorFactory = null,
+		?IRegistry $registry = null ) {
 		if ( !$attentionIndicatorFactory ) {
 			$attentionIndicatorFactory = $services->getService( 'BSAttentionIndicatorFactory' );
 		}
-- 
2.39.2


--- end ---
mediawiki/extensions/UnifiedTaskOverview: main (log #1582100)
