This run took 14 seconds.
From 3ee8bcbbcad47a41a4a472099c79ba0ed89a87b6 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Sat, 2 Nov 2024 00:35:57 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
Change-Id: I3c9aeaeaea0ce8cdc40f9ffd732654517166b69c
---
composer.json | 2 +-
src/Factory.php | 2 +-
src/MetaHandler.php | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/composer.json b/composer.json
index 2785f4b..bf50fd4 100644
--- a/composer.json
+++ b/composer.json
@@ -7,7 +7,7 @@
"composer/installers": "~1.0"
},
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "44.0.0",
+ "mediawiki/mediawiki-codesniffer": "45.0.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
"php-parallel-lint/php-parallel-lint": "1.4.0"
diff --git a/src/Factory.php b/src/Factory.php
index 0d2a537..f88d161 100644
--- a/src/Factory.php
+++ b/src/Factory.php
@@ -34,7 +34,7 @@ class Factory {
* @param \Title|null $title
* @return MetaHandler|null
*/
- public function newFromTitle( \Title $title = null ) {
+ public function newFromTitle( ?\Title $title = null ) {
if ( !$title ) {
return null;
}
diff --git a/src/MetaHandler.php b/src/MetaHandler.php
index ffe7553..1aff79a 100644
--- a/src/MetaHandler.php
+++ b/src/MetaHandler.php
@@ -150,7 +150,7 @@ class MetaHandler implements \JsonSerializable {
* @param \User|null $user
* @return \Status
*/
- public function save( array $params = [], \User $user = null ) {
+ public function save( array $params = [], ?\User $user = null ) {
// TODO: logging
$data = [];
@@ -240,7 +240,7 @@ class MetaHandler implements \JsonSerializable {
* @param \User|null $user
* @return \Status
*/
- public function delete( \User $user = null ) {
+ public function delete( ?\User $user = null ) {
// TODO: logging
if ( !$this->exists() ) {
return \Status::newGood( $this );
--
2.39.2
$ date
--- stdout ---
Sat Nov 2 00:35:47 UTC 2024
--- end ---
$ git clone file:///srv/git/mediawiki-extensions-AdvancedMeta.git repo --depth=1 -b master
--- stderr ---
Cloning into 'repo'...
--- stdout ---
--- end ---
$ git config user.name libraryupgrader
--- stdout ---
--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---
--- end ---
$ git submodule update --init
--- stdout ---
--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.
--- end ---
$ git show-ref refs/heads/master
--- stdout ---
65d10484a36b3a75ab312180588f80e8f88e2f90 refs/heads/master
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 316,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 316
}
}
}
--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 22 installs, 0 updates, 0 removals
- Locking composer/installers (v1.12.0)
- Locking composer/semver (3.4.2)
- Locking composer/spdx-licenses (1.5.8)
- Locking dealerdirect/phpcodesniffer-composer-installer (v1.0.0)
- Locking mediawiki/mediawiki-codesniffer (v44.0.0)
- Locking mediawiki/minus-x (1.1.3)
- Locking php-parallel-lint/php-console-color (v1.0.1)
- Locking php-parallel-lint/php-console-highlighter (v1.0.0)
- Locking php-parallel-lint/php-parallel-lint (v1.4.0)
- Locking phpcsstandards/phpcsextra (1.2.1)
- Locking phpcsstandards/phpcsutils (1.0.11)
- Locking psr/container (2.0.2)
- Locking squizlabs/php_codesniffer (3.9.0)
- Locking symfony/console (v7.1.6)
- Locking symfony/deprecation-contracts (v3.5.0)
- Locking symfony/polyfill-ctype (v1.31.0)
- Locking symfony/polyfill-intl-grapheme (v1.31.0)
- Locking symfony/polyfill-intl-normalizer (v1.31.0)
- Locking symfony/polyfill-mbstring (v1.31.0)
- Locking symfony/polyfill-php80 (v1.31.0)
- Locking symfony/service-contracts (v3.5.0)
- Locking symfony/string (v7.1.6)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 22 installs, 0 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Installing composer/installers (v1.12.0): Extracting archive
- Installing squizlabs/php_codesniffer (3.9.0): Extracting archive
- Installing dealerdirect/phpcodesniffer-composer-installer (v1.0.0): Extracting archive
- Installing symfony/polyfill-php80 (v1.31.0): Extracting archive
- Installing phpcsstandards/phpcsutils (1.0.11): Extracting archive
- Installing phpcsstandards/phpcsextra (1.2.1): Extracting archive
- Installing symfony/polyfill-mbstring (v1.31.0): Extracting archive
- Installing composer/spdx-licenses (1.5.8): Extracting archive
- Installing composer/semver (3.4.2): Extracting archive
- Installing mediawiki/mediawiki-codesniffer (v44.0.0): Extracting archive
- Installing symfony/polyfill-intl-normalizer (v1.31.0): Extracting archive
- Installing symfony/polyfill-intl-grapheme (v1.31.0): Extracting archive
- Installing symfony/polyfill-ctype (v1.31.0): Extracting archive
- Installing symfony/string (v7.1.6): Extracting archive
- Installing symfony/deprecation-contracts (v3.5.0): Extracting archive
- Installing psr/container (2.0.2): Extracting archive
- Installing symfony/service-contracts (v3.5.0): Extracting archive
- Installing symfony/console (v7.1.6): Extracting archive
- Installing mediawiki/minus-x (1.1.3): Extracting archive
- Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
- Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
- Installing php-parallel-lint/php-parallel-lint (v1.4.0): Extracting archive
0/19 [>---------------------------] 0%
19/19 [============================] 100%
Generating autoload files
15 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Upgrading c:mediawiki/mediawiki-codesniffer from 44.0.0 -> 45.0.0
$ /usr/bin/composer update
--- stderr ---
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 4 updates, 0 removals
- Upgrading composer/semver (3.4.2 => 3.4.3)
- Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0)
- Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12)
- Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 4 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Upgrading squizlabs/php_codesniffer (3.9.0 => 3.10.3): Extracting archive
- Upgrading phpcsstandards/phpcsutils (1.0.11 => 1.0.12): Extracting archive
- Upgrading composer/semver (3.4.2 => 3.4.3): Extracting archive
- Upgrading mediawiki/mediawiki-codesniffer (v44.0.0 => v45.0.0): Extracting archive
0/4 [>---------------------------] 0%
3/4 [=====================>------] 75%
4/4 [============================] 100%
Generating autoload files
15 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
Previously failing phpcs rules: {'MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected', 'MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName'}
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":14,"warnings":0,"fixable":3},"files":{"\/src\/repo\/src\/Config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/BeforePageDisplay\/AddResources.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Extension.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/BeforePageDisplay.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/BeforePageDisplay\/AddJSConfigVar.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/BeforePageDisplay\/AddKeywords.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":25,"column":15}]},"\/src\/repo\/src\/Hook\/SkinTemplateNavigationUniversal.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/BeforePageDisplay\/SetHTMLTitle.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/LoadExtensionSchemaUpdates.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/LoadExtensionSchemaUpdates\/AddAdvancedMetaDBSchema.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":17,"column":15}]},"\/src\/repo\/src\/GlobalMetaKeys.php":{"errors":2,"warnings":0,"messages":[{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":34,"column":15},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":41,"column":15}]},"\/src\/repo\/src\/Hook\/BeforePageDisplay\/AddPolicies.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/SkinTemplateNavigationUniversal\/AddAdvancedMeta.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Factory.php":{"errors":2,"warnings":0,"messages":[{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":29,"column":15},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?\\Title $title = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":37,"column":35}]},"\/src\/repo\/includes\/ServiceWiring.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/BeforePageDisplay\/AddDescription.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Api\/Tasks.php":{"errors":5,"warnings":0,"messages":[{"message":"Method name \"task_save\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":26,"column":15},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":26,"column":15},{"message":"Method name \"task_delete\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":65,"column":15},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":65,"column":15},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":165,"column":15}]},"\/src\/repo\/src\/MetaHandler.php":{"errors":3,"warnings":0,"messages":[{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?\\User $user = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":153,"column":47},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":193,"column":15},{"message":"Use PHP 8.4 compatible syntax for explicit nullable types (\"?\\User $user = null\")","source":"MediaWiki.Usage.NullableType.ExplicitNullableTypes","severity":5,"fixable":true,"type":"ERROR","line":243,"column":29}]},"\/src\/repo\/maintenance\/generateAdvancedSitemap.php":{"errors":0,"warnings":0,"messages":[]}}}
--- end ---
PHPCS run failed
$ vendor/bin/phpcbf
--- stdout ---
PHPCBF RESULT SUMMARY
----------------------------------------------------------------------
FILE FIXED REMAINING
----------------------------------------------------------------------
/src/repo/src/Factory.php 1 1
/src/repo/src/MetaHandler.php 2 1
----------------------------------------------------------------------
A TOTAL OF 3 ERRORS WERE FIXED IN 2 FILES
----------------------------------------------------------------------
Time: 418ms; Memory: 6MB
--- end ---
$ vendor/bin/phpcs --report=json
--- stdout ---
{"totals":{"errors":11,"warnings":0,"fixable":0},"files":{"\/src\/repo\/src\/Hook\/LoadExtensionSchemaUpdates\/AddAdvancedMetaDBSchema.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":17,"column":15}]},"\/src\/repo\/src\/Hook\/BeforePageDisplay.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/BeforePageDisplay\/AddDescription.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/SkinTemplateNavigationUniversal\/AddAdvancedMeta.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/BeforePageDisplay\/AddPolicies.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Extension.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/BeforePageDisplay\/SetHTMLTitle.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/includes\/ServiceWiring.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Config.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/BeforePageDisplay\/AddJSConfigVar.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/BeforePageDisplay\/AddResources.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/SkinTemplateNavigationUniversal.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/LoadExtensionSchemaUpdates.php":{"errors":0,"warnings":0,"messages":[]},"\/src\/repo\/src\/Hook\/BeforePageDisplay\/AddKeywords.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":25,"column":15}]},"\/src\/repo\/src\/Api\/Tasks.php":{"errors":5,"warnings":0,"messages":[{"message":"Method name \"task_save\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":26,"column":15},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":26,"column":15},{"message":"Method name \"task_delete\" should use lower camel case.","source":"MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName","severity":5,"fixable":false,"type":"ERROR","line":65,"column":15},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":65,"column":15},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":165,"column":15}]},"\/src\/repo\/src\/GlobalMetaKeys.php":{"errors":2,"warnings":0,"messages":[{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":34,"column":15},{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":41,"column":15}]},"\/src\/repo\/src\/MetaHandler.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":193,"column":15}]},"\/src\/repo\/src\/Factory.php":{"errors":1,"warnings":0,"messages":[{"message":"Missing function doc comment","source":"MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected","severity":5,"fixable":false,"type":"ERROR","line":29,"column":15}]},"\/src\/repo\/maintenance\/generateAdvancedSitemap.php":{"errors":0,"warnings":0,"messages":[]}}}
--- end ---
$ git checkout .phpcs.xml
--- stderr ---
Updated 1 path from the index
--- stdout ---
--- end ---
$ /usr/bin/composer install
--- stderr ---
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating autoload files
15 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
--- end ---
$ /usr/bin/composer test
--- stderr ---
> parallel-lint . --exclude node_modules --exclude vendor
> phpcs -sp --cache
> minus-x check .
--- stdout ---
PHP 8.2.20 | 10 parallel jobs
.................... 20/20 (100%)
Checked 20 files in 0.1 seconds
No syntax error found
.................... 20 / 20 (100%)
Time: 172ms; Memory: 8MB
MinusX
======
Processing /src/repo...
.............................................................
.............................................................
...................
All good!
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 316,
"optional": 0,
"peer": 1,
"peerOptional": 0,
"total": 316
}
}
}
--- end ---
$ package-lock-lint package-lock.json
--- stdout ---
Checking package-lock.json
--- end ---
build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
$ git add .
--- stdout ---
--- end ---
$ git commit -F /tmp/tmpj9qi42cf
--- stdout ---
[master 3ee8bcb] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
3 files changed, 4 insertions(+), 4 deletions(-)
--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From 3ee8bcbbcad47a41a4a472099c79ba0ed89a87b6 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Sat, 2 Nov 2024 00:35:57 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 45.0.0
Change-Id: I3c9aeaeaea0ce8cdc40f9ffd732654517166b69c
---
composer.json | 2 +-
src/Factory.php | 2 +-
src/MetaHandler.php | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/composer.json b/composer.json
index 2785f4b..bf50fd4 100644
--- a/composer.json
+++ b/composer.json
@@ -7,7 +7,7 @@
"composer/installers": "~1.0"
},
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "44.0.0",
+ "mediawiki/mediawiki-codesniffer": "45.0.0",
"mediawiki/minus-x": "1.1.3",
"php-parallel-lint/php-console-highlighter": "1.0.0",
"php-parallel-lint/php-parallel-lint": "1.4.0"
diff --git a/src/Factory.php b/src/Factory.php
index 0d2a537..f88d161 100644
--- a/src/Factory.php
+++ b/src/Factory.php
@@ -34,7 +34,7 @@ class Factory {
* @param \Title|null $title
* @return MetaHandler|null
*/
- public function newFromTitle( \Title $title = null ) {
+ public function newFromTitle( ?\Title $title = null ) {
if ( !$title ) {
return null;
}
diff --git a/src/MetaHandler.php b/src/MetaHandler.php
index ffe7553..1aff79a 100644
--- a/src/MetaHandler.php
+++ b/src/MetaHandler.php
@@ -150,7 +150,7 @@ class MetaHandler implements \JsonSerializable {
* @param \User|null $user
* @return \Status
*/
- public function save( array $params = [], \User $user = null ) {
+ public function save( array $params = [], ?\User $user = null ) {
// TODO: logging
$data = [];
@@ -240,7 +240,7 @@ class MetaHandler implements \JsonSerializable {
* @param \User|null $user
* @return \Status
*/
- public function delete( \User $user = null ) {
+ public function delete( ?\User $user = null ) {
// TODO: logging
if ( !$this->exists() ) {
return \Status::newGood( $this );
--
2.39.2
--- end ---