mediawiki/extensions/TEI: main (log #1262970)

sourcepatches

This run took 14 seconds.

From c07834a4007930fb9495aabf51930310f2d5c00e Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Sat, 13 Apr 2024 14:44:38 +0000
Subject: [PATCH] build: Updating composer dependencies
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* mediawiki/mediawiki-codesniffer: 41.0.0 → 43.0.0
* mediawiki/mediawiki-phan-config: 0.12.1 → 0.14.0

Change-Id: Icab68bba3acaf508db7338ff64d739982f97b992
---
 composer.json                                 |  7 +++---
 includes/Api/ApiTeiConvert.php                |  2 +-
 maintenance/GenerateTeiJsonDefinition.php     |  4 ++--
 .../BetweenTeiAndHtmlConverterTest.php        |  2 +-
 .../ContentModelValidatorTest.php             | 24 +++++++++----------
 5 files changed, 20 insertions(+), 19 deletions(-)

diff --git a/composer.json b/composer.json
index 280454f..4eeb66b 100644
--- a/composer.json
+++ b/composer.json
@@ -10,8 +10,8 @@
 		"ext-libxml": "*"
 	},
 	"require-dev": {
-		"mediawiki/mediawiki-codesniffer": "41.0.0",
-		"mediawiki/mediawiki-phan-config": "0.12.1",
+		"mediawiki/mediawiki-codesniffer": "43.0.0",
+		"mediawiki/mediawiki-phan-config": "0.14.0",
 		"mediawiki/minus-x": "1.1.1",
 		"php-parallel-lint/php-console-highlighter": "1.0.0",
 		"php-parallel-lint/php-parallel-lint": "1.3.2"
@@ -31,7 +31,8 @@
 	},
 	"config": {
 		"allow-plugins": {
-			"composer/installers": true
+			"composer/installers": true,
+			"dealerdirect/phpcodesniffer-composer-installer": true
 		}
 	}
 }
diff --git a/includes/Api/ApiTeiConvert.php b/includes/Api/ApiTeiConvert.php
index dcae577..b2748b2 100644
--- a/includes/Api/ApiTeiConvert.php
+++ b/includes/Api/ApiTeiConvert.php
@@ -106,7 +106,7 @@ class ApiTeiConvert extends ApiBase {
 				$title = Title::makeTitle( NS_MAIN, 'API' );
 			}
 		} else {
-			list( $title, $content ) = $this->getTitleAndContent( $params );
+			[ $title, $content ] = $this->getTitleAndContent( $params );
 
 			if ( $from === null ) {
 				$from = $content->getDefaultFormat();
diff --git a/maintenance/GenerateTeiJsonDefinition.php b/maintenance/GenerateTeiJsonDefinition.php
index 9cc98df..bf23f2c 100644
--- a/maintenance/GenerateTeiJsonDefinition.php
+++ b/maintenance/GenerateTeiJsonDefinition.php
@@ -69,7 +69,7 @@ class GenerateTeiJsonDefinition extends Maintenance {
 	}
 
 	private function importSchema( $schemaIdent ) {
-		foreach ( $this->getElementsWithIdent( 'schemaSpec',  $schemaIdent ) as $schemaSpec ) {
+		foreach ( $this->getElementsWithIdent( 'schemaSpec', $schemaIdent ) as $schemaSpec ) {
 			$this->importSchemaSpec( $schemaSpec );
 		}
 	}
@@ -428,7 +428,7 @@ class GenerateTeiJsonDefinition extends Maintenance {
 			'proxy' => $proxy
 		] );
 
-		list( $code, $desc, $header, $body, $err ) = $client->run( [
+		[ $code, $desc, $header, $body, $err ] = $client->run( [
 			'method' => 'GET',
 			'url' => 'http://www.tei-c.org/release/xml/tei/odd/p5subset.xml'
 		] );
diff --git a/tests/phpunit/Converter/BetweenTeiAndHtmlConverterTest.php b/tests/phpunit/Converter/BetweenTeiAndHtmlConverterTest.php
index 4a0d885..43b84f5 100644
--- a/tests/phpunit/Converter/BetweenTeiAndHtmlConverterTest.php
+++ b/tests/phpunit/Converter/BetweenTeiAndHtmlConverterTest.php
@@ -66,7 +66,7 @@ class BetweenTeiAndHtmlConverterTest extends TestCase {
 		$fileMock->expects( $this->any() )
 			->method( 'transform' )
 			->willReturnCallback( static function ( $params ) use ( $fileMock ) {
-				return new ThumbnailImage( $fileMock,  'http://example.com/file/FooBar.jpg', false, $params );
+				return new ThumbnailImage( $fileMock, 'http://example.com/file/FooBar.jpg', false, $params );
 			} );
 
 		$fileLookupMock = $this->getMockBuilder( FileLookup::class )
diff --git a/tests/phpunit/Model/ContentModel/ContentModelValidatorTest.php b/tests/phpunit/Model/ContentModel/ContentModelValidatorTest.php
index 6a027bc..4c88f32 100644
--- a/tests/phpunit/Model/ContentModel/ContentModelValidatorTest.php
+++ b/tests/phpunit/Model/ContentModel/ContentModelValidatorTest.php
@@ -145,62 +145,62 @@ class ContentModelValidatorTest extends TestCase {
 				StatusValue::newGood()
 			],
 			[
-				[ 'type' => 'textNode' , 'minOccurs' => 0, 'maxOccurs' => 1 ],
+				[ 'type' => 'textNode', 'minOccurs' => 0, 'maxOccurs' => 1 ],
 				[ '#text', '#text' ],
 				StatusValue::newFatal( 'tei-validation-element-content-unexpected-text' )
 			],
 			[
-				[ 'type' => 'textNode' , 'minOccurs' => 0, 'maxOccurs' => 1 ],
+				[ 'type' => 'textNode', 'minOccurs' => 0, 'maxOccurs' => 1 ],
 				[ 'foo' ],
 				StatusValue::newFatal( 'tei-validation-element-content-unexpected-node', 'foo' )
 			],
 			[
-				[ 'type' => 'textNode' , 'minOccurs' => 0, 'maxOccurs' => null ],
+				[ 'type' => 'textNode', 'minOccurs' => 0, 'maxOccurs' => null ],
 				[],
 				StatusValue::newGood()
 			],
 			[
-				[ 'type' => 'textNode' , 'minOccurs' => 0, 'maxOccurs' => null ],
+				[ 'type' => 'textNode', 'minOccurs' => 0, 'maxOccurs' => null ],
 				[ '#text' ],
 				StatusValue::newGood()
 			],
 			[
-				[ 'type' => 'textNode' , 'minOccurs' => 0, 'maxOccurs' => null ],
+				[ 'type' => 'textNode', 'minOccurs' => 0, 'maxOccurs' => null ],
 				[ '#text', '#text' ],
 				StatusValue::newGood()
 			],
 			[
-				[ 'type' => 'textNode' , 'minOccurs' => 0, 'maxOccurs' => null ],
+				[ 'type' => 'textNode', 'minOccurs' => 0, 'maxOccurs' => null ],
 				[ 'foo' ],
 				StatusValue::newFatal( 'tei-validation-element-content-unexpected-node', 'foo' )
 			],
 			[
-				[ 'type' => 'textNode' , 'minOccurs' => 1, 'maxOccurs' => null ],
+				[ 'type' => 'textNode', 'minOccurs' => 1, 'maxOccurs' => null ],
 				[],
 				StatusValue::newFatal( 'tei-validation-element-content-too-short', '#text' )
 			],
 			[
-				[ 'type' => 'textNode' , 'minOccurs' => 1, 'maxOccurs' => null ],
+				[ 'type' => 'textNode', 'minOccurs' => 1, 'maxOccurs' => null ],
 				[ '#text' ],
 				StatusValue::newGood()
 			],
 			[
-				[ 'type' => 'textNode' , 'minOccurs' => 1, 'maxOccurs' => null ],
+				[ 'type' => 'textNode', 'minOccurs' => 1, 'maxOccurs' => null ],
 				[ '#text', '#text' ],
 				StatusValue::newGood()
 			],
 			[
-				[ 'type' => 'textNode' , 'minOccurs' => 1, 'maxOccurs' => null ],
+				[ 'type' => 'textNode', 'minOccurs' => 1, 'maxOccurs' => null ],
 				[ '#text', '#text', '#text' ],
 				StatusValue::newGood()
 			],
 			[
-				[ 'type' => 'textNode' , 'minOccurs' => 1, 'maxOccurs' => null ],
+				[ 'type' => 'textNode', 'minOccurs' => 1, 'maxOccurs' => null ],
 				[ '#text', 'foo' ],
 				StatusValue::newFatal( 'tei-validation-element-content-unexpected-node', 'foo' )
 			],
 			[
-				[ 'type' => 'textNode' , 'minOccurs' => 1, 'maxOccurs' => null ],
+				[ 'type' => 'textNode', 'minOccurs' => 1, 'maxOccurs' => null ],
 				[ 'foo', '#text' ],
 				StatusValue::newFatal( 'tei-validation-element-content-unexpected-node', 'foo' )
 			],
-- 
2.39.2

$ date
--- stdout ---
Sat Apr 13 14:44:27 UTC 2024

--- end ---
$ git clone file:///srv/git/mediawiki-extensions-TEI.git repo --depth=1 -b master
--- stderr ---
Cloning into 'repo'...
--- stdout ---

--- end ---
$ git config user.name libraryupgrader
--- stdout ---

--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---

--- end ---
$ git submodule update --init
--- stdout ---

--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.

--- end ---
$ git show-ref refs/heads/master
--- stdout ---
e11afa76b4865b70347d754e0c97591cfe96452a refs/heads/master

--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
  "auditReportVersion": 2,
  "vulnerabilities": {},
  "metadata": {
    "vulnerabilities": {
      "info": 0,
      "low": 0,
      "moderate": 0,
      "high": 0,
      "critical": 0,
      "total": 0
    },
    "dependencies": {
      "prod": 1,
      "dev": 453,
      "optional": 0,
      "peer": 7,
      "peerOptional": 0,
      "total": 453
    }
  }
}

--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 37 installs, 0 updates, 0 removals
  - Locking composer/installers (v1.12.0)
  - Locking composer/pcre (3.1.3)
  - Locking composer/semver (3.3.2)
  - Locking composer/spdx-licenses (1.5.8)
  - Locking composer/xdebug-handler (3.0.4)
  - Locking doctrine/deprecations (1.1.3)
  - Locking felixfbecker/advanced-json-rpc (v3.2.1)
  - Locking mediawiki/mediawiki-codesniffer (v41.0.0)
  - Locking mediawiki/mediawiki-phan-config (0.12.1)
  - Locking mediawiki/minus-x (1.1.1)
  - Locking mediawiki/phan-taint-check-plugin (4.0.0)
  - Locking microsoft/tolerant-php-parser (v0.1.1)
  - Locking netresearch/jsonmapper (v4.4.1)
  - Locking phan/phan (5.4.1)
  - Locking php-parallel-lint/php-console-color (v1.0.1)
  - Locking php-parallel-lint/php-console-highlighter (v1.0.0)
  - Locking php-parallel-lint/php-parallel-lint (v1.3.2)
  - Locking phpdocumentor/reflection-common (2.2.0)
  - Locking phpdocumentor/reflection-docblock (5.4.0)
  - Locking phpdocumentor/type-resolver (1.8.2)
  - Locking phpstan/phpdoc-parser (1.28.0)
  - Locking psr/container (2.0.2)
  - Locking psr/log (2.0.0)
  - Locking sabre/event (5.1.4)
  - Locking squizlabs/php_codesniffer (3.7.2)
  - Locking symfony/console (v5.4.36)
  - Locking symfony/deprecation-contracts (v3.4.0)
  - Locking symfony/polyfill-ctype (v1.29.0)
  - Locking symfony/polyfill-intl-grapheme (v1.29.0)
  - Locking symfony/polyfill-intl-normalizer (v1.29.0)
  - Locking symfony/polyfill-mbstring (v1.29.0)
  - Locking symfony/polyfill-php73 (v1.29.0)
  - Locking symfony/polyfill-php80 (v1.29.0)
  - Locking symfony/service-contracts (v3.4.2)
  - Locking symfony/string (v6.4.4)
  - Locking tysonandre/var_representation_polyfill (0.1.3)
  - Locking webmozart/assert (1.11.0)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 37 installs, 0 updates, 0 removals
    0 [>---------------------------]    0 [->--------------------------]
  - Installing composer/installers (v1.12.0): Extracting archive
  - Installing composer/pcre (3.1.3): Extracting archive
  - Installing symfony/polyfill-php80 (v1.29.0): Extracting archive
  - Installing squizlabs/php_codesniffer (3.7.2): Extracting archive
  - Installing symfony/polyfill-mbstring (v1.29.0): Extracting archive
  - Installing composer/spdx-licenses (1.5.8): Extracting archive
  - Installing composer/semver (3.3.2): Extracting archive
  - Installing mediawiki/mediawiki-codesniffer (v41.0.0): Extracting archive
  - Installing tysonandre/var_representation_polyfill (0.1.3): Extracting archive
  - Installing symfony/polyfill-intl-normalizer (v1.29.0): Extracting archive
  - Installing symfony/polyfill-intl-grapheme (v1.29.0): Extracting archive
  - Installing symfony/polyfill-ctype (v1.29.0): Extracting archive
  - Installing symfony/string (v6.4.4): Extracting archive
  - Installing psr/container (2.0.2): Extracting archive
  - Installing symfony/service-contracts (v3.4.2): Extracting archive
  - Installing symfony/polyfill-php73 (v1.29.0): Extracting archive
  - Installing symfony/deprecation-contracts (v3.4.0): Extracting archive
  - Installing symfony/console (v5.4.36): Extracting archive
  - Installing sabre/event (5.1.4): Extracting archive
  - Installing netresearch/jsonmapper (v4.4.1): Extracting archive
  - Installing microsoft/tolerant-php-parser (v0.1.1): Extracting archive
  - Installing webmozart/assert (1.11.0): Extracting archive
  - Installing phpstan/phpdoc-parser (1.28.0): Extracting archive
  - Installing phpdocumentor/reflection-common (2.2.0): Extracting archive
  - Installing doctrine/deprecations (1.1.3): Extracting archive
  - Installing phpdocumentor/type-resolver (1.8.2): Extracting archive
  - Installing phpdocumentor/reflection-docblock (5.4.0): Extracting archive
  - Installing felixfbecker/advanced-json-rpc (v3.2.1): Extracting archive
  - Installing psr/log (2.0.0): Extracting archive
  - Installing composer/xdebug-handler (3.0.4): Extracting archive
  - Installing phan/phan (5.4.1): Extracting archive
  - Installing mediawiki/phan-taint-check-plugin (4.0.0): Extracting archive
  - Installing mediawiki/mediawiki-phan-config (0.12.1): Extracting archive
  - Installing mediawiki/minus-x (1.1.1): Extracting archive
  - Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
  - Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
  - Installing php-parallel-lint/php-parallel-lint (v1.3.2): Extracting archive
  0/36 [>---------------------------]   0%
 22/36 [=================>----------]  61%
 35/36 [===========================>]  97%
 36/36 [============================] 100%
3 package suggestions were added by new dependencies, use `composer suggest` to see details.
Generating autoload files
16 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---

--- end ---
Upgrading c:mediawiki/mediawiki-codesniffer from 41.0.0 -> 43.0.0
Upgrading c:mediawiki/mediawiki-phan-config from 0.12.1 -> 0.14.0
$ /usr/bin/composer update
--- stderr ---
Loading composer repositories with package information
Updating dependencies
Lock file operations: 3 installs, 7 updates, 0 removals
  - Upgrading composer/semver (3.3.2 => 3.4.0)
  - Locking dealerdirect/phpcodesniffer-composer-installer (v1.0.0)
  - Upgrading mediawiki/mediawiki-codesniffer (v41.0.0 => v43.0.0)
  - Upgrading mediawiki/mediawiki-phan-config (0.12.1 => 0.14.0)
  - Upgrading mediawiki/phan-taint-check-plugin (4.0.0 => 6.0.0)
  - Upgrading microsoft/tolerant-php-parser (v0.1.1 => v0.1.2)
  - Upgrading phan/phan (5.4.1 => 5.4.3)
  - Locking phpcsstandards/phpcsextra (1.1.2)
  - Locking phpcsstandards/phpcsutils (1.0.9)
  - Upgrading squizlabs/php_codesniffer (3.7.2 => 3.8.1)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 3 installs, 7 updates, 0 removals
    0 [>---------------------------]    0 [->--------------------------]
  - Upgrading squizlabs/php_codesniffer (3.7.2 => 3.8.1): Extracting archive
  - Installing dealerdirect/phpcodesniffer-composer-installer (v1.0.0): Extracting archive
  - Installing phpcsstandards/phpcsutils (1.0.9): Extracting archive
  - Installing phpcsstandards/phpcsextra (1.1.2): Extracting archive
  - Upgrading composer/semver (3.3.2 => 3.4.0): Extracting archive
  - Upgrading mediawiki/mediawiki-codesniffer (v41.0.0 => v43.0.0): Extracting archive
  - Upgrading microsoft/tolerant-php-parser (v0.1.1 => v0.1.2): Extracting archive
  - Upgrading phan/phan (5.4.1 => 5.4.3): Extracting archive
  - Upgrading mediawiki/phan-taint-check-plugin (4.0.0 => 6.0.0): Extracting archive
  - Upgrading mediawiki/mediawiki-phan-config (0.12.1 => 0.14.0): Extracting archive
 0/8 [>---------------------------]   0%
 7/8 [========================>---]  87%
 8/8 [============================] 100%
Generating autoload files
17 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils

--- end ---
{'MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPrivate', 'PSR12.Properties.ConstantVisibility.NotFound', 'MediaWiki.Commenting.FunctionComment.MissingDocumentationPrivate'}
Tests fail!
$ vendor/bin/phpcbf
--- stdout ---

PHPCBF RESULT SUMMARY
--------------------------------------------------------------------------------
FILE                                                            FIXED  REMAINING
--------------------------------------------------------------------------------
.../tests/phpunit/Converter/BetweenTeiAndHtmlConverterTest.php  1      0
/src/repo/maintenance/GenerateTeiJsonDefinition.php             2      15
...ts/phpunit/Model/ContentModel/ContentModelValidatorTest.php  12     1
/src/repo/includes/Api/ApiTeiConvert.php                        1      8
--------------------------------------------------------------------------------
A TOTAL OF 16 ERRORS WERE FIXED IN 4 FILES
--------------------------------------------------------------------------------

Time: 581ms; Memory: 6MB



--- end ---
$ git checkout .phpcs.xml
--- stderr ---
Updated 1 path from the index
--- stdout ---

--- end ---
$ /usr/bin/composer install
--- stderr ---
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating autoload files
17 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---

--- end ---
$ /usr/bin/composer test
--- stderr ---
> parallel-lint . --exclude node_modules --exclude vendor
> phpcs -sp --cache
> minus-x check .
--- stdout ---
PHP 8.2.7 | 10 parallel jobs
...............................................              47/47 (100 %)


Checked 47 files in 0.2 seconds
No syntax error found
............................................... 47 / 47 (100%)


Time: 282ms; Memory: 8MB

MinusX
======
Processing /src/repo...
.............................................................
...........................................................
All good!

--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
  "auditReportVersion": 2,
  "vulnerabilities": {},
  "metadata": {
    "vulnerabilities": {
      "info": 0,
      "low": 0,
      "moderate": 0,
      "high": 0,
      "critical": 0,
      "total": 0
    },
    "dependencies": {
      "prod": 1,
      "dev": 453,
      "optional": 0,
      "peer": 7,
      "peerOptional": 0,
      "total": 453
    }
  }
}

--- end ---
$ package-lock-lint package-lock.json
--- stdout ---
Checking package-lock.json

--- end ---
build: Updating composer dependencies

* mediawiki/mediawiki-codesniffer: 41.0.0 → 43.0.0
* mediawiki/mediawiki-phan-config: 0.12.1 → 0.14.0

$ git add .
--- stdout ---

--- end ---
$ git commit -F /tmp/tmpzyb_hn90
--- stdout ---
[master c07834a] build: Updating composer dependencies
 5 files changed, 20 insertions(+), 19 deletions(-)

--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From c07834a4007930fb9495aabf51930310f2d5c00e Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Sat, 13 Apr 2024 14:44:38 +0000
Subject: [PATCH] build: Updating composer dependencies
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* mediawiki/mediawiki-codesniffer: 41.0.0 → 43.0.0
* mediawiki/mediawiki-phan-config: 0.12.1 → 0.14.0

Change-Id: Icab68bba3acaf508db7338ff64d739982f97b992
---
 composer.json                                 |  7 +++---
 includes/Api/ApiTeiConvert.php                |  2 +-
 maintenance/GenerateTeiJsonDefinition.php     |  4 ++--
 .../BetweenTeiAndHtmlConverterTest.php        |  2 +-
 .../ContentModelValidatorTest.php             | 24 +++++++++----------
 5 files changed, 20 insertions(+), 19 deletions(-)

diff --git a/composer.json b/composer.json
index 280454f..4eeb66b 100644
--- a/composer.json
+++ b/composer.json
@@ -10,8 +10,8 @@
 		"ext-libxml": "*"
 	},
 	"require-dev": {
-		"mediawiki/mediawiki-codesniffer": "41.0.0",
-		"mediawiki/mediawiki-phan-config": "0.12.1",
+		"mediawiki/mediawiki-codesniffer": "43.0.0",
+		"mediawiki/mediawiki-phan-config": "0.14.0",
 		"mediawiki/minus-x": "1.1.1",
 		"php-parallel-lint/php-console-highlighter": "1.0.0",
 		"php-parallel-lint/php-parallel-lint": "1.3.2"
@@ -31,7 +31,8 @@
 	},
 	"config": {
 		"allow-plugins": {
-			"composer/installers": true
+			"composer/installers": true,
+			"dealerdirect/phpcodesniffer-composer-installer": true
 		}
 	}
 }
diff --git a/includes/Api/ApiTeiConvert.php b/includes/Api/ApiTeiConvert.php
index dcae577..b2748b2 100644
--- a/includes/Api/ApiTeiConvert.php
+++ b/includes/Api/ApiTeiConvert.php
@@ -106,7 +106,7 @@ class ApiTeiConvert extends ApiBase {
 				$title = Title::makeTitle( NS_MAIN, 'API' );
 			}
 		} else {
-			list( $title, $content ) = $this->getTitleAndContent( $params );
+			[ $title, $content ] = $this->getTitleAndContent( $params );
 
 			if ( $from === null ) {
 				$from = $content->getDefaultFormat();
diff --git a/maintenance/GenerateTeiJsonDefinition.php b/maintenance/GenerateTeiJsonDefinition.php
index 9cc98df..bf23f2c 100644
--- a/maintenance/GenerateTeiJsonDefinition.php
+++ b/maintenance/GenerateTeiJsonDefinition.php
@@ -69,7 +69,7 @@ class GenerateTeiJsonDefinition extends Maintenance {
 	}
 
 	private function importSchema( $schemaIdent ) {
-		foreach ( $this->getElementsWithIdent( 'schemaSpec',  $schemaIdent ) as $schemaSpec ) {
+		foreach ( $this->getElementsWithIdent( 'schemaSpec', $schemaIdent ) as $schemaSpec ) {
 			$this->importSchemaSpec( $schemaSpec );
 		}
 	}
@@ -428,7 +428,7 @@ class GenerateTeiJsonDefinition extends Maintenance {
 			'proxy' => $proxy
 		] );
 
-		list( $code, $desc, $header, $body, $err ) = $client->run( [
+		[ $code, $desc, $header, $body, $err ] = $client->run( [
 			'method' => 'GET',
 			'url' => 'http://www.tei-c.org/release/xml/tei/odd/p5subset.xml'
 		] );
diff --git a/tests/phpunit/Converter/BetweenTeiAndHtmlConverterTest.php b/tests/phpunit/Converter/BetweenTeiAndHtmlConverterTest.php
index 4a0d885..43b84f5 100644
--- a/tests/phpunit/Converter/BetweenTeiAndHtmlConverterTest.php
+++ b/tests/phpunit/Converter/BetweenTeiAndHtmlConverterTest.php
@@ -66,7 +66,7 @@ class BetweenTeiAndHtmlConverterTest extends TestCase {
 		$fileMock->expects( $this->any() )
 			->method( 'transform' )
 			->willReturnCallback( static function ( $params ) use ( $fileMock ) {
-				return new ThumbnailImage( $fileMock,  'http://example.com/file/FooBar.jpg', false, $params );
+				return new ThumbnailImage( $fileMock, 'http://example.com/file/FooBar.jpg', false, $params );
 			} );
 
 		$fileLookupMock = $this->getMockBuilder( FileLookup::class )
diff --git a/tests/phpunit/Model/ContentModel/ContentModelValidatorTest.php b/tests/phpunit/Model/ContentModel/ContentModelValidatorTest.php
index 6a027bc..4c88f32 100644
--- a/tests/phpunit/Model/ContentModel/ContentModelValidatorTest.php
+++ b/tests/phpunit/Model/ContentModel/ContentModelValidatorTest.php
@@ -145,62 +145,62 @@ class ContentModelValidatorTest extends TestCase {
 				StatusValue::newGood()
 			],
 			[
-				[ 'type' => 'textNode' , 'minOccurs' => 0, 'maxOccurs' => 1 ],
+				[ 'type' => 'textNode', 'minOccurs' => 0, 'maxOccurs' => 1 ],
 				[ '#text', '#text' ],
 				StatusValue::newFatal( 'tei-validation-element-content-unexpected-text' )
 			],
 			[
-				[ 'type' => 'textNode' , 'minOccurs' => 0, 'maxOccurs' => 1 ],
+				[ 'type' => 'textNode', 'minOccurs' => 0, 'maxOccurs' => 1 ],
 				[ 'foo' ],
 				StatusValue::newFatal( 'tei-validation-element-content-unexpected-node', 'foo' )
 			],
 			[
-				[ 'type' => 'textNode' , 'minOccurs' => 0, 'maxOccurs' => null ],
+				[ 'type' => 'textNode', 'minOccurs' => 0, 'maxOccurs' => null ],
 				[],
 				StatusValue::newGood()
 			],
 			[
-				[ 'type' => 'textNode' , 'minOccurs' => 0, 'maxOccurs' => null ],
+				[ 'type' => 'textNode', 'minOccurs' => 0, 'maxOccurs' => null ],
 				[ '#text' ],
 				StatusValue::newGood()
 			],
 			[
-				[ 'type' => 'textNode' , 'minOccurs' => 0, 'maxOccurs' => null ],
+				[ 'type' => 'textNode', 'minOccurs' => 0, 'maxOccurs' => null ],
 				[ '#text', '#text' ],
 				StatusValue::newGood()
 			],
 			[
-				[ 'type' => 'textNode' , 'minOccurs' => 0, 'maxOccurs' => null ],
+				[ 'type' => 'textNode', 'minOccurs' => 0, 'maxOccurs' => null ],
 				[ 'foo' ],
 				StatusValue::newFatal( 'tei-validation-element-content-unexpected-node', 'foo' )
 			],
 			[
-				[ 'type' => 'textNode' , 'minOccurs' => 1, 'maxOccurs' => null ],
+				[ 'type' => 'textNode', 'minOccurs' => 1, 'maxOccurs' => null ],
 				[],
 				StatusValue::newFatal( 'tei-validation-element-content-too-short', '#text' )
 			],
 			[
-				[ 'type' => 'textNode' , 'minOccurs' => 1, 'maxOccurs' => null ],
+				[ 'type' => 'textNode', 'minOccurs' => 1, 'maxOccurs' => null ],
 				[ '#text' ],
 				StatusValue::newGood()
 			],
 			[
-				[ 'type' => 'textNode' , 'minOccurs' => 1, 'maxOccurs' => null ],
+				[ 'type' => 'textNode', 'minOccurs' => 1, 'maxOccurs' => null ],
 				[ '#text', '#text' ],
 				StatusValue::newGood()
 			],
 			[
-				[ 'type' => 'textNode' , 'minOccurs' => 1, 'maxOccurs' => null ],
+				[ 'type' => 'textNode', 'minOccurs' => 1, 'maxOccurs' => null ],
 				[ '#text', '#text', '#text' ],
 				StatusValue::newGood()
 			],
 			[
-				[ 'type' => 'textNode' , 'minOccurs' => 1, 'maxOccurs' => null ],
+				[ 'type' => 'textNode', 'minOccurs' => 1, 'maxOccurs' => null ],
 				[ '#text', 'foo' ],
 				StatusValue::newFatal( 'tei-validation-element-content-unexpected-node', 'foo' )
 			],
 			[
-				[ 'type' => 'textNode' , 'minOccurs' => 1, 'maxOccurs' => null ],
+				[ 'type' => 'textNode', 'minOccurs' => 1, 'maxOccurs' => null ],
 				[ 'foo', '#text' ],
 				StatusValue::newFatal( 'tei-validation-element-content-unexpected-node', 'foo' )
 			],
-- 
2.39.2


--- end ---
Source code is licensed under the AGPL.