This run took 14 seconds.
From 8b111bdeb31f566e4261818073afe373ecf763fc Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Sun, 17 Mar 2024 22:20:09 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 43.0.0
The following sniffs are failing and were disabled:
* Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition
The following sniffs now pass and were enabled:
* MediaWiki.ControlStructures.AssignmentInControlStructures.AssignmentInControlStructures
Change-Id: I950067807b124820ae6af29436ba1fb4ed32ff49
---
.phpcs.xml | 2 +-
composer.json | 7 ++++++-
includes/PagesList.php | 2 +-
includes/specials/PagesListOptions.php | 4 ++--
4 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/.phpcs.xml b/.phpcs.xml
index 09e8490..f17e9ed 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,10 +1,10 @@
<?xml version="1.0"?>
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+ <exclude name="Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition" />
<exclude name="MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation" />
<exclude name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
<exclude name="MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam" />
- <exclude name="MediaWiki.ControlStructures.AssignmentInControlStructures.AssignmentInControlStructures" />
<exclude name="MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage" />
<exclude name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
<exclude name="PSR12.Properties.ConstantVisibility.NotFound" />
diff --git a/composer.json b/composer.json
index 3e7043f..06286b3 100644
--- a/composer.json
+++ b/composer.json
@@ -1,6 +1,6 @@
{
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "41.0.0",
+ "mediawiki/mediawiki-codesniffer": "43.0.0",
"mediawiki/minus-x": "1.1.1",
"php-parallel-lint/php-console-highlighter": "1.0.0",
"php-parallel-lint/php-parallel-lint": "1.3.2"
@@ -16,5 +16,10 @@
"phpcbf"
],
"phpcs": "phpcs -sp --cache"
+ },
+ "config": {
+ "allow-plugins": {
+ "dealerdirect/phpcodesniffer-composer-installer": true
+ }
}
}
diff --git a/includes/PagesList.php b/includes/PagesList.php
index a260a0e..9d55800 100644
--- a/includes/PagesList.php
+++ b/includes/PagesList.php
@@ -110,7 +110,7 @@ class PagesList extends ContextSource {
*/
public function doQuery( $offset = false, $limit = false, $indexField = 'rev_timestamp',
$descending = true ) {
- list( $tables, $fields, $conds, $fname, $options, $join_conds ) = $this->buildQueryInfo( $offset,
+ [ $tables, $fields, $conds, $fname, $options, $join_conds ] = $this->buildQueryInfo( $offset,
$limit, $indexField, $descending );
$this->result = $this->db->select(
$tables, $fields, $conds, $fname, $options, $join_conds
diff --git a/includes/specials/PagesListOptions.php b/includes/specials/PagesListOptions.php
index c12bd22..81a68a8 100644
--- a/includes/specials/PagesListOptions.php
+++ b/includes/specials/PagesListOptions.php
@@ -135,7 +135,7 @@ class PagesListOptions extends ContextSource {
* @return array
*/
protected function categoryFilterForm( FormOptions $opts ) {
- list( $label, $input ) = Xml::inputLabelSep( $this->msg( 'pageslist-categories' )->text(),
+ [ $label, $input ] = Xml::inputLabelSep( $this->msg( 'pageslist-categories' )->text(),
'categories', 'mw-categories', false, $opts['categories'] );
return [ $label, $input ];
@@ -146,7 +146,7 @@ class PagesListOptions extends ContextSource {
* @return array
*/
protected function basepageFilterForm( FormOptions $opts ) {
- list( $label, $input ) = Xml::inputLabelSep( $this->msg( 'pageslist-basepage' )->text(),
+ [ $label, $input ] = Xml::inputLabelSep( $this->msg( 'pageslist-basepage' )->text(),
'basepage', 'mw-basepage', false, $opts['basepage'] );
return [ $label, $input ];
--
2.39.2
$ date
--- stdout ---
Sun Mar 17 22:20:00 UTC 2024
--- end ---
$ git clone file:///srv/git/mediawiki-extensions-PagesList.git repo --depth=1 -b master
--- stderr ---
Cloning into 'repo'...
--- stdout ---
--- end ---
$ git config user.name libraryupgrader
--- stdout ---
--- end ---
$ git config user.email tools.libraryupgrader@tools.wmflabs.org
--- stdout ---
--- end ---
$ git submodule update --init
--- stderr ---
Submodule 'modules/DataTables' (https://github.com/DataTables/DataTables.git) registered for path 'modules/DataTables'
Cloning into '/src/repo/modules/DataTables'...
--- stdout ---
Submodule path 'modules/DataTables': checked out '24b2d114606725d05c1e79155284babc47d728ca'
--- end ---
$ grr init
--- stdout ---
Installed commit-msg hook.
--- end ---
$ git show-ref refs/heads/master
--- stdout ---
c1e63b2abb52c480b03c2aefae33a46d6ca67af8 refs/heads/master
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 448,
"optional": 0,
"peer": 7,
"peerOptional": 0,
"total": 448
}
}
}
--- end ---
$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 19 installs, 0 updates, 0 removals
- Locking composer/semver (3.3.2)
- Locking composer/spdx-licenses (1.5.8)
- Locking mediawiki/mediawiki-codesniffer (v41.0.0)
- Locking mediawiki/minus-x (1.1.1)
- Locking php-parallel-lint/php-console-color (v1.0.1)
- Locking php-parallel-lint/php-console-highlighter (v1.0.0)
- Locking php-parallel-lint/php-parallel-lint (v1.3.2)
- Locking psr/container (2.0.2)
- Locking squizlabs/php_codesniffer (3.7.2)
- Locking symfony/console (v5.4.36)
- Locking symfony/deprecation-contracts (v3.4.0)
- Locking symfony/polyfill-ctype (v1.29.0)
- Locking symfony/polyfill-intl-grapheme (v1.29.0)
- Locking symfony/polyfill-intl-normalizer (v1.29.0)
- Locking symfony/polyfill-mbstring (v1.29.0)
- Locking symfony/polyfill-php73 (v1.29.0)
- Locking symfony/polyfill-php80 (v1.29.0)
- Locking symfony/service-contracts (v3.4.1)
- Locking symfony/string (v6.4.4)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 19 installs, 0 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Installing symfony/polyfill-php80 (v1.29.0): Extracting archive
- Installing squizlabs/php_codesniffer (3.7.2): Extracting archive
- Installing symfony/polyfill-mbstring (v1.29.0): Extracting archive
- Installing composer/spdx-licenses (1.5.8): Extracting archive
- Installing composer/semver (3.3.2): Extracting archive
- Installing mediawiki/mediawiki-codesniffer (v41.0.0): Extracting archive
- Installing symfony/polyfill-intl-normalizer (v1.29.0): Extracting archive
- Installing symfony/polyfill-intl-grapheme (v1.29.0): Extracting archive
- Installing symfony/polyfill-ctype (v1.29.0): Extracting archive
- Installing symfony/string (v6.4.4): Extracting archive
- Installing psr/container (2.0.2): Extracting archive
- Installing symfony/service-contracts (v3.4.1): Extracting archive
- Installing symfony/polyfill-php73 (v1.29.0): Extracting archive
- Installing symfony/deprecation-contracts (v3.4.0): Extracting archive
- Installing symfony/console (v5.4.36): Extracting archive
- Installing mediawiki/minus-x (1.1.1): Extracting archive
- Installing php-parallel-lint/php-console-color (v1.0.1): Extracting archive
- Installing php-parallel-lint/php-console-highlighter (v1.0.0): Extracting archive
- Installing php-parallel-lint/php-parallel-lint (v1.3.2): Extracting archive
0/19 [>---------------------------] 0%
18/19 [==========================>-] 94%
19/19 [============================] 100%
4 package suggestions were added by new dependencies, use `composer suggest` to see details.
Generating autoload files
13 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
--- end ---
Upgrading c:mediawiki/mediawiki-codesniffer from 41.0.0 -> 43.0.0
$ /usr/bin/composer update
--- stderr ---
Loading composer repositories with package information
Updating dependencies
Lock file operations: 3 installs, 3 updates, 0 removals
- Upgrading composer/semver (3.3.2 => 3.4.0)
- Locking dealerdirect/phpcodesniffer-composer-installer (v1.0.0)
- Upgrading mediawiki/mediawiki-codesniffer (v41.0.0 => v43.0.0)
- Locking phpcsstandards/phpcsextra (1.1.2)
- Locking phpcsstandards/phpcsutils (1.0.9)
- Upgrading squizlabs/php_codesniffer (3.7.2 => 3.8.1)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 3 installs, 3 updates, 0 removals
0 [>---------------------------] 0 [->--------------------------]
- Upgrading squizlabs/php_codesniffer (3.7.2 => 3.8.1): Extracting archive
- Installing dealerdirect/phpcodesniffer-composer-installer (v1.0.0): Extracting archive
- Installing phpcsstandards/phpcsutils (1.0.9): Extracting archive
- Installing phpcsstandards/phpcsextra (1.1.2): Extracting archive
- Upgrading composer/semver (3.3.2 => 3.4.0): Extracting archive
- Upgrading mediawiki/mediawiki-codesniffer (v41.0.0 => v43.0.0): Extracting archive
0/4 [>---------------------------] 0%
4/4 [============================] 100%
Generating autoload files
14 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found
--- stdout ---
PHP CodeSniffer Config installed_paths set to ../../mediawiki/mediawiki-codesniffer,../../phpcsstandards/phpcsextra,../../phpcsstandards/phpcsutils
--- end ---
{'PSR12.Properties.ConstantVisibility.NotFound', 'MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment', 'Squiz.Scope.MethodScope.Missing', 'PSR2.ControlStructures.SwitchDeclaration.TerminatingComment', 'MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage', 'MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam', 'MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic', 'MediaWiki.ControlStructures.AssignmentInControlStructures.AssignmentInControlStructures', 'MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation'}
Tests fail!
$ vendor/bin/phpcbf
--- stdout ---
PHPCBF RESULT SUMMARY
----------------------------------------------------------------------
FILE FIXED REMAINING
----------------------------------------------------------------------
/src/repo/includes/specials/PagesListOptions.php 2 4
/src/repo/includes/PagesList.php 1 23
----------------------------------------------------------------------
A TOTAL OF 3 ERRORS WERE FIXED IN 2 FILES
----------------------------------------------------------------------
Time: 220ms; Memory: 6MB
--- end ---
$ git checkout .phpcs.xml
--- stderr ---
Updated 1 path from the index
--- stdout ---
--- end ---
$ /usr/bin/composer install
--- stderr ---
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Generating autoload files
14 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
--- stdout ---
--- end ---
$ /usr/bin/composer test
--- stderr ---
> parallel-lint . --exclude vendor --exclude node_modules
> minus-x check .
> phpcs -sp --cache
--- stdout ---
PHP 8.2.7 | 10 parallel jobs
.................................... 36/36 (100 %)
Checked 36 files in 0.2 seconds
No syntax error found
MinusX
======
Processing /src/repo...
.............................................................
....................................
All good!
........ 8 / 8 (100%)
Time: 121ms; Memory: 8MB
--- end ---
$ /usr/bin/npm audit --json
--- stdout ---
{
"auditReportVersion": 2,
"vulnerabilities": {},
"metadata": {
"vulnerabilities": {
"info": 0,
"low": 0,
"moderate": 0,
"high": 0,
"critical": 0,
"total": 0
},
"dependencies": {
"prod": 1,
"dev": 448,
"optional": 0,
"peer": 7,
"peerOptional": 0,
"total": 448
}
}
}
--- end ---
$ package-lock-lint package-lock.json
--- stdout ---
Checking package-lock.json
--- end ---
build: Updating mediawiki/mediawiki-codesniffer to 43.0.0
The following sniffs are failing and were disabled:
* Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition
The following sniffs now pass and were enabled:
* MediaWiki.ControlStructures.AssignmentInControlStructures.AssignmentInControlStructures
$ git add .
--- stdout ---
--- end ---
$ git commit -F /tmp/tmp38f5q06l
--- stdout ---
[master 8b111bd] build: Updating mediawiki/mediawiki-codesniffer to 43.0.0
4 files changed, 10 insertions(+), 5 deletions(-)
--- end ---
$ git format-patch HEAD~1 --stdout
--- stdout ---
From 8b111bdeb31f566e4261818073afe373ecf763fc Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Sun, 17 Mar 2024 22:20:09 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 43.0.0
The following sniffs are failing and were disabled:
* Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition
The following sniffs now pass and were enabled:
* MediaWiki.ControlStructures.AssignmentInControlStructures.AssignmentInControlStructures
Change-Id: I950067807b124820ae6af29436ba1fb4ed32ff49
---
.phpcs.xml | 2 +-
composer.json | 7 ++++++-
includes/PagesList.php | 2 +-
includes/specials/PagesListOptions.php | 4 ++--
4 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/.phpcs.xml b/.phpcs.xml
index 09e8490..f17e9ed 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,10 +1,10 @@
<?xml version="1.0"?>
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+ <exclude name="Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition" />
<exclude name="MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation" />
<exclude name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
<exclude name="MediaWiki.Commenting.FunctionComment.ObjectTypeHintParam" />
- <exclude name="MediaWiki.ControlStructures.AssignmentInControlStructures.AssignmentInControlStructures" />
<exclude name="MediaWiki.Usage.ExtendClassUsage.FunctionConfigUsage" />
<exclude name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
<exclude name="PSR12.Properties.ConstantVisibility.NotFound" />
diff --git a/composer.json b/composer.json
index 3e7043f..06286b3 100644
--- a/composer.json
+++ b/composer.json
@@ -1,6 +1,6 @@
{
"require-dev": {
- "mediawiki/mediawiki-codesniffer": "41.0.0",
+ "mediawiki/mediawiki-codesniffer": "43.0.0",
"mediawiki/minus-x": "1.1.1",
"php-parallel-lint/php-console-highlighter": "1.0.0",
"php-parallel-lint/php-parallel-lint": "1.3.2"
@@ -16,5 +16,10 @@
"phpcbf"
],
"phpcs": "phpcs -sp --cache"
+ },
+ "config": {
+ "allow-plugins": {
+ "dealerdirect/phpcodesniffer-composer-installer": true
+ }
}
}
diff --git a/includes/PagesList.php b/includes/PagesList.php
index a260a0e..9d55800 100644
--- a/includes/PagesList.php
+++ b/includes/PagesList.php
@@ -110,7 +110,7 @@ class PagesList extends ContextSource {
*/
public function doQuery( $offset = false, $limit = false, $indexField = 'rev_timestamp',
$descending = true ) {
- list( $tables, $fields, $conds, $fname, $options, $join_conds ) = $this->buildQueryInfo( $offset,
+ [ $tables, $fields, $conds, $fname, $options, $join_conds ] = $this->buildQueryInfo( $offset,
$limit, $indexField, $descending );
$this->result = $this->db->select(
$tables, $fields, $conds, $fname, $options, $join_conds
diff --git a/includes/specials/PagesListOptions.php b/includes/specials/PagesListOptions.php
index c12bd22..81a68a8 100644
--- a/includes/specials/PagesListOptions.php
+++ b/includes/specials/PagesListOptions.php
@@ -135,7 +135,7 @@ class PagesListOptions extends ContextSource {
* @return array
*/
protected function categoryFilterForm( FormOptions $opts ) {
- list( $label, $input ) = Xml::inputLabelSep( $this->msg( 'pageslist-categories' )->text(),
+ [ $label, $input ] = Xml::inputLabelSep( $this->msg( 'pageslist-categories' )->text(),
'categories', 'mw-categories', false, $opts['categories'] );
return [ $label, $input ];
@@ -146,7 +146,7 @@ class PagesListOptions extends ContextSource {
* @return array
*/
protected function basepageFilterForm( FormOptions $opts ) {
- list( $label, $input ) = Xml::inputLabelSep( $this->msg( 'pageslist-basepage' )->text(),
+ [ $label, $input ] = Xml::inputLabelSep( $this->msg( 'pageslist-basepage' )->text(),
'basepage', 'mw-basepage', false, $opts['basepage'] );
return [ $label, $input ];
--
2.39.2
--- end ---